[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T325000

Release v0.44.4
Closed, ResolvedPublic
Actions

Description

I've made a v0.44 branch (to allow some backports for MW 1.39, primarily T324896: Deprecated: Creation of dynamic property in oojs/oojs-ui), and prepared a v0.44.4 release ontop of that... https://github.com/wikimedia/oojs-ui/compare/v0.44.3...v0.44

I haven't pushed the git tag yet, primarily because I'm pretty I don't have the rights to do the npm publish steps...

Can someone do the last two steps for me please on the v0.44 branch?

$ git tag "v$(node -e 'console.log(require("./package").version);')"
$ npm run publish-build && git push --tags && npm publish

Details

SubjectRepoBranchLines +/-
Update VE core submodule to origin/REL1_39mediawiki/extensions/VisualEditormaster+1 -1
Upgrading oojs/oojs-ui (v0.44.3 => v0.44.4)mediawiki/coreREL1_39+58 -49
Update VE core submodule to REL1_39's OOUI update (95ccd3290)mediawiki/extensions/VisualEditorREL1_39+1 -1
Update OOUI to v0.44.4VisualEditor/VisualEditorREL1_39+338 -330
Upgrading oojs/oojs-ui (v0.44.3 => v0.44.4)mediawiki/vendorREL1_39+381 -101
Customize query in gerrit

Related Objects
Search...

Event Timeline

Reedy created this task.Dec 12 2022, 5:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 12 2022, 5:41 PM
Reedy added a project: PHP 8.2 support.Dec 12 2022, 5:44 PM
Reedy updated the task description. (Show Details)
Reedy moved this task from Backlog to Next-up on the OOUI board.Dec 12 2022, 5:47 PM
Jdforrester-WMF subscribed.Dec 13 2022, 4:48 PM

I think this is the second ever time we've created a non-latest branch release for OOUI so our processes are a bit meh (and the other time was for a prod UBN). Some of this code should ideally ride the prod train for verification before we rush it out in 1.39.1. Happy to tag if we're sure though.

Reedy added a comment.Dec 13 2022, 5:14 PM
In T325000#8463987, @Jdforrester-WMF wrote:

I think this is the second ever time we've created a non-latest branch release for OOUI so our processes are a bit meh (and the other time was for a prod UBN). Some of this code should ideally ride the prod train for verification before we rush it out in 1.39.1. Happy to tag if we're sure though.

Just need to get a master release in first.. And then the train to run ;). But getting a release of master, into MW core master and being able to test it on dev wikis too...

REL1_39 being an LTS, and if we're backporting fixes for 8.x, chances are this might not be the last one

Reedy triaged this task as High priority.Jan 3 2023, 7:17 PM
Reedy moved this task from Backlog to MediaWiki core on the PHP 8.2 support board.Jan 3 2023, 10:12 PM
Jdforrester-WMF added a comment.Jan 4 2023, 5:29 PM

Done. Note that I had to do a follow-up npm dist-tag add oojs-ui@v0.46.0 latest to re-tag the latest release as the latest one.

Now we need to pull this through to REL1_39 vendor, core, and VE, I suppose?

Reedy added a comment.Jan 4 2023, 7:22 PM
In T325000#8499422, @Jdforrester-WMF wrote:

Done. Note that I had to do a follow-up npm dist-tag add oojs-ui@v0.46.0 latest to re-tag the latest release as the latest one.

Now we need to pull this through to REL1_39 vendor, core, and VE, I suppose?

Thanks!

The first two definitely... The third, should mostly be a no-op (no JS changes in https://github.com/wikimedia/oojs-ui/compare/v0.44.3...v0.44.4), but makes sense for consistency purposes at least.

gerritbot added a comment.Jan 4 2023, 7:23 PM

Change 875412 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/vendor@REL1_39] Upgrading oojs/oojs-ui (v0.44.3 => v0.44.4)

https://gerrit.wikimedia.org/r/875412

gerritbot added a project: Patch-For-Review.Jan 4 2023, 7:23 PM
gerritbot added a comment.Jan 4 2023, 7:25 PM

Change 875413 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_39] Upgrading oojs/oojs-ui (v0.44.3 => v0.44.4)

https://gerrit.wikimedia.org/r/875413

Reedy added a comment.Jan 4 2023, 7:32 PM
In T325000#8499834, @Reedy wrote:
In T325000#8499422, @Jdforrester-WMF wrote:

Done. Note that I had to do a follow-up npm dist-tag add oojs-ui@v0.46.0 latest to re-tag the latest release as the latest one.

Now we need to pull this through to REL1_39 vendor, core, and VE, I suppose?

Thanks!

The first two definitely... The third, should mostly be a no-op (no JS changes in https://github.com/wikimedia/oojs-ui/compare/v0.44.3...v0.44.4), but makes sense for consistency purposes at least.

Patches up for the PHP side...

I guess inside MW core, the npm update will "just" be the History.md under resources... And the same under the VE tree?

Reedy mentioned this in T325954: OOUI release v0.46.1.Jan 4 2023, 7:34 PM
Reedy added a subtask: T324896: Deprecated: Creation of dynamic property in oojs/oojs-ui.
gerritbot added a comment.Jan 4 2023, 7:45 PM

Change 875421 had a related patch set uploaded (by Jforrester; author: Jforrester):

[VisualEditor/VisualEditor@REL1_39] Update OOUI to v0.44.4

https://gerrit.wikimedia.org/r/875421

gerritbot added a comment.Jan 4 2023, 7:52 PM

Change 875412 merged by Reedy:

[mediawiki/vendor@REL1_39] Upgrading oojs/oojs-ui (v0.44.3 => v0.44.4)

https://gerrit.wikimedia.org/r/875412

gerritbot added a comment.Jan 4 2023, 7:59 PM

Change 875421 merged by jenkins-bot:

[VisualEditor/VisualEditor@REL1_39] Update OOUI to v0.44.4

https://gerrit.wikimedia.org/r/875421

gerritbot added a comment.Jan 4 2023, 8:05 PM

Change 875424 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/VisualEditor@REL1_39] Update VE core submodule to REL1_39's OOUI update (95ccd3290)

https://gerrit.wikimedia.org/r/875424

gerritbot added a comment.Jan 4 2023, 8:09 PM

Change 875424 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@REL1_39] Update VE core submodule to REL1_39's OOUI update (95ccd3290)

https://gerrit.wikimedia.org/r/875424

gerritbot added a comment.Jan 4 2023, 8:13 PM

Change 875413 merged by jenkins-bot:

[mediawiki/core@REL1_39] Upgrading oojs/oojs-ui (v0.44.3 => v0.44.4)

https://gerrit.wikimedia.org/r/875413

Jdforrester-WMF closed this task as Resolved.Jan 4 2023, 8:18 PM
Jdforrester-WMF claimed this task.
Maintenance_bot removed a project: Patch-For-Review.Jan 4 2023, 8:31 PM
ReleaseTaggerBot added a project: MW-1.39-notes.Jan 4 2023, 9:00 PM
gerritbot added a comment.Jan 30 2023, 5:03 PM

Change 884539 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to origin/REL1_39

https://gerrit.wikimedia.org/r/884539

gerritbot added a project: Patch-For-Review.Jan 30 2023, 5:03 PM
gerritbot added a comment.Jan 30 2023, 5:19 PM

Change 884539 abandoned by Reedy:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to origin/REL1_39

Reason:

https://gerrit.wikimedia.org/r/884539

Maintenance_bot removed a project: Patch-For-Review.Jan 30 2023, 5:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits