Mark mixin imports consistently as `reference`
Closed, ResolvedPublicFeature
Actions

Assigned To

Authored By

	Volker_E
	Dec 1 2022, 9:42 AM

Description

Background

Mixins are implicit references.
We're currently mixin import statements for mixins:

Combobox.vue

@import ( reference ) '@wikimedia/codex-design-tokens/theme-wikimedia-ui.less';
@import './../../themes/mixins/icon-alignment.less';
@import './../../themes/mixins/element-with-menu-expanded.less';

Tabs.vue

@import ( reference ) '@wikimedia/codex-design-tokens/theme-wikimedia-ui.less';
@import ( reference ) '../../themes/mixins/common.less';

Let's settle on one way: the more explicit, probably clearer from dev experience view and more fail-safe would be to always use reference.

Acceptance criteria for Done

Settle on which path to choose: @import ( reference ) as clearer dev experience and more failsafe
- Unify import statements in code base

Details

	Subject	Repo	Branch	Lines +/-
	Update Codex from v0.3.0 to v0.4.0	mediawiki/core	master	+664 -637
	styles: Make mixin imports consistent	design/codex	main	+26 -23

Customize query in gerrit

Event Timeline

Volker_E created this task.Dec 1 2022, 9:42 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 1 2022, 9:42 AM

Change 863054 had a related patch set uploaded (by Catrope; author: Catrope):

[design/codex@main] styles: Make mixin imports consistent

https://gerrit.wikimedia.org/r/863054

gerritbot added a project: Patch-For-Review.Dec 1 2022, 11:34 PM

• Catrope claimed this task.Dec 1 2022, 11:35 PM

• Catrope moved this task from Committed to Code Review on the Design-System-Team (Design-System-Sprint) board.

Change 863054 merged by jenkins-bot:

[design/codex@main] styles: Make mixin imports consistent

https://gerrit.wikimedia.org/r/863054

Maintenance_bot removed a project: Patch-For-Review.Dec 2 2022, 1:30 AM

Volker_E updated the task description. (Show Details)Dec 2 2022, 2:05 PM

Volker_E updated the task description. (Show Details)

Volker_E moved this task from Code Review to Pending Release on the Design-System-Team (Design-System-Sprint) board.

Change 865151 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[mediawiki/core@master] Update Codex from v0.3.0 to v0.4.0

https://gerrit.wikimedia.org/r/865151

gerritbot added a project: Patch-For-Review.Dec 6 2022, 6:59 PM

Change 865151 merged by jenkins-bot: