[go: up one dir, main page]

Page MenuHomePhabricator

Deemphasize treatment of "Learn more about this page" Link
Closed, ResolvedPublic

Description

Behavior

Revise the weight of the Learn more about this page link/button that appears atop mobile talk pages.

❗️Actual✅ Desired
image.png (2×1 px, 935 KB)
image.png (1×736 px, 180 KB)

Deployment timing

  • This fix ought to be deployed alongside T321961

Done

  • Desired behavior is implemented

Event Timeline

hi Design-System-Team, I'm tagging y'all on this ticket for two reasons:

  1. We thought you'd value being made aware of the modification the Editing Team is making to this component and
  2. We thought that in the event that you're tracking "modifications teams are making to standard components" in any particular place, you might consider adding this as an example to that "list"

@ppelberg There are multiple differences between the “Actual” and “Desired” screenshots; in particular, both the font weight of the “Learn more about this page” link and its relative position to the Add topic button differ. Could you please elaborate on what exactly needs to be changed?

Peter was saying in a meeting today that it's just about the font weight. Please ignore other differences, I think it's just an older version of the design.

Change 865745 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Deemphasize "Learn more about this page" link

https://gerrit.wikimedia.org/r/865745

Peter was saying in a meeting today that it's just about the font weight. Please ignore other differences, I think it's just an older version of the design.

Precisely, yep – thank you for clarifying, @matmarex.

@ppelberg There are multiple differences between the “Actual” and “Desired” screenshots; in particular, both the font weight of the “Learn more about this page” link and its relative position to the Add topic button differ. Could you please elaborate on what exactly needs to be changed?

@Tacsipacsi: the differences you named above are accurate. Next time, I'll take care to ensure it is unambiguous what I'm proposing we change.

Thank you for commenting and I continue to appreciate the close attention you pay to the work we're doing and helpful input you offer ^ _ ^

Change 865745 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Deemphasize "Learn more about this page" link

https://gerrit.wikimedia.org/r/865745

Change 866467 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@wmf/1.40.0-wmf.13] Deemphasize "Learn more about this page" link

https://gerrit.wikimedia.org/r/866467

Change 866467 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.40.0-wmf.13] Deemphasize "Learn more about this page" link

https://gerrit.wikimedia.org/r/866467

Mentioned in SAL (#wikimedia-operations) [2022-12-08T22:06:25Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:866467|Deemphasize "Learn more about this page" link (T324702)]], [[gerrit:866468|Reinitialize edit links after page content is reloaded (T324686)]]

Mentioned in SAL (#wikimedia-operations) [2022-12-08T22:08:10Z] <samtar@deploy1002> samtar and matmarex: Backport for [[gerrit:866467|Deemphasize "Learn more about this page" link (T324702)]], [[gerrit:866468|Reinitialize edit links after page content is reloaded (T324686)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2022-12-08T22:16:31Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:866467|Deemphasize "Learn more about this page" link (T324702)]], [[gerrit:866468|Reinitialize edit links after page content is reloaded (T324686)]] (duration: 10m 06s)

ppelberg added a project: Editing QA.
ppelberg updated the task description. (Show Details)
EAkinloose subscribed.

✅ Deemphasize treatment of "Learn more about this page" Link

IMG_4930A91F41E0-1.jpeg (2×1 px, 627 KB)