[go: up one dir, main page]

Page MenuHomePhabricator

Use standard thumbsizes in modern vector search
Closed, ResolvedPublic

Description

Note: This is not about changing the design, the thumbsize for users is 40px and that's not going to change. It's about the size of the thumbnail being fetched from the servers.

Currently modern vector search loads thumbnails at 100px (or 200px @ 2dppx). This is not standard size and causes extra thumbnailing and fragmentation of thumbs which is hurting media storage (swift currently has issues with file count in each container, the size is not that much of an issue). I explained it in depth with numbers in T211661#8377883

You should use 120px for 1x and 220px for 2x.

I think this should block rolling DIP to more wikis as default.

This improves performance of loading thumbnails, reduce latency and so on.

Event Timeline

Vector blindly prints whatever images the API returns in https://en.wikipedia.org/w/rest.php/v1/search/title?q=S&limit=10
See also T306838 which is more or less the same problem but from a different perspective. Perhaps these 2 should be merged?

Change 857013 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] search: Use 60px for search thumbnails

https://gerrit.wikimedia.org/r/857013

Change 857013 merged by jenkins-bot:

[mediawiki/core@master] search: Use 60px for search thumbnails

https://gerrit.wikimedia.org/r/857013

ovasileva triaged this task as Medium priority.Nov 29 2022, 11:23 PM

Change 867004 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] search: Avoid setting height in search thumbnails

https://gerrit.wikimedia.org/r/867004

Change 867004 merged by jenkins-bot:

[mediawiki/core@master] search: Avoid setting height in search thumbnails

https://gerrit.wikimedia.org/r/867004

Change 868046 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@wmf/1.40.0-wmf.14] search: Avoid setting height in search thumbnails

https://gerrit.wikimedia.org/r/868046

Change 868046 merged by jenkins-bot:

[mediawiki/core@wmf/1.40.0-wmf.14] search: Avoid setting height in search thumbnails

https://gerrit.wikimedia.org/r/868046

Mentioned in SAL (#wikimedia-operations) [2022-12-14T09:46:45Z] <ladsgroup@deploy1002> Synchronized php-1.40.0-wmf.14/includes/search/SearchResultThumbnailProvider.php: Backport: [[gerrit:868046|search: Avoid setting height in search thumbnails (T322621)]] (duration: 08m 07s)

Ladsgroup claimed this task.

This is done :)