When storing new permalinks data after an edit is made, DiscussionTools would currently first store the data for the new revision by inserting new rows into discussiontools_item_revisions, then update some references to point to them, then finally delete the old now-unreferenced rows. @Ladsgroup says (on T315353) that this might cause us to run out of the primary key auto-increment values (one used for each new row) in the foreseeable future. We should change this code to update existing rows whenever possible, rather than insert+delete.
Description
Description
Details
Details
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T314973 Improve Topic Subscription support for discussions that are merged, moved, or deleted | |||
| Open | None | T315050 Enable people to visit the page the discussion they were subscribed to has been moved to | |||
| Open | None | T318449 [Tracking] Improve the sharing of MediaWiki content | |||
| Open | None | T318446 [Tracking] Improve sharing link functionality of pages | |||
| Open | None | T315507 Introduce support for topic and comment permanent links within the Android and iOS apps | |||
| Open | None | T349353 Expose comment/topic permanent links on Special:Contributions | |||
| Open | None | T265269 Assist with linking to other comments within the Reply Tool | |||
| Resolved | ppelberg | T302011 [Release Ticket] Introduce permalinks on wikitext talk pages | |||
| Resolved | DLynch | T365974 Deploy talk page permalinks to en.wiki | |||
| Resolved | matmarex | T315353 Create database tables for permalinks in production wikis, and enable the feature | |||
| Resolved | matmarex | T321121 When storing new permalinks data, update existing rows if possible rather than insert+delete |
Event Timeline
Comment Actions
Change 844573 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] [WIP] ThreadItemStore: Update existing rows if possible rather than insert+delete
Comment Actions
Change 844573 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] ThreadItemStore: Update existing rows if possible rather than insert+delete
Comment Actions
Change 854068 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@wmf/1.40.0-wmf.8] ThreadItemStore: Update existing rows if possible rather than insert+delete
Comment Actions
Change 854068 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@wmf/1.40.0-wmf.8] ThreadItemStore: Update existing rows if possible rather than insert+delete
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2022-11-07T21:09:06Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:854068|ThreadItemStore: Update existing rows if possible rather than insert+delete (T321121)]]
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2022-11-07T21:09:26Z] <urbanecm@deploy1002> urbanecm and matmarex: Backport for [[gerrit:854068|ThreadItemStore: Update existing rows if possible rather than insert+delete (T321121)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2022-11-07T21:16:37Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:854068|ThreadItemStore: Update existing rows if possible rather than insert+delete (T321121)]] (duration: 07m 30s)