Maniphest T320755

"Start a discussion" and "Read as wiki page" buttons have incorrect margins
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ppelberg
	Oct 13 2022, 6:41 PM

Description

On talk pages that A) have not been created yet and B) have access to the empty state experience implemented as part of T270323, the Start a discussion and Read as wiki page buttons seem to conflict, or at least, not compliment one another.

This task involves with revising how these two buttons appear in the time between now and when we are planning to converge on a single talk page view (T280417) which would, in effect, remove the Read as wiki page view and button all together.

Behavior

❗️Actual	😊 Desired

Notice how the two buttons look as if they're "smooshed" together?	The Start a discussion and Read as wiki page buttons appear to be less "on top" of one another/conjoined so that people can clearly differentiate between the two and not be lead to question which of the two buttons they ought to tap when trying to start a new discussion

Done

"Desired" behavior is defined
"Desired" behavior is implemented

Details

	Subject	Repo	Branch	Lines +/-
	Tweak mobile "Read as wiki page" button placement	mediawiki/extensions/DiscussionTools	master	+7 -0

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		matmarex	T319145 Remove MobileFrontend/Minerva code for talk page tools
Resolved		Jdlrobson	T312312 Deprecate MobileFrontend's "About this page" functionality on talk pages
Resolved		None	T278588 Mobile talk page improvements
Resolved	BUG REPORT	matmarex	T326080 User talk page seems to be empty in mobile
Resolved		matmarex	T327047 English Wikipedia WikiProject banners no longer visible on mobile
Resolved		None	T298060 [RELEASE TICKET] Offer Mobile DiscussionTools at All Wikis
Resolved		ppelberg	T298062 [A/B Test] Run an A/B test to evaluate impact of mobile DiscussionTools
Resolved		matmarex	T320755 "Start a discussion" and "Read as wiki page" buttons have incorrect margins

Event Timeline

ppelberg created this task.Oct 13 2022, 6:41 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 13 2022, 6:41 PM

ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Oct 13 2022, 6:41 PM

ppelberg moved this task from Untriaged to Upcoming on the Editing-team board.

nayoub updated the task description. (Show Details)Oct 13 2022, 9:55 PM

ppelberg edited projects, added Editing-team (Kanban Board); removed Editing-team.Oct 14 2022, 12:50 AM

ppelberg moved this task from Incoming to Ready to Be Worked On on the Editing-team (Kanban Board) board.

ppelberg added a parent task: T298062: [A/B Test] Run an A/B test to evaluate impact of mobile DiscussionTools.Oct 14 2022, 6:57 PM

ppelberg added a project: Goal.Oct 17 2022, 6:10 PM

Change 851134 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Tweak mobile "Read as wiki page" button placement

https://gerrit.wikimedia.org/r/851134

gerritbot added a project: Patch-For-Review.Oct 31 2022, 9:31 PM

matmarex claimed this task.Oct 31 2022, 9:31 PM

matmarex moved this task from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.

Esanders renamed this task from "Start a discussion" and "Read as wiki page" buttons seem in tension with one another to "Start a discussion" and "Read as wiki page" buttons have incorrect margins.Nov 2 2022, 9:05 AM

Change 851134 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Tweak mobile "Read as wiki page" button placement

https://gerrit.wikimedia.org/r/851134

Maintenance_bot removed a project: Patch-For-Review.Nov 2 2022, 9:30 AM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.10; 2022-11-14).Nov 2 2022, 10:00 AM

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Nov 2 2022, 4:41 PM

matmarex added a project: Editing QA.

Ryasmeen edited projects, added Verified; removed Editing QA.Nov 3 2022, 8:41 PM

Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.

ppelberg closed this task as Resolved.Nov 4 2022, 5:05 PM

	F35566817: Screen Shot 2022-10-12 at 3.23.11 PM.png
	Oct 13 2022, 6:41 PM

"Start a discussion" and "Read as wiki page" buttons have incorrect marginsClosed, ResolvedPublicActions