[go: up one dir, main page]

Page MenuHomePhabricator

Language variant conversion broken for page/html endpoints on RESTBase
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • curl https://sr.wikipedia.beta.wmflabs.org/api/rest_v1/page/html/RESTBase_Testing_Page -H 'Accept-Language: sr-el'

What happens?:
We get an Internal Server Error (Status 500).

What should have happened instead?:
We get the page converted to the latin variant, with content-.language sr-el.

Software version (skip for WMF-hosted wikis like Wikipedia):
1.40.0-wmf.4

Other information (browser name/version, screenshots, etc.):

Event Timeline

Change 838094 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@wmf/1.40.0-wmf.4] Revert "Introduce LanguageVariantConverter"

https://gerrit.wikimedia.org/r/838094

Change 838093 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] Revert "Introduce LanguageVariantConverter"

https://gerrit.wikimedia.org/r/838093

daniel updated the task description. (Show Details)

Change 838093 merged by jenkins-bot:

[mediawiki/core@master] Revert "Introduce LanguageVariantConverter"

https://gerrit.wikimedia.org/r/838093

Change 838094 merged by jenkins-bot:

[mediawiki/core@wmf/1.40.0-wmf.4] Revert "Introduce LanguageVariantConverter"

https://gerrit.wikimedia.org/r/838094

Mentioned in SAL (#wikimedia-operations) [2022-10-04T14:08:03Z] <lucaswerkmeister-wmde@deploy1002> Synchronized php-1.40.0-wmf.4/includes/: Backport: [[gerrit:838094|Revert "Introduce LanguageVariantConverter" (T319282)]] (1/2; no wikis use wmf.4 yet, but the code exists, so the change needs to be synced) (duration: 03m 43s)

Mentioned in SAL (#wikimedia-operations) [2022-10-04T14:12:22Z] <lucaswerkmeister-wmde@deploy1002> Synchronized php-1.40.0-wmf.4/tests/phpunit/: Backport: [[gerrit:838094|Revert "Introduce LanguageVariantConverter" (T319282)]] (2/2; no wikis use wmf.4 yet, but the code exists, so the change needs to be synced) (duration: 03m 52s)

daniel claimed this task.