Wikimedia\Rdbms\DBQueryError: Error 1062: Duplicate entry (…) for key 'it_itemname'
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	TheresNoTime
	Sep 7 2022, 8:23 PM

Description

Error

mwversion: 1.39.0-wmf.27
reqId: fdbb3f11-064a-4f2b-bc09-c0016555c7bf
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   Wikimedia\Rdbms\DBQueryError: Error 1062: Duplicate entry 'h-Sujalajus-2017-04-28T09:31:00.000Z' for key 'it_itemname'
Function: MediaWiki\Extension\DiscussionTools\ThreadItemStore::insertThreadItems
Query: INSERT INTO `discuss

exception.trace

from /srv/mediawiki/php-1.39.0-wmf.27/includes/libs/rdbms/database/Database.php(1724)
#0 /srv/mediawiki/php-1.39.0-wmf.27/includes/libs/rdbms/database/Database.php(1708): Wikimedia\Rdbms\Database->getQueryException(string, integer, string, string)
#1 /srv/mediawiki/php-1.39.0-wmf.27/includes/libs/rdbms/database/Database.php(1682): Wikimedia\Rdbms\Database->getQueryExceptionAndLog(string, integer, string, string)
#2 /srv/mediawiki/php-1.39.0-wmf.27/includes/libs/rdbms/database/Database.php(1058): Wikimedia\Rdbms\Database->reportQueryError(string, integer, string, string, boolean)
#3 /srv/mediawiki/php-1.39.0-wmf.27/includes/libs/rdbms/database/Database.php(1941): Wikimedia\Rdbms\Database->query(string, string, integer)
#4 /srv/mediawiki/php-1.39.0-wmf.27/extensions/DiscussionTools/includes/ThreadItemStore.php(405): Wikimedia\Rdbms\Database->insert(string, array, string)
#5 /srv/mediawiki/php-1.39.0-wmf.27/includes/libs/rdbms/database/Database.php(2856): MediaWiki\Extension\DiscussionTools\ThreadItemStore->MediaWiki\Extension\DiscussionTools\{closure}(Wikimedia\Rdbms\DatabaseMysqli, string)
#6 /srv/mediawiki/php-1.39.0-wmf.27/includes/libs/rdbms/database/DBConnRef.php(103): Wikimedia\Rdbms\Database->doAtomicSection(string, Closure, string)
#7 /srv/mediawiki/php-1.39.0-wmf.27/includes/libs/rdbms/database/DBConnRef.php(664): Wikimedia\Rdbms\DBConnRef->__call(string, array)
#8 /srv/mediawiki/php-1.39.0-wmf.27/extensions/DiscussionTools/includes/ThreadItemStore.php(552): Wikimedia\Rdbms\DBConnRef->doAtomicSection(string, Closure, string)
#9 /srv/mediawiki/php-1.39.0-wmf.27/extensions/DiscussionTools/includes/Hooks/DataUpdatesHooks.php(51): MediaWiki\Extension\DiscussionTools\ThreadItemStore->insertThreadItems(MediaWiki\Revision\RevisionStoreRecord, MediaWiki\Extension\DiscussionTools\ContentThreadItemSet)
#10 /srv/mediawiki/php-1.39.0-wmf.27/includes/deferred/MWCallableUpdate.php(38): MediaWiki\Extension\DiscussionTools\Hooks\DataUpdatesHooks->MediaWiki\Extension\DiscussionTools\Hooks\{closure}()
#11 /srv/mediawiki/php-1.39.0-wmf.27/includes/deferred/DeferredUpdates.php(474): MWCallableUpdate->doUpdate()
#12 /srv/mediawiki/php-1.39.0-wmf.27/includes/deferred/RefreshSecondaryDataUpdate.php(103): DeferredUpdates::attemptUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti)
#13 /srv/mediawiki/php-1.39.0-wmf.27/includes/deferred/DeferredUpdates.php(474): RefreshSecondaryDataUpdate->doUpdate()
#14 /srv/mediawiki/php-1.39.0-wmf.27/includes/Storage/DerivedPageDataUpdater.php(1801): DeferredUpdates::attemptUpdate(RefreshSecondaryDataUpdate, Wikimedia\Rdbms\LBFactoryMulti)
#15 /srv/mediawiki/php-1.39.0-wmf.27/includes/page/WikiPage.php(2136): MediaWiki\Storage\DerivedPageDataUpdater->doSecondaryDataUpdates(array)
#16 /srv/mediawiki/php-1.39.0-wmf.27/includes/jobqueue/jobs/RefreshLinksJob.php(245): WikiPage->doSecondaryDataUpdates(array)
#17 /srv/mediawiki/php-1.39.0-wmf.27/includes/jobqueue/jobs/RefreshLinksJob.php(154): RefreshLinksJob->runForTitle(Title)
#18 /srv/mediawiki/php-1.39.0-wmf.27/extensions/EventBus/includes/JobExecutor.php(79): RefreshLinksJob->run()
#19 /srv/mediawiki/rpc/RunSingleJob.php(77): MediaWiki\Extension\EventBus\JobExecutor->execute(array)
#20 {main}

Impact

Notes

Details

Request URL: https://jobrunner.discovery.wmnet/rpc/RunSingleJob.php

	Subject	Repo	Branch	Lines +/-
	ThreadItemStore: Move some work in insertThreadItems() outside transactions	mediawiki/extensions/DiscussionTools	master	+137 -105

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T314973 Improve Topic Subscription support for discussions that are merged, moved, or deleted
Open		None	T315050 Enable people to visit the page the discussion they were subscribed to has been moved to
Open		None	T318449 [Tracking] Improve the sharing of MediaWiki content
Open		None	T318446 [Tracking] Improve sharing link functionality of pages
Open		None	T315507 Introduce support for topic and comment permanent links within the Android and iOS apps
Open		None	T349353 Expose comment/topic permanent links on Special:Contributions
Open		None	T265269 Assist with linking to other comments within the Reply Tool
Resolved		ppelberg	T302011 [Release Ticket] Introduce permalinks on wikitext talk pages
Resolved		DLynch	T365974 Deploy talk page permalinks to en.wiki
Resolved		matmarex	T315353 Create database tables for permalinks in production wikis, and enable the feature
Resolved	PRODUCTION ERROR	matmarex	T317236 Wikimedia\Rdbms\DBQueryError: Error 1062: Duplicate entry (…) for key 'it_itemname'

Event Timeline

TheresNoTime created this task.Sep 7 2022, 8:23 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 7 2022, 8:23 PM

This was caused by the deployment for T315353: Create database tables for permalinks in production wikis, and enable the feature, the errors stopped after it was reverted. I will investigate.

JJMC89 added a parent task: T315353: Create database tables for permalinks in production wikis, and enable the feature.Sep 7 2022, 8:50 PM

matmarex renamed this task from Wikimedia\Rdbms\DBQueryError: Error 1062: Duplicate entry 'h-Sujalajus-2017-04-28T09:31:00.000Z' for key 'it_itemname'Function: MediaWiki\Extension\DiscussionTools\ThreadItemStore::insertThreadItemsQuery: INSERT INTO `discuss to Wikimedia\Rdbms\DBQueryError: Error 1062: Duplicate entry (…) for key 'it_itemname'.Sep 8 2022, 5:34 PM

matmarex moved this task from Backlog to Triaged on the DiscussionTools board.

Change 836875 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] ThreadItemStore: Move some work in insertThreadItems() outside transactions

https://gerrit.wikimedia.org/r/836875

gerritbot added a project: Patch-For-Review.Sep 29 2022, 4:42 PM

matmarex added a project: Editing-team (Kanban Board).Sep 29 2022, 4:45 PM

matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.

Change 836875 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] ThreadItemStore: Move some work in insertThreadItems() outside transactions

https://gerrit.wikimedia.org/r/836875

Maintenance_bot removed a project: Patch-For-Review.Oct 14 2022, 5:30 PM

matmarex moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.Oct 17 2022, 7:26 PM

matmarex added a project: Skipped QA.

ppelberg closed this task as Resolved.Oct 18 2022, 12:30 AM

TheresNoTime mentioned this in T317238: Wikimedia\Rdbms\DBTransactionError: Transaction round stage must be 'cursory' (not 'within-rollback').Oct 20 2022, 4:02 PM

Krinkle moved this task from Untriaged to Oct 2022 on the Wikimedia-production-error board.Nov 17 2022, 4:18 PM

Wikimedia\Rdbms\DBQueryError: Error 1062: Duplicate entry (…) for key 'it_itemname'Closed, ResolvedPublicPRODUCTION ERRORActions