[go: up one dir, main page]

Page MenuHomePhabricator

DiscussionTools permalink overlay is not visible on archived talk pages with custom background color
Open, Needs TriagePublicBUG REPORT

Description

A normal DiscussionTools permalink on huwiki, resulting in a blue overlay around the linked comment:

Permalink to an archived village pump page which uses the {{archív lap}} (archived page) template:

The overlay div is present but has no visual effect.

This is due to mix-blend-mode: darken not doing anything when the background is darker than the overlay color. A blend mode of color or multiply would make more sense.

Event Timeline

color wouldn't work as well because of the effect it has on images, and colorful signatures, or even links.

multiply would work well, but then we'd have to avoid overlapping the highlights when we highlight multiple comments. The higlights are taller than the line height, and overlap slightly when subsequent comments are highlighted. We actually used multiply until we introduced that feature: rEDTOdb28a3d3a75e: Handle highlighting and scrolling to comments for bundled notifications. This is certainly doable but might be tricky.