PHP Notice: Undefined index: etag
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Krinkle
	Aug 25 2022, 3:48 PM

Description

Error

mwversion: 1.39.0-wmf.26
reqId: 86666b8a-81cd-4667-8409-26178d2b87e1
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   PHP Notice: Undefined index: etag

exception.trace

from /srv/mediawiki/php-1.39.0-wmf.26/extensions/DiscussionTools/includes/ApiDiscussionToolsEdit.php(286)
#0 /srv/mediawiki/php-1.39.0-wmf.26/extensions/DiscussionTools/includes/ApiDiscussionToolsEdit.php(286): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.39.0-wmf.26/includes/api/ApiMain.php(1900): MediaWiki\Extension\DiscussionTools\ApiDiscussionToolsEdit->execute()
#2 /srv/mediawiki/php-1.39.0-wmf.26/includes/api/ApiMain.php(875): ApiMain->executeAction()
#3 /srv/mediawiki/php-1.39.0-wmf.26/includes/api/ApiMain.php(846): ApiMain->executeActionWithErrorHandling()
#4 /srv/mediawiki/php-1.39.0-wmf.26/api.php(90): ApiMain->execute()
#5 /srv/mediawiki/php-1.39.0-wmf.26/api.php(45): wfApiMain()
#6 /srv/mediawiki/w/api.php(3): require(string)
#7 {main}

Impact

Notes

7 instances in the last 24h, all from private wikis:

vrt-wiki.wikimedia.org
steward.wikimedia.org
arbcom-en.wikipedia.org

Details

Request URL: https://steward.wikimedia.org/w/api.php

	Subject	Repo	Branch	Lines +/-
	ParsoidHelper: Stop logging missing etags	mediawiki/extensions/VisualEditor	master	+4 -2
	ApiDiscussionToolsEdit: etag is optional	mediawiki/extensions/DiscussionTools	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: T316969: MediaWiki\Extension\VisualEditor\ParsoidHelper::transformHTML: Received funny ETag from client
rMW7d5815b57435: ParsoidHandler: do not emit etag for wt2html

Event Timeline

Krinkle created this task.Aug 25 2022, 3:48 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 25 2022, 3:48 PM

Probably caused by rMW7d5815b57435: ParsoidHandler: do not emit etag for wt2html. We shouldn't expect the etag to be set.

Each of these also causes logging from VisualEditor: MediaWiki\Extension\VisualEditor\ParsoidHelper::transformHTML: Received funny ETag from client: ''. That also shouldn't happen.

Change 826643 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] ApiDiscussionToolsEdit: etag is optional

https://gerrit.wikimedia.org/r/826643

gerritbot added a project: Patch-For-Review.Aug 25 2022, 7:18 PM

Change 826644 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] ParsoidHelper: Stop logging missing etags

https://gerrit.wikimedia.org/r/826644

matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.Aug 25 2022, 7:24 PM

Change 826643 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] ApiDiscussionToolsEdit: etag is optional

https://gerrit.wikimedia.org/r/826643

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.27; 2022-08-29).Aug 25 2022, 8:00 PM

Krinkle moved this task from Untriaged to Aug 2022 on the Wikimedia-production-error board.Aug 26 2022, 12:20 PM

Change 826644 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] ParsoidHelper: Stop logging missing etags

https://gerrit.wikimedia.org/r/826644

(Check logs after deployment)

Maintenance_bot removed a project: Patch-For-Review.Aug 26 2022, 7:30 PM

Looks clear:

"Undefined index: etag": https://logstash.wikimedia.org/goto/fa49f94e565cf04825f696304d232fe5

…Unfortunately the other change had the opposite effect than intended. Now filed as T316969.

VPuffetMichel moved this task from Backlog to Triaged on the DiscussionTools board.Sep 8 2022, 3:09 PM

ppelberg closed this task as Resolved.Sep 22 2022, 4:51 PM

	F35507989: image.png
	Sep 3 2022, 3:09 AM

PHP Notice: Undefined index: etagClosed, ResolvedPublicPRODUCTION ERRORActions