[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T316969

MediaWiki\Extension\VisualEditor\ParsoidHelper::transformHTML: Received funny ETag from client
Closed, ResolvedPublic
Actions

Description

We're logging a lot of MediaWiki\Extension\VisualEditor\ParsoidHelper::transformHTML: Received funny ETag from client: https://logstash.wikimedia.org/goto/8ab916541d77393b7f2b438b9801e165

image.png (527×2 px, 48 KB)

This is caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/826644, which was supposed to decrease the amount of logging for this. Oops.

Details

SubjectRepoBranchLines +/-
Restore the $oldid condition for funny ETag loggingmediawiki/extensions/VisualEditormaster+2 -1
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Sep 3 2022, 2:57 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 3 2022, 2:57 AM
matmarex claimed this task.Sep 3 2022, 2:57 AM
matmarex added a project: Editing-team (Kanban Board).
matmarex moved this task from To Triage to Triaged on the VisualEditor board.
matmarex updated the task description. (Show Details)
gerritbot added a comment.Sep 3 2022, 3:07 AM

Change 829257 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Restore the $oldid condition for funny ETag logging

https://gerrit.wikimedia.org/r/829257

gerritbot added a project: Patch-For-Review.Sep 3 2022, 3:07 AM
matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.Sep 3 2022, 3:07 AM
matmarex mentioned this in T316234: PHP Notice: Undefined index: etag.Sep 3 2022, 3:09 AM
gerritbot added a comment.Sep 3 2022, 3:26 AM

Change 829257 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Restore the $oldid condition for funny ETag logging

https://gerrit.wikimedia.org/r/829257

Maintenance_bot removed a project: Patch-For-Review.Sep 3 2022, 3:30 AM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.28; 2022-09-05).Sep 3 2022, 4:00 AM
matmarex moved this task from Code Review to Blocked / Needs More Work on the Editing-team (Kanban Board) board.Sep 6 2022, 7:24 PM
DLynch moved this task from Blocked / Needs More Work to Ready for Sign Off on the Editing-team (Kanban Board) board.Sep 21 2022, 5:00 PM
DLynch subscribed.

Errors seem to be back to a reasonable level:

image.png (522×2 px, 356 KB)

ppelberg closed this task as Resolved.Sep 22 2022, 4:35 PM
Krinkle moved this task from Untriaged to Sep 2022 on the Wikimedia-production-error board.Nov 17 2022, 4:22 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits