| Jdlrobson | |
| Sep 2 2022, 10:39 PM |
| F35521538: Screen Recording 2022-09-15 at 9.34.54 AM.mov.gif | |
| Sep 15 2022, 4:35 PM |
| F35521535: Screen Recording 2022-09-15 at 9.29.02 AM.mov.gif | |
| Sep 15 2022, 4:33 PM |
| F35507842: collapsejiggle.gif | |
| Sep 2 2022, 10:39 PM |
Go to https://en.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein
Close the sidebar, and wait for the preference to save
Hard reload the page.
What happens:
Expected:
The table of contents should not change position.
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T316964#8239990 |
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T316964#8239997 |
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add vector-toc-not-collapsed class serverside | mediawiki/skins/Vector | master | +4 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Jdlrobson | T309972 [Goal] prepare desktop improvements project for further deployment | |||
| Resolved | ovasileva | T301780 [Epic] Visual design & layout refinements | |||
| Resolved | ovasileva | T273473 [Epic] Improve the table of contents | |||
| Resolved | ovasileva | T316964 [Regression, Visual refinements] When main menu is collapsed table of contents jumps on page load |
@bwang the issue seems to be the rule .vector-toc-not-collapsed #mw-sidebar-checkbox:not(:checked) ~ .mw-table-of-contents-container .vector-sticky-toc-container ...
@alexhollender_WMF - assuming this is a blocker for deployment. Thoughts from your side?
Change 830942 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):
[mediawiki/skins/Vector@master] Add vector-toc-not-collapsed class serverside
Change 830942 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Add vector-toc-not-collapsed class serverside
Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Artifact(s):
Go to https://en.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein
Close the sidebar, and wait for the preference to save
Hard reload the page.
✅ AC1: The table of contents should not change position.
Status: ✅ PASS
Environment: cawiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Artifact(s):
Go to https://ca.wikipedia.org/wiki/Alcarr%C3%A0s_(pel%C2%B7l%C3%ADcula)
Close the sidebar, and wait for the preference to save
Hard reload the page.
✅ AC1: The table of contents should not change position.