[go: up one dir, main page]

Page MenuHomePhabricator

Click on a most recent edit value submits all filters
Closed, ResolvedPublicBUG REPORT

Description

Codex buttons are type="submit" by default and there is no easy way to pass type=button as mentioned in T312987. This causes the most recent edit button options to submit the form.

Steps to replicate the issue (include links if applicable):

  • Log in as a mentor
  • Navigate to the Mentor dashboard
  • Open the filters dropdown
  • Select any option from the "Most recent edit" button groups

What happens?:
All the filters are submit immediately

What should have happened instead?:
The value should be kept for later submission but the filters should not be submitted until the user clicks on the "Update" button

Software version (skip for WMF-hosted wikis like Wikipedia):
wmf-25 and later. The bug was introduced in gerrit 819647
Other information (browser name/version, screenshots, etc.):

submit.gif (1×1 px, 291 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 829168 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Mentee overview(vue): prevent clicks on more recent edit buttons to submit the filters

https://gerrit.wikimedia.org/r/829168

Sgs changed the task status from Open to In Progress.Sep 2 2022, 11:31 AM
Sgs claimed this task.
Sgs updated the task description. (Show Details)
Sgs moved this task from Inbox to Upcoming Work on the Growth-Team board.
Sgs moved this task from Upcoming Work to Sprint 0 (Growth Team) on the Growth-Team board.
Sgs edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
Sgs moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.
Urbanecm_WMF moved this task from New Tasks to In Progress on the GrowthExperiments-Mentorship board.

Change 829168 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Mentee overview(vue): prevent clicks on more recent edit buttons to submit the filters

https://gerrit.wikimedia.org/r/829168

Change 830199 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.27] Mentee overview(vue): prevent clicks on more recent edit buttons to submit the filters

https://gerrit.wikimedia.org/r/830199

Etonkovidova subscribed.

Checked in testwiki wmf.28 - the result set is not changed unless Update is clicked.

Change 830199 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.27] Mentee overview(vue): prevent clicks on more recent edit buttons to submit the filters

https://gerrit.wikimedia.org/r/830199

Mentioned in SAL (#wikimedia-operations) [2022-09-07T13:38:49Z] <samtar@deploy1002> Synchronized php-1.39.0-wmf.27/extensions/GrowthExperiments/modules/ext.growthExperiments.MentorDashboard.Vue/components/MenteeOverview/MenteeFiltersForm.vue: Backport: [[gerrit:830199|Mentee overview(vue): prevent clicks on more recent edit buttons to submit the filters (T316926)]] (duration: 04m 07s)