Upload new Maki icons to Wikimedia Commons
Closed, ResolvedPublic0 Estimated Story Points
Actions

Assigned To

None

Authored By

	lilients_WMDE
	Aug 15 2022, 12:54 PM

Description

For the docu page we want to add the new versions of the maki icons to wiki commons. The files can be prefixed with "Maki7-", so "Maki7-american-football.svg"

This should be a batch upload: https://commons.wikimedia.org/wiki/Commons:Guide_to_batch_uploading

We will not overwrite the old ones because the licence changed.

Open question for the future: Replace old icons with redirects to the new icons?

Related Objects
Search...

Status	Assigned	Task
Duplicate	None	T153369 Static maps service crashes on broken images (used in icons)
Resolved	awight	T141304 Only a part of MAKI symbols is available (previously map icon "castle" broken)
Stalled	None	T141335 Add maps support for marks with 3 digits
Resolved	awight	T145475 Update to latest maki
Resolved	None	T302861 Actually update the Maki icons
Resolved	None	T312752 Update mw:Help:Extension:Kartographer/Icons with maki 7.0.0
Resolved	None	T315228 Upload new Maki icons to Wikimedia Commons

Event Timeline

lilients_WMDE created this task.Aug 15 2022, 12:54 PM

lilients_WMDE mentioned this in T312752: Update mw:Help:Extension:Kartographer/Icons with maki 7.0.0.

lilients_WMDE removed lilients_WMDE as the assignee of this task.Aug 15 2022, 1:03 PM

Lena_WMDE moved this task from Backlog to In sprint on the WMDE-GeoInfo-FocusArea board.Aug 16 2022, 9:24 AM

thiemowmde added a project: WMDE-TechWish-Sprint-2022-08-17.Aug 17 2022, 8:15 AM

thiemowmde set the point value for this task to 0.Aug 17 2022, 8:23 AM

awight updated the task description. (Show Details)Aug 17 2022, 9:52 AM

awight assigned this task to • Timur_Vorkul_WMDE.Aug 18 2022, 7:12 AM

awight moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2022-08-17 board.

Done! Here's an example file: https://commons.wikimedia.org/wiki/File:Maki7-bowling-alley.svg

WMDE-Fisch moved this task from Demo to Done on the WMDE-TechWish-Sprint-2022-08-17 board.Aug 30 2022, 8:34 AM

As it turns out:

Maki version 7.0 and 7.1 are effectively the same for everything we care about: https://github.com/mapbox/maki/compare/v7.0.0...ed764be5
The files we uploaded to Commons are from Maki version 7.0/7.1.
What we ended using in the code is from 7.2. Here is an example that proves this: https://maps-beta.wmflabs.org/v4/marker/pin-m-tunnel+000@2x.png
Maki 7.2 added 7 new icons and edited 72 existing ones. Most of the edits are barely even visible: Some icons are better centered now. Some are a little smaller. Only very, very few are actually redone. Notably optician and school. All in all we can consider this a "bugfix" release, I would argue.

Here are the code changes between 7.0 and 7.2: https://github.com/mapbox/maki/compare/v7.0.0...v7.2.0. From this I extracted a list of 79 file names we need to (re)upload:

amusement-park
animal-shelter
aquarium
art-gallery
barrier
baseball
basketball
blood-bank
bowling-alley
bridge
bus
campsite
car-rental
car-repair
caution
charging-station
circle-stroked
city
clothing-store
commercial
construction
cross
defibrillator
entrance
farm
fence
ferry-JP
fire-station
fuel
furniture
gaming
gate
gift
heart
historic
hospital-JP
hot-spring
landmark-JP
landuse
lift-gate
marker-stroked
marker
mountain
music
optician
paint
parking-paid
parking
playground
post-JP
post
racetrack-boat
religious-jewish
religious-muslim
residential-community
restaurant-pizza
roadblock
rocket
school
shelter
shop
skateboard
slaughterhouse
slipway
snowmobile
square-stroked
square
star-stroked
suitcase
teahouse
toilet
toll-booth
town
triangle-stroked
triangle
tunnel
village
water
waterfall

From these 79 the following 7 are new in 7.2:

animal-shelter
gate
historic
lift-gate
parking-paid
toll-booth
tunnel

@awight, can you (re)do these (re)uploads with the VicuñaUploader?

thiemowmde renamed this task from Upload new maki icons to wiki commons to Upload new Maki icons to Wikimedia Commons.Aug 30 2022, 1:34 PM

@thiemowmde Just to be sure: So we'll actually be updating the icons in Kartographer to Maki 7.2? I'm asking because that info will be in announcements and on our project pages.

That's my suggestion, pending review. It shouldn't make much of a difference. As said, 7.2 is more like a bugfix release. An option is to just announce "Maki 7". That's always correct.

In T315228#8199151, @JStrodt_WMDE wrote:

@thiemowmde Just to be sure: So we'll actually be updating the icons in Kartographer to Maki 7.2? I'm asking because that info will be in announcements and on our project pages.

Yes, the Kartographer icons already match 7.2. For example, here's "tunnel" https://maps-beta.wmflabs.org/v4/marker/pin-l-tunnel+f00.png . Sorry for the confusion!

Okay, I've uploaded all changed and new files. File descriptions unfortunately say "Maki version 7.0.0" but this is a minor thing.

awight closed this task as Resolved.Aug 31 2022, 10:45 AM

awight removed awight as the assignee of this task.

awight moved this task from Sprint Backlog to Demo on the WMDE-TechWish-Sprint-2022-08-17 board.

Upload new Maki icons to Wikimedia CommonsClosed, ResolvedPublic0 Estimated Story PointsActions

Description

Related ObjectsSearch...

Event Timeline

Upload new Maki icons to Wikimedia Commons
Closed, ResolvedPublic0 Estimated Story Points
Actions

Related Objects
Search...