[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T313331

Make code in the intersection from math and wikibase testable
Closed, ResolvedPublic
Actions

Description

I am a bit concerned that all the new code does not have tests. I suggest we add some basic tests following the example of how Wikibase does tests internally.

For example, SpecialListProperties is conceptually similar to SpecialMathWikibase. If we

  • transform MathWikibaseConnector into a service
  • transform MathWikibaseConfig into a service
  • Introduce a FactoryClass for SpecialMathWikibase
  • Write a test for SpecialMathWikibase

we have a solid concept to test changes that interact with wikidata.

Details

SubjectRepoBranchLines +/-
Transform MathWikibaseConfig into a servicemediawiki/extensions/Mathmaster+195 -111
Transform MathWikibaseConnector into a servicemediawiki/extensions/Mathmaster+118 -24
Customize query in gerrit

Related Objects
Search...

Event Timeline

Physikerwelt created this task.Jul 19 2022, 4:35 PM
Physikerwelt claimed this task.Jul 20 2022, 3:37 PM

I will give this a try...

gerritbot added a comment.Jul 20 2022, 6:14 PM

Change 815777 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[mediawiki/extensions/Math@master] Transform MathWikibaseConnector into a service

https://gerrit.wikimedia.org/r/815777

gerritbot added a project: Patch-For-Review.Jul 20 2022, 6:14 PM
gerritbot added a comment.Jul 21 2022, 7:24 AM

Change 815777 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Transform MathWikibaseConnector into a service

https://gerrit.wikimedia.org/r/815777

Maintenance_bot removed a project: Patch-For-Review.Jul 21 2022, 7:30 AM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.22; 2022-07-25).Jul 21 2022, 8:00 AM
gerritbot added a comment.Jul 21 2022, 8:03 AM

Change 815902 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[mediawiki/extensions/Math@master] Transform MathWikibaseConfig into a service

https://gerrit.wikimedia.org/r/815902

gerritbot added a project: Patch-For-Review.Jul 21 2022, 8:03 AM
Physikerwelt updated the task description. (Show Details)Jul 21 2022, 8:14 AM
gerritbot added a comment.Jul 21 2022, 2:08 PM

Change 815902 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Transform MathWikibaseConfig into a service

https://gerrit.wikimedia.org/r/815902

Maintenance_bot removed a project: Patch-For-Review.Jul 21 2022, 2:30 PM
Physikerwelt removed Physikerwelt as the assignee of this task.Jul 25 2022, 4:33 PM
Physikerwelt updated the task description. (Show Details)
Physikerwelt updated the task description. (Show Details)
Physikerwelt added a comment.Dec 16 2022, 4:29 PM

@Andreg-p do we still want this, or should we just close it?

Andreg-p added a comment.Dec 23 2022, 5:20 AM

@Physikerwelt we implemented many tests already. I think we just forget to close this task. Can be closed, in my opinion.

Physikerwelt closed this task as Resolved.Dec 23 2022, 9:49 AM
Physikerwelt claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits