[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T312006

Move classes under tag folder to namespace
Closed, ResolvedPublic4 Estimated Story Points
Actions

Description

Move the following classes to namespace:

In addition to moving the classes to namespace:

  • Add dependency injection
  • Remove usage of deprecated methods
  • Use strict types
  • Check for external users of the class / methods

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

abi_ created this task.Jul 4 2022, 11:45 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 4 2022, 11:45 AM
abi_ triaged this task as Medium priority.Jul 4 2022, 11:46 AM
abi_ set the point value for this task to 4.
Pginer-WMF moved this task from Quarter Backlog to Priority: Localization infrastructure on the Language-Team (Language-2022-July-September) board.Jul 4 2022, 12:27 PM
Pginer-WMF moved this task from Backlog to maintenance and operational issues on the MediaWiki-extensions-Translate board.Jul 18 2022, 11:21 AM
Wangombe claimed this task.Jul 19 2022, 7:35 AM
gerritbot added a comment.Jul 19 2022, 2:14 PM

Change 815297 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] MoveTranslatableBundleJob: Move to namespace

https://gerrit.wikimedia.org/r/815297

gerritbot added a project: Patch-For-Review.Jul 19 2022, 2:14 PM
gerritbot added a comment.Jul 19 2022, 3:29 PM

Change 815315 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] DeleteTranslatableBundleJob: Move to namespace

https://gerrit.wikimedia.org/r/815315

abi_ moved this task from Priority: Localization infrastructure to In Progress on the Language-Team (Language-2022-July-September) board.Jul 20 2022, 3:05 AM
abi_ updated the task description. (Show Details)
gerritbot added a comment.Jul 25 2022, 4:11 AM

Change 816354 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] LogFormatter: Move to namespace and add strict types

https://gerrit.wikimedia.org/r/816354

abi_ updated the task description. (Show Details)Jul 25 2022, 4:12 AM
gerritbot added a comment.Jul 26 2022, 11:03 AM

Change 815297 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] MoveTranslatableBundleJob: Move to namespace

https://gerrit.wikimedia.org/r/815297

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.23; 2022-08-01).Jul 26 2022, 12:00 PM
gerritbot added a comment.Jul 27 2022, 6:44 AM

Change 817697 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] TranslatablePageException: Move to namespace

https://gerrit.wikimedia.org/r/817697

Wangombe updated the task description. (Show Details)Jul 27 2022, 6:50 AM
gerritbot added a comment.Jul 27 2022, 6:51 AM

Change 815315 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] DeleteTranslatableBundleJob: Move to namespace

https://gerrit.wikimedia.org/r/815315

gerritbot added a comment.Jul 27 2022, 7:10 AM

Change 817705 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] DeleteTranslatableBundleJob: Use FuzzyBot to perform the deletion

https://gerrit.wikimedia.org/r/817705

gerritbot added a comment.Jul 27 2022, 10:43 AM

Change 817705 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] DeleteTranslatableBundleJob: Use FuzzyBot to perform the deletion

https://gerrit.wikimedia.org/r/817705

gerritbot added a comment.Jul 27 2022, 1:12 PM

Change 817770 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] Move TranslatablePage into PageTranslation namespace

https://gerrit.wikimedia.org/r/817770

Wangombe updated the task description. (Show Details)Jul 27 2022, 1:12 PM
gerritbot added a comment.Aug 2 2022, 7:05 AM

Change 816354 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] TranslatableBundleLogFormatter: Move to namespace and add strict types

https://gerrit.wikimedia.org/r/816354

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.25; 2022-08-15); removed MW-1.39-notes (1.39.0-wmf.23; 2022-08-01).Aug 2 2022, 8:00 AM
gerritbot added a comment.Aug 3 2022, 10:47 AM

Change 820099 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] RenderTranslationPageJob: Move to namespace

https://gerrit.wikimedia.org/r/820099

Wangombe updated the task description. (Show Details)Aug 3 2022, 11:17 AM
gerritbot added a comment.Aug 3 2022, 12:04 PM

Change 820114 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] UpdateTranslationsJob move to namespace

https://gerrit.wikimedia.org/r/820114

Wangombe updated the task description. (Show Details)Aug 3 2022, 12:04 PM
gerritbot added a comment.Aug 4 2022, 5:24 AM

Change 817697 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Delete TPException and use Status object

https://gerrit.wikimedia.org/r/817697

abi_ added a comment.Aug 8 2022, 8:10 AM

For PageTranslationHooks we want to do the following:

  1. Move the class under the PageTranslation namespace and rename the class to Hooks. Remove use of any deprecated methods if possible.
  2. As part of another task(T314759), start implementing hook interfaces and injecting dependencies.
abi_ updated the task description. (Show Details)Aug 16 2022, 10:33 AM
gerritbot added a comment.Aug 16 2022, 11:32 AM

Change 817770 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Move TranslatablePage into PageTranslation namespace

https://gerrit.wikimedia.org/r/817770

gerritbot added a comment.Aug 16 2022, 12:35 PM

Change 823618 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] Hooks: move to namespace

https://gerrit.wikimedia.org/r/823618

Wangombe updated the task description. (Show Details)Aug 16 2022, 1:00 PM
gerritbot added a comment.Aug 16 2022, 2:16 PM

Change 820099 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] RenderTranslationPageJob: Move to namespace

https://gerrit.wikimedia.org/r/820099

gerritbot added a comment.Aug 16 2022, 2:16 PM

Change 820114 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] UpdateTranslatablePageJob: move to namespace

https://gerrit.wikimedia.org/r/820114

gerritbot added a comment.Aug 19 2022, 11:18 AM

Change 824711 had a related patch set uploaded (by Krinkle; author: Urbanecm):

[mediawiki/extensions/Translate@master] TranslatableBundleLogFormatter: Cast reason to string before passing it

https://gerrit.wikimedia.org/r/824711

gerritbot added a comment.Aug 19 2022, 1:34 PM

Change 824711 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] TranslatableBundleLogFormatter: Cast reason to string before passing it

https://gerrit.wikimedia.org/r/824711

gerritbot added a comment.Aug 19 2022, 1:56 PM

Change 824442 had a related patch set uploaded (by Jforrester; author: Urbanecm):

[mediawiki/extensions/Translate@wmf/1.39.0-wmf.25] TranslatableBundleLogFormatter: Cast reason to string before passing it

https://gerrit.wikimedia.org/r/824442

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.26; 2022-08-22); removed MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 19 2022, 2:00 PM
Nikerabbit added a subtask: T315889: Error: Class 'TranslatablePage' not found.Aug 22 2022, 2:39 PM
Nikerabbit updated the task description. (Show Details)
Nikerabbit added a subtask: T315708: Edits to translated pages left unpatrolled.Aug 23 2022, 12:04 PM
abi_ changed the status of subtask T315708: Edits to translated pages left unpatrolled from Open to In Progress.Aug 23 2022, 1:28 PM
abi_ closed subtask T315889: Error: Class 'TranslatablePage' not found as Resolved.Aug 23 2022, 2:12 PM
Nikerabbit added a subtask: T315657: Fatal exception of type "TypeError" from TranslatableBundleLogFormatter.php.Aug 24 2022, 11:57 AM
Nikerabbit added a subtask: T315412: TypeError: Return value of MediaWiki\Extension\Translate\PageTranslation\RenderTranslationPageJob::getUser() must be an instance of User, null returned.
abi_ closed subtask T315657: Fatal exception of type "TypeError" from TranslatableBundleLogFormatter.php as Resolved.Aug 28 2022, 4:04 PM
Umherirrender closed subtask T315412: TypeError: Return value of MediaWiki\Extension\Translate\PageTranslation\RenderTranslationPageJob::getUser() must be an instance of User, null returned as Resolved.Aug 28 2022, 9:08 PM
gerritbot added a comment.Aug 29 2022, 3:44 PM

Change 824442 abandoned by Jforrester:

[mediawiki/extensions/Translate@wmf/1.39.0-wmf.25] TranslatableBundleLogFormatter: Cast reason to string before passing it

Reason:

https://gerrit.wikimedia.org/r/824442

abi_ moved this task from In Progress to In Review on the Language-Team (Language-2022-July-September) board.Aug 31 2022, 5:51 AM
gerritbot added a comment.Sep 1 2022, 10:13 AM

Change 823618 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] PageTranslation/Hooks: move to namespace

https://gerrit.wikimedia.org/r/823618

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.28; 2022-09-05); removed MW-1.39-notes (1.39.0-wmf.26; 2022-08-22).Sep 1 2022, 11:00 AM
Nikerabbit removed a project: Patch-For-Review.Sep 1 2022, 12:54 PM
Nikerabbit updated the task description. (Show Details)
Nikerabbit moved this task from In Review to Check after deployment on the Language-Team (Language-2022-July-September) board.
abi_ closed subtask T315708: Edits to translated pages left unpatrolled as Resolved.Sep 2 2022, 10:37 AM
Nikerabbit closed this task as Resolved.Sep 14 2022, 7:41 AM
Nikerabbit moved this task from Check after deployment to Pending input for QA on the Language-Team (Language-2022-July-September) board.
Nikerabbit moved this task from Pending input for QA to Done on the Language-Team (Language-2022-July-September) board.
Nikerabbit added a subtask: T318484: Translate job execution time seems to have significantly increase.Sep 27 2022, 11:45 AM
Nikerabbit closed subtask T318484: Translate job execution time seems to have significantly increase as Resolved.Sep 29 2022, 12:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits