NOTE: This is a blocker for deploying the sticky header edit icons to production.
List of steps to reproduce (step by step, including full links if applicable):
- Use the default definition of VectorWebABTestEnrollment (disabled skin-vector-toc-experiment):
- Enable the sticky header edit icons
$wgVectorStickyHeader = [
"logged_in" => true,
"logged_out" => false,
];
$wgVectorStickyHeaderEdit = [
"logged_in" => true,
"logged_out" => true,
];- Log in
- Scroll to sticky header
What happens?:
The edit icons do not appear in the sticky header.
What should have happened instead?:
The edit icons should show.
Developer notes
I've written a unit test to capture this problem and attached this to the ticket.
QA steps
NOTE: testing use cases might be easier in a local setup with various config configurations
Test the following use cases to verify seeing or not seeing the edit icons in the sticky header:
- When sticky header is enabled and an A/B test that is neither of the sticky header experiments is enabled (use following config), you should see edit icons in sticky header.
$wgVectorStickyHeader = [ "logged_in" => true, "logged_out" => false, ]; $wgVectorWebABTestEnrollment = [ 'name' => 'skin-vector-toc-experiment', 'enabled' => true, 'buckets' => [ 'unsampled' => [ 'samplingRate' => 0, ], 'control' => [ 'samplingRate' => 0.5, ], 'treatment' => [ 'samplingRate' => 0.5, ] ] ];
- When sticky header is enabled and a sticky header A/B test is disabled, you should see edit icons in sticky header
$wgVectorStickyHeader = [ "logged_in" => true, "logged_out" => false, ]; $wgVectorWebABTestEnrollment = [ "name" => "vector.sticky_header_edit", "enabled" => false, "buckets" => [ "control" => [ "samplingRate" => 0 ], "unsampled" => [ "samplingRate" => 0 ], "stickyHeaderDisabled" => [ "samplingRate" => 0 ], "stickyHeaderTreatment" => [ "samplingRate" => 1 ] ], ];
- When sticky header is enabled and a sticky header A/B test is enabled and user is in the treatment bucket, you should see edit icons in sticky header
$wgVectorStickyHeader = [ "logged_in" => true, "logged_out" => false, ]; $wgVectorWebABTestEnrollment = [ "name" => "vector.sticky_header_edit", "enabled" => true, "buckets" => [ "control" => [ "samplingRate" => 0 ], "unsampled" => [ "samplingRate" => 0 ], "stickyHeaderDisabled" => [ "samplingRate" => 0 ], "stickyHeaderTreatment" => [ "samplingRate" => 1 ] ], ];
- When sticky header is enabled and a sticky header A/B test is enabled and user is NOT in the treatment bucket, you should NOT see edit icons in sticky header
$wgVectorStickyHeader = [ "logged_in" => true, "logged_out" => false, ]; $wgVectorWebABTestEnrollment = [ "name" => "vector.sticky_header_edit", "enabled" => true, "buckets" => [ "control" => [ "samplingRate" => 0 ], "unsampled" => [ "samplingRate" => 0 ], "stickyHeaderDisabled" => [ "samplingRate" => 1 ], "stickyHeaderTreatment" => [ "samplingRate" => 0 ] ], ];
QA Results - Beta
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T310750#8054160 |
| 2 | ✅ | T310750#8054160 |
QA Results - Prod
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T310750#8069513 |
| 2 | ✅ | T310750#8069513 |