@KStoller-WMF I think this is actionable, I will create a separate task for the "Edit quality" component, which can be built later when its specifications are finalized.

Change 819113 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] User impact: add edit count and thanks score cards

https://gerrit.wikimedia.org/r/819113

Change 819113 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] User impact: add edit count and thanks score cards

https://gerrit.wikimedia.org/r/819113

We're missing the Codex replacement for the tooltip component that shows information when clicking on the info icons. We could use the Mentor dashboard dropdown style component (mind that that component does not have horizontal overflow control so we might need to restrict its width and unfolding side for some time so it works on mobile). We could also try to use mobile front end dialogs although they are a bit obtrusive. Or we could create a hidden collapsible section under the score cards. cc @KieranMcCann @kostajh

@Sgs could you send me a screenshot of what you mean by ‘Mentor dashboard dropdown style component’ as I’m not entirely clear on what that is. Thanks

In T310665#8273436, @KieranMcCann wrote:

@Sgs could you send me a screenshot of what you mean by ‘Mentor dashboard dropdown style component’ as I’m not entirely clear on what that is. Thanks

An alternative that I can think of is a contextual collapsible area below the scorecards as opposite of a floating overlay. Something similar to the red tooltip in the screenshot below:

@Sgs Thanks for sending those. My preference would be to use the ‘mentor dashboard dropdown style’ you mentioned.

Noting here that after discussion on T310666 it has been proposed that the ‘last edited’ and ‘best streak’ data points should be styled as scorecards and moved into the summary panel. Figma designs have been updated to reflect this.

In T310665#8308600, @KieranMcCann wrote:

@Sgs Thanks for sending those. My preference would be to use the ‘mentor dashboard dropdown style’ you mentioned.

Ack, we will use that one until Codex provides a fine replacement.

In T310665#8308613, @KieranMcCann wrote:

Noting here that after discussion on T310666 it has been proposed that the ‘last edited’ and ‘best streak’ data points should be styled as scorecards and moved into the summary panel. Figma designs have been updated to reflect this.

Ack, I've updated the task description with the newer screenshot.

How would this change affect the mobile summary view in T318542: Impact module: Create mobile summary view?

Change 842848 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] User impact: display best streak data in scorecards

https://gerrit.wikimedia.org/r/842848

Change 842848 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] User impact: display best streak data in scorecards

https://gerrit.wikimedia.org/r/842848

Change 844462 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Mentee overview: move info popover components to vue-components

https://gerrit.wikimedia.org/r/844462

Change 844463 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] User impact: add infoboxes to thanks and streak scorecards

https://gerrit.wikimedia.org/r/844463

Change 844467 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] User impact: adapt content margin/padding when displayed in the mobile overlay

https://gerrit.wikimedia.org/r/844467

Change 844462 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Mentee overview: move info popover components to vue-components

https://gerrit.wikimedia.org/r/844462

Change 844467 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] User impact: adapt content margin/padding when displayed in the mobile overlay

https://gerrit.wikimedia.org/r/844467

Change 845482 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] User impact: use config skin instead of homepagemobile to adapt mobile styles

https://gerrit.wikimedia.org/r/845482

Change 844463 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] User impact: add infoboxes to thanks and streak scorecards

https://gerrit.wikimedia.org/r/844463

Change 850033 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] New impact: delete wrong info icon label

https://gerrit.wikimedia.org/r/850033

Change 850033 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] New impact: delete wrong info icon label

https://gerrit.wikimedia.org/r/850033

@Sgs - is the following spec will be implemented in another task?

Thanks Received count - with link to Special:Log?type=thanks filtered by the user

For @RHo quick review - the functionality/UI seem to be fine. The screenshots are for illustration (no issues were found):

Mobile

Below is my note on the info buttons in RTL. If no follow-up actions are needed on this task, you may move it to Test in Production.

Note:

• just double-checking if it's intended - two types of info icons are present in RTL

The bulb info icon is present in arwiki production now too - in the Add image dialog and on the MentorDashboard.

In T310665#8426469, @Etonkovidova wrote:

@Sgs - is the following spec will be implemented in another task?

Thanks Received count - with link to Special:Log?type=thanks filtered by the user

I made T324087: NewImpact: Thanks Received count should be a link to Special:Log?type=thanks filtered by the user for that.

In T310665#8431179, @kostajh wrote:

In T310665#8426469, @Etonkovidova wrote:

@Sgs - is the following spec will be implemented in another task?

Thanks Received count - with link to Special:Log?type=thanks filtered by the user

I made T324087: NewImpact: Thanks Received count should be a link to Special:Log?type=thanks filtered by the user for that.

T324087 - Verified in wmf.12.
Leaving in Design Review to get feedback on https://phabricator.wikimedia.org/T310665#8426469 (re different info icons on arwiki).

In T310665#8439851, @Etonkovidova wrote:

In T310665#8431179, @kostajh wrote:

In T310665#8426469, @Etonkovidova wrote:

@Sgs - is the following spec will be implemented in another task?

Thanks Received count - with link to Special:Log?type=thanks filtered by the user

I made T324087: NewImpact: Thanks Received count should be a link to Special:Log?type=thanks filtered by the user for that.

T324087 - Verified in wmf.12.
Leaving in Design Review to get feedback on https://phabricator.wikimedia.org/T310665#8426469 (re different info icons on arwiki).

Thanks @Etonkovidova - this is indeed not expected, it should always be the "i" info icon in arwiki as well.
Secondly, please note that the info icons here should only be 16x16px sized per the spec (as it is expected to be using the the info icons and the popup button widget in OOUI):

I am putting back into in-progress, + @KieranMcCann for visibility and re-review of revisions while I'm OoO. Thanks again!

In T310665#8440081, @RHo wrote:

Thanks @Etonkovidova - this is indeed not expected, it should always be the "i" info icon in arwiki as well.

I don't think that's the correct expectation, per discussion in T178568: [Investigate] Should some OOUI-icons be different on ar-wiki? my understanding is the expectation for Arabic language is to see a light bulb icon every where. The reason for the discrepancy is we're using a non-standard non-OOUI icon called info-unpadded per alignment requirements in T236854: [mobile] Newcomer tasks - UI issues with Suggested edits module and Difficulty overlay

Secondly, please note that the info icons here should only be 16x16px sized per the spec (as it is expected to be using the the info icons and the popup button widget in OOUI):

In the new impact module built with Vue and Codex we're using Codex icons which render at 20x20px and so is the info icon from the suggested edits module per requirements in T258020#6439128.

My proposal would be to drop "info-unpadded" custom icon in favor of standard "info" which will always display as light bulb in Arabic and do any alignment adjustments in CSS.

In T310665#8470610, @Sgs wrote:

In T310665#8440081, @RHo wrote:

Thanks @Etonkovidova - this is indeed not expected, it should always be the "i" info icon in arwiki as well.

I don't think that's the correct expectation, per discussion in T178568: [Investigate] Should some OOUI-icons be different on ar-wiki? my understanding is the expectation for Arabic language is to see a light bulb icon every where. The reason for the discrepancy is we're using a non-standard non-OOUI icon called info-unpadded per alignment requirements in T236854: [mobile] Newcomer tasks - UI issues with Suggested edits module and Difficulty overlay

Secondly, please note that the info icons here should only be 16x16px sized per the spec (as it is expected to be using the the info icons and the popup button widget in OOUI):

In the new impact module built with Vue and Codex we're using Codex icons which render at 20x20px and so is the info icon from the suggested edits module per requirements in T258020#6439128.

There was a task recent to update the smaller info that is used in these tooltip/popovers so that it shows at the smaller size https://phabricator.wikimedia.org/T311382. If we are proceeding with the lightbulb icon for Arabic, it should be similarly made smaller - is this a relatively easy fix?

My proposal would be to drop "info-unpadded" custom icon in favor of standard "info" which will always display as light bulb in Arabic and do any alignment adjustments in CSS.

Thanks, works for me.

Change 877167 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] WIP use standard info icon instead of info-unpadded

https://gerrit.wikimedia.org/r/877167

In T310665#8514176, @kostajh wrote:

In T310665#8508967, @gerritbot wrote:

Change 877167 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] WIP use standard info icon instead of info-unpadded

https://gerrit.wikimedia.org/r/877167

@Sgs assigning to you, per the patch you've submitted.

I have filed T327497: Standardize info icon size and RTL alternative graphic to tackle the icon discrepancies aside since there are some design questions I'd like to clarify. And also this ticket can go to QA/Test in production, if @Etonkovidova agrees.