Maniphest T310504

Improve test coverage of InfoRetriever/GeoIp2EnterpriseInfoRetriever.php and InfoRetriever/GeoLite2InfoRetriever.php
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	Tchanders
	Jun 13 2022, 2:47 PM

Tags

Referenced Files

None

Subscribers

Description

Coverage report: https://doc.wikimedia.org/cover-extensions/IPInfo/InfoRetriever/index.html

InfoRetriever/GeoIp2EnterpriseInfoRetriever.php
__construct, getName, getReader, retriveFromIP, getCoordinates, getAsn, getOrganization, getCountry, getLocations, getIsp, getConnectionType, getUserType, getProxyType

InfoRetriever/GeoLite2InfoRetriever.php
getName, getReader, getCoordinates, getAsn, getOrganization, getCountry, getLocations

Details

	Subject	Repo	Branch	Lines +/-
	Update GeoIP retriever tests	mediawiki/extensions/IPInfo	master	+318 -12

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		kostajh	T309580 Improve IPInfo test coverage
		Resolved		STran	T310504 Improve test coverage of InfoRetriever/GeoIp2EnterpriseInfoRetriever.php and InfoRetriever/GeoLite2InfoRetriever.php

Event Timeline

Tchanders created this task.Jun 13 2022, 2:47 PM

Tchanders moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.Jun 13 2022, 2:52 PM

• AGueyte set the point value for this task to 3.Jun 13 2022, 3:42 PM

Tchanders updated the task description. (Show Details)Jun 13 2022, 3:43 PM

Tchanders moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.Jun 14 2022, 3:37 PM

ARamirez_WMF moved this task from Cards ready for development to AHaT Sprint 10: The Mokorotlo on the Anti-Harassment board.Jun 14 2022, 5:04 PM

ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 10: The Mokorotlo); removed Anti-Harassment.

STran claimed this task.Jun 21 2022, 7:58 AM

STran moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 10: The Mokorotlo) board.

Change 807060 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/IPInfo@master] Update GeoLite2InfoRetrieverTest

https://gerrit.wikimedia.org/r/807060

gerritbot added a project: Patch-For-Review.Jun 21 2022, 8:10 AM

STran moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 10: The Mokorotlo) board.Jun 21 2022, 8:38 AM

ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 11: The Fascinator); removed Anti-Harassment (AHaT Sprint 10: The Mokorotlo).Jun 28 2022, 5:21 PM

ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 11: The Fascinator) board.

Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 11: The Fascinator) board.Jul 5 2022, 11:54 AM

Tchanders moved this task from QA/Testing 🐞 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 11: The Fascinator) board.

ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 12: The Dutch Cap); removed Anti-Harassment (AHaT Sprint 11: The Fascinator).Jul 18 2022, 11:24 PM

ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 12: The Dutch Cap) board.Jul 18 2022, 11:24 PM

Tchanders moved this task from Code Review 🔍 to Done Q4 2022 on the Anti-Harassment (AHaT Sprint 12: The Dutch Cap) board.Jul 19 2022, 9:51 AM

Change 807060 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Update GeoIP retriever tests

https://gerrit.wikimedia.org/r/807060

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.22; 2022-07-25).Jul 19 2022, 10:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jul 19 2022, 10:30 AM

• Prtksxna moved this task from Backlog to In Progress on the IP Info board.Aug 8 2022, 4:07 AM

• Prtksxna closed this task as Resolved.Aug 8 2022, 4:25 AM

• Prtksxna moved this task from In Progress to Closed on the IP Info board.