[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T309068

[betalabs-mobile] Publishing edits from source editor re-opens page in editing mode
Closed, ResolvedPublic
Actions

Description

Found when testing T305543: Verify Growth editing workflows on mobile.

  1. On mobile go to an article and open the source editor.
  2. Make an edit and click "Publish changes"

The page will re-load several times; the page will be re-opened in the source editor and the publish success message will be displayed on the page

Note: Editing and publishing edits in the deskop mode won't have the issue described above.

Below are two screen recordings for comparison:

betalabstestwiki wmf.12
source_editor reload.gif (702×351 px, 286 KB)
source_editor reload2.gif (702×351 px, 177 KB)

Details

SubjectRepoBranchLines +/-
Follow-up I97c27fd7: Fix after-edit reload in source editormediawiki/extensions/MobileFrontendwmf/1.39.0-wmf.13+11 -7
Follow-up I97c27fd7: Fix after-edit reload in source editormediawiki/extensions/MobileFrontendmaster+11 -7
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.May 24 2022, 12:40 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 24 2022, 12:40 AM
Etonkovidova mentioned this in T305543: Verify Growth editing workflows on mobile.May 24 2022, 12:46 AM
Maintenance_bot added a project: VisualEditor.May 24 2022, 1:29 AM
Esanders triaged this task as High priority.May 24 2022, 2:47 PM
Esanders raised the priority of this task from High to Unbreak Now!.May 24 2022, 2:51 PM

Regression caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/793080

gerritbot added a comment.May 24 2022, 2:56 PM

Change 798726 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/MobileFrontend@master] Follow-up I97c27fd7: Fix after-edit reload in source editor

https://gerrit.wikimedia.org/r/798726

gerritbot added a project: Patch-For-Review.May 24 2022, 2:56 PM
Esanders added a comment.May 24 2022, 2:57 PM

Will need backporting to wmf13

Esanders claimed this task.May 24 2022, 2:58 PM
Esanders edited projects, added Editing-team (Kanban Board); removed Editing-team.
Esanders moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
gerritbot added a comment.May 24 2022, 3:31 PM

Change 798726 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Follow-up I97c27fd7: Fix after-edit reload in source editor

https://gerrit.wikimedia.org/r/798726

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.14; 2022-05-30).May 24 2022, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 24 2022, 4:30 PM
gerritbot added a comment.May 24 2022, 7:47 PM

Change 798811 had a related patch set uploaded (by Bartosz Dziewoński; author: Esanders):

[mediawiki/extensions/MobileFrontend@wmf/1.39.0-wmf.13] Follow-up I97c27fd7: Fix after-edit reload in source editor

https://gerrit.wikimedia.org/r/798811

gerritbot added a project: Patch-For-Review.May 24 2022, 7:47 PM
matmarex added a parent task: T305219: 1.39.0-wmf.13 deployment blockers.May 24 2022, 8:03 PM
gerritbot added a comment.May 24 2022, 9:53 PM

Change 798811 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@wmf/1.39.0-wmf.13] Follow-up I97c27fd7: Fix after-edit reload in source editor

https://gerrit.wikimedia.org/r/798811

Stashbot added a comment.May 24 2022, 9:56 PM

Mentioned in SAL (#wikimedia-operations) [2022-05-24T21:56:50Z] <cjming@deploy1002> Synchronized php-1.39.0-wmf.13/extensions/MobileFrontend: Backport: [[gerrit:798811|Follow-up I97c27fd7: Fix after-edit reload in source editor (T309068)]] (duration: 00m 48s)

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.13; 2022-05-23); removed MW-1.39-notes (1.39.0-wmf.14; 2022-05-30).May 24 2022, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 24 2022, 10:30 PM
matmarex moved this task from To Triage to Triaged on the VisualEditor board.May 24 2022, 10:52 PM
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.
matmarex added a project: Editing QA.
dancy subscribed.May 25 2022, 2:46 PM

Has this issue been resolved?

matmarex added a comment.May 25 2022, 3:17 PM

Yes. Sorry, I marked it as a deployment blocker when I wasn't sure whether I'll be able to backport the fix, and I forgot to remove it afterwards.

matmarex removed a parent task: T305219: 1.39.0-wmf.13 deployment blockers.May 25 2022, 3:17 PM
dancy added a comment.May 25 2022, 3:17 PM
In T309068#7957375, @matmarex wrote:

Yes. Sorry, I marked it as a deployment blocker when I wasn't sure whether I'll be able to backport the fix, and I forgot to remove it afterwards.

No problem. Thanks for the info.

EAkinloose edited projects, added Verified; removed Editing QA.May 25 2022, 7:45 PM
EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
ppelberg closed this task as Resolved.May 27 2022, 1:09 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits