[go: up one dir, main page]

Page MenuHomePhabricator

Kartotherian should log using normalized message format strings and a values array
Open, Needs TriagePublic

Description

This makes it possible to group messages abstractly, even if the specific values differ. Bunyan and console seem to support formatted logging as logger.log( 'info', 'stuff %s', var1 ), but I'm not sure if the service-runner framework wires parameters through already. I didn't look into Gelf-stream yet. Ideally, our substituted message values are referenced by key into a map, so this should be investigated while doing the work here.

Event Timeline

This might be harder than I had expected. normalized_message is added by our PHP log processor just before doing substitutions, but there seems to be no such support in JS yet. We might be able to pass "normalized_message" and "msg" keys to the logger but it would probably require a new wrapper around the logger, and some custom Error subclasses.