[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T308464

Remove address fields on India payment forms
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

FRTech - despite Dlocal maintaining that the address fields were mandatory in the India forms, they have now backed off and said they are not a requirement. Can we remove/supress the address fields on our payments page therefore? The less fields the donor has to populate, the higher the conversion. Apologies for again revisiting this form!

On may 27th, after talk with Sebastian from dlocal, we decide to set city value as default Mumbai, and their fraud team will not check the city field, and once we migrate to 2.0 api, we no longer need to pass the city as required param.

Details

SubjectRepoBranchLines +/-
Set city as Mumbai for India as defaultmediawiki/extensions/DonationInterfacemaster+3 -2
Remove street from required field for Indiamediawiki/extensions/DonationInterfacemaster+0 -1
City is necessary for Indiamediawiki/extensions/DonationInterfacemaster+0 -1
City is necessary for Indamediawiki/extensions/DonationInterfacemaster+1 -0
Remove street and city for india dlocalwikimedia/fundraising/devmaster+2 -2
Remove city and stree from IN Dlocal as required fieldmediawiki/extensions/DonationInterfacemaster+0 -2
Customize query in gerrit

Related Objects

Event Timeline

EMartin created this task.May 16 2022, 5:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 16 2022, 5:35 PM
• DStrine moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.May 16 2022, 5:45 PM
Dwisehaupt set the point value for this task to 2.May 17 2022, 7:59 PM
gerritbot added a comment.May 24 2022, 4:16 PM

Change 798831 had a related patch set uploaded (by Wfan; author: Wfan):

[mediawiki/extensions/DonationInterface@master] Remove city and stree from IN Dlocal as required field

https://gerrit.wikimedia.org/r/798831

gerritbot added a project: Patch-For-Review.May 24 2022, 4:16 PM
gerritbot added a comment.May 24 2022, 4:26 PM

Change 798846 had a related patch set uploaded (by Wfan; author: Wfan):

[wikimedia/fundraising/dev@master] Remove street and city for india dlocal

https://gerrit.wikimedia.org/r/798846

AnnWF subscribed.May 24 2022, 4:30 PM

Hi Evelyn, city is not necessary when I test payment locally, so I am not sure should we also remove city for India dlocal since you mentioned less fields more conversion? or we want to keep city field? @EMartin Thanks

XenoRyet moved this task from Sprint +1 to Current Sprint on the Fundraising-Backlog board.May 24 2022, 7:55 PM
EMartin added a comment.May 24 2022, 8:02 PM

@AnnWF Hi Ann, let's remove the city field too. Thanks for asking! It also is not a requirement and minimization is better.

XenoRyet added a project: Fundraising Sprint Juggalology 2022.May 24 2022, 8:08 PM
Ejegg moved this task from Backlog to Review on the Fundraising Sprint Juggalology 2022 board.May 24 2022, 9:40 PM
Ejegg mentioned this in T308167: DLocal responses with 'Invalid control'.May 24 2022, 9:44 PM
AnnWF added a comment.EditedMay 25 2022, 2:57 AM
In T308464#7954436, @EMartin wrote:

@AnnWF Hi Ann, let's remove the city field too. Thanks for asking! It also is not a requirement and minimization is better.

Hi Evelyn, thanks for your quick reply, sorry that I just realized that we also have the PAN number (fiscal_number) as an optional filed, do we want to get rid of it too? Thanks. @EMartin

AnnWF claimed this task.May 25 2022, 3:54 PM
gerritbot added a comment.May 25 2022, 8:17 PM

Change 798831 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Remove city and stree from IN Dlocal as required field

https://gerrit.wikimedia.org/r/798831

Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Juggalology 2022 board.May 25 2022, 8:19 PM
EMartin added a comment.May 25 2022, 8:35 PM

@AnnWF Hi Ann, we need to keep the PAN field but we should see new language around it indicating it is optional which was requested in this task: https://phabricator.wikimedia.org/T308332. Thanks for checking.

AnnWF added a comment.May 25 2022, 8:37 PM

great thanks!

In T308464#7958272, @EMartin wrote:

@AnnWF Hi Ann, we need to keep the PAN field but we should see new language around it indicating it is optional which was requested in this task: https://phabricator.wikimedia.org/T308332. Thanks for checking.

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.14; 2022-05-30).May 25 2022, 9:00 PM
AnnWF moved this task from Pending Deployment to Review on the Fundraising Sprint Juggalology 2022 board.May 26 2022, 12:46 AM
Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Juggalology 2022 board.May 26 2022, 2:49 PM
EMartin added a comment.May 26 2022, 4:04 PM

@AnnWF Hi Ann, we need to keep the PAN field but we should see new language around it indicating it is optional

gerritbot added a comment.May 26 2022, 4:12 PM

Change 798846 merged by Ejegg:

[wikimedia/fundraising/dev@master] Remove street and city for india dlocal

https://gerrit.wikimedia.org/r/798846

Ejegg mentioned this in rWFDVcb9c4eeb1a69: Remove street and city for india dlocal.May 26 2022, 4:13 PM
Maintenance_bot removed a project: Patch-For-Review.May 26 2022, 4:30 PM
Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Juggalology 2022 board.May 27 2022, 12:53 AM
AnnWF added a subscriber: Ejegg.EditedMay 27 2022, 2:09 AM

Hi @EMartin, this is deployed now, thanks @Ejegg :)

https://payments.wikimedia.org/index.php?title=Special:AstroPayGateway&appeal=JimmyQuote&recurring=false&currency=INR&country=IN&payment_method=cc&gateway=astropay&uselang=en&amount=300&variant=panExplain&utm_medium=spontaneous&utm_campaign=spontaneous&utm_source=fr-redir.default%7Edefault%7Edefault%7Edefault%7Econtrol.cc&utm_key=vw_1261%7Evh_771%7EotherAmt_0%7Etime_2

Ejegg moved this task from Done to Blocked in sprint (not fr-tech) on the Fundraising Sprint Juggalology 2022 board.May 27 2022, 2:32 AM

Darn, this seems to be another case where sandbox and production have different rules. I'm seeing errors in the logs saying empty param x_city. I'm rolling back just this patch for now.

[status] => 1 [desc] => Empty param x_city [error_code] => 301

EMartin added a comment.May 27 2022, 3:20 PM

@Ejegg. Shall I get Dlocal involved?

EMartin added a comment.May 27 2022, 3:23 PM

I suggest directing questions to: Sebastian Quintero <squintero@dlocal.com>

AnnWF added a comment.May 27 2022, 3:42 PM

Yes we should.

In T308464#7963362, @EMartin wrote:

@Ejegg. Shall I get Dlocal involved?

Ok, I will write an Email to Sebastian and cc you and Elliott for this issue. Thanks

In T308464#7963373, @EMartin wrote:

I suggest directing questions to: Sebastian Quintero <squintero@dlocal.com>

gerritbot added a comment.May 27 2022, 4:33 PM

Change 800767 had a related patch set uploaded (by Wfan; author: Wfan):

[mediawiki/extensions/DonationInterface@master] City is necessary for Inda

https://gerrit.wikimedia.org/r/800767

gerritbot added a project: Patch-For-Review.May 27 2022, 4:33 PM
gerritbot added a comment.May 27 2022, 4:36 PM

Change 800767 abandoned by Wfan:

[mediawiki/extensions/DonationInterface@master] City is necessary for Inda

Reason:

https://gerrit.wikimedia.org/r/800767

gerritbot added a comment.May 27 2022, 4:36 PM

Change 800768 had a related patch set uploaded (by Wfan; author: Wfan):

[mediawiki/extensions/DonationInterface@master] City is necessary for Inda

https://gerrit.wikimedia.org/r/800768

gerritbot added a comment.May 27 2022, 4:40 PM

Change 800771 had a related patch set uploaded (by Wfan; author: Wfan):

[mediawiki/extensions/DonationInterface@master] Remove stree from required field for India

https://gerrit.wikimedia.org/r/800771

gerritbot added a comment.May 27 2022, 4:40 PM

Change 800768 abandoned by Wfan:

[mediawiki/extensions/DonationInterface@master] City is necessary for India

Reason:

https://gerrit.wikimedia.org/r/800768

gerritbot added a comment.May 27 2022, 5:11 PM

Change 800771 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Remove street from required field for India

https://gerrit.wikimedia.org/r/800771

AnnWF updated the task description. (Show Details)May 27 2022, 5:50 PM
gerritbot added a comment.May 27 2022, 6:06 PM

Change 800781 had a related patch set uploaded (by Wfan; author: Wfan):

[mediawiki/extensions/DonationInterface@master] Set city as Mumbai for India as default

https://gerrit.wikimedia.org/r/800781

gerritbot added a comment.May 27 2022, 6:55 PM

Change 800781 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Set city as Mumbai for India as default

https://gerrit.wikimedia.org/r/800781

AnnWF added a comment.May 27 2022, 9:36 PM

Hi @EMartin, we it's deployed now, as Sebastian's suggested for our 1.0 Api, we now always pass Mumbai as default city for India instead of ask customers.

AnnWF moved this task from Blocked in sprint (not fr-tech) to Done on the Fundraising Sprint Juggalology 2022 board.May 27 2022, 9:36 PM
XenoRyet closed this task as Resolved.Jun 7 2022, 7:08 PM
XenoRyet set Final Story Points to 2.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits