[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T307745

Current language shown in missing languages banner
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:

The message Cx-uls-relevant-languages-banner-text-multiple-missing is shown with "English" which is the current page lang. I think this is related with T290972

Missing in English, română and more
This page is not available in the language you searched for.

And when I click on "...and more":

This page is missing in some languages you may know. You can translate it in minutes!
+ English + română

Same thing on Polish Wikipedia (when you search for Polish/polski).

What should have happened instead?:

Current page language should be omitted from this search / suggestions.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

MediaWiki 1.39.0-wmf.10 (6139f98)
01:02, 3 May 2022

FF 99

I have some modifications, but I know this happens for other users too.

obraz.png (439×1 px, 102 KB)

Details

SubjectRepoBranchLines +/-
ULS entrypoint: Do not show current language, fix domain redirectsmediawiki/extensions/ContentTranslationwmf/1.39.0-wmf.10+17 -19
ULS entrypoint: Do not show current language, fix domain redirectsmediawiki/extensions/ContentTranslationmaster+17 -19
Customize query in gerrit

Related Objects

Event Timeline

Nux created this task.May 5 2022, 8:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 5 2022, 8:17 PM
Nux updated the task description. (Show Details)May 5 2022, 8:19 PM
Nux added a comment.May 5 2022, 8:30 PM

Also note that the menu is not working.

  1. When I click on "English" I'm redirected to a wrong domain (should be en): https://english.wikipedia.org/wiki/Special:ContentTranslation?from=en&to=English&page=Simone+Giertz
  2. When I click on "română" I'm redirected to a wrong domain: https://română.wikipedia.org/wiki/Special:ContentTranslation?from=en&to=English&page=Simone+Giertz
  3. When I click on "•••" I see an error:
    1. TypeError: domain is null
    2. getPageUrl https://en.wikipedia.org/wiki/Simone_Giertz line 10 > injectedScript:22
    3. getCXUrl https://en.wikipedia.org/wiki/Simone_Giertz line 10 > injectedScript:24
    4. redirectToCX https://en.wikipedia.org/wiki/Simone_Giertz line 10 > injectedScript:18
    5. jQuery 4

Same error in debug mode:

22:26:11.720 TypeError: domain is null
load.php:11768:11
    jQuery 66
    doPropagation https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&
    (asynchroniczny: requestIdleCallback handler)
    setAndPropagate https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&
    markModuleReady https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&
    nestedAddScript https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&
    nestedAddScript https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&
    queueModuleScript https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&
    onerror https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&
    (asynchroniczny: EventHandlerNonNull)
    addScript https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&
    queueModuleScript https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&
    queueModuleScript https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&
    nestedAddScript https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&
    runScript https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&
    execute https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&
    doPropagation https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&
    (asynchroniczny: requestIdleCallback handler)
    setAndPropagate https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&
    markModuleReady https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&
    nestedAddScript https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&
    nestedAddScript https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&
    queueModuleScript https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&
    onerror https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&>

data from intake-analytics.wikimedia.org :-)

  • hasty=true :-)
  • client_dt: 2022-05-05T20:25:41.473Z
  • token: 1571e7521e18e05c7084
Aklapper triaged this task as High priority.May 6 2022, 7:03 AM
Aklapper merged a task: T307670: All "Translate this page" entrypoint links in compact language selector go to non-existing hostnames.
Aklapper added projects: ContentTranslation, Regression.
Aklapper added a subscriber: Unite_together.
KartikMistry subscribed.May 6 2022, 7:51 AM
gerritbot added a comment.May 6 2022, 8:38 AM

Change 789775 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] ULS entrypoint: Do not show current language, fix domain redirects

https://gerrit.wikimedia.org/r/789775

gerritbot added a project: Patch-For-Review.May 6 2022, 8:38 AM
Func merged a task: T307786: ContentTranslation is suggesting unexisting "missing languages".May 6 2022, 2:27 PM
Func added a subscriber: valerio.bozzolan.
gerritbot added a comment.May 6 2022, 5:43 PM

Change 789832 had a related patch set uploaded (by KartikMistry; author: Santhosh):

[mediawiki/extensions/ContentTranslation@wmf/1.39.0-wmf.10] ULS entrypoint: Do not show current language, fix domain redirects

https://gerrit.wikimedia.org/r/789832

Aklapper merged a task: T307835: The prompt in "Languages" is incorrectly displayed when using Vector 2022.May 7 2022, 2:09 PM
Aklapper added subscribers: Yining_Chen, MilkyDefer, Stang.
KartikMistry merged a task: T307858: CX is not working in the new language selector.May 8 2022, 8:34 AM
KartikMistry added subscribers: Ladsgroup, ngkountas.
gerritbot added a comment.May 9 2022, 5:31 AM

Change 789832 abandoned by KartikMistry:

[mediawiki/extensions/ContentTranslation@wmf/1.39.0-wmf.10] ULS entrypoint: Do not show current language, fix domain redirects

Reason:

Will cherry-pick new change.

https://gerrit.wikimedia.org/r/789832

santhosh claimed this task.May 9 2022, 5:38 AM
santhosh added a project: Language-Team (Language-2022-April-June).
santhosh moved this task from Quarter Backlog to In Review on the Language-Team (Language-2022-April-June) board.
gerritbot added a comment.May 9 2022, 5:59 AM

Change 789832 restored by KartikMistry:

[mediawiki/extensions/ContentTranslation@wmf/1.39.0-wmf.10] ULS entrypoint: Do not show current language, fix domain redirects

https://gerrit.wikimedia.org/r/789832

gerritbot added a comment.May 9 2022, 6:53 AM

Change 789775 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] ULS entrypoint: Do not show current language, fix domain redirects

https://gerrit.wikimedia.org/r/789775

gerritbot added a comment.May 9 2022, 1:24 PM

Change 789832 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@wmf/1.39.0-wmf.10] ULS entrypoint: Do not show current language, fix domain redirects

https://gerrit.wikimedia.org/r/789832

Stashbot mentioned this in T298032: Surface missing languages in current mobile language selector to access Section Translation.May 9 2022, 1:37 PM

Mentioned in SAL (#wikimedia-operations) [2022-05-09T13:37:15Z] <taavi@deploy1002> Synchronized php-1.39.0-wmf.10/extensions/ContentTranslation/modules/entrypoints: Backport: [[gerrit:789832|ULS entrypoint: Do not show current language, fix domain redirects (T307745 T298032)]] (duration: 00m 50s)

KartikMistry moved this task from In Review to Needs QA on the Language-Team (Language-2022-April-June) board.May 9 2022, 1:42 PM
Nikerabbit moved this task from Needs Triage to Bugs on the ContentTranslation board.Jun 6 2022, 11:42 AM
EChukwukere-WMF subscribed.Jun 15 2022, 2:58 AM

Fixed, the current page language does not show in the missing languages banner

QA PASS

EChukwukere-WMF moved this task from Needs QA to Done on the Language-Team (Language-2022-April-June) board.Jun 15 2022, 2:59 AM
Pginer-WMF closed this task as Resolved.Jun 17 2022, 8:24 AM
Stang unsubscribed.Jun 17 2022, 8:51 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits