Maniphest T301932

Topic subscription notifications do not take you to precise location where activity exists when sections are collapsed
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ppelberg
	Feb 17 2022, 2:26 AM

Description

Behavior

Screen recording
🎥: https://youtu.be/m1N-RkDYHAE

Steps

Open the Wikipedia mobile site (e.g. https://en.m.wikipedia.org/w/index.php?title=Main_Page)
Visit Special:MobileOptions
Ensure the Expand all sections setting is DISABLED
Tap the 🔔 to open the notification drawer/Echo
Tap a notification about a new comment that's been posted in a discussion you are subscribed to (it shouldn't matter whether you have read the notification or not)

Actual

❗️ Arrive at the top of the talk page where the new comment you were being notified about was posted

Expected

✅ Arrive at talk page were the new comment you were being notified about was posted, with the viewport scrolled so that the new comment you were being notified about is clearly in view and highlighted per T263820

Details

	Subject	Repo	Branch	Lines +/-
	Toggler: Fix revealing sections with special characters like `"` `,` `(`	mediawiki/extensions/MobileFrontend	master	+9 -28

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T278588 Mobile talk page improvements
Resolved	None	T298055 [RELEASE TICKET] Offer Mobile Usability Improvements and Topic Subscriptions at Partner Wikis
Resolved	matmarex	T301932 Topic subscription notifications do not take you to precise location where activity exists when sections are collapsed

Event Timeline

ppelberg created this task.Feb 17 2022, 2:26 AM

ppelberg updated the task description. (Show Details)

ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.

ppelberg moved this task from Untriaged to Upcoming on the Editing-team board.

ppelberg added a project: Wikipedia-Preview (Mobile-Prototype).

ppelberg edited projects, added Mobile; removed Wikipedia-Preview (Mobile-Prototype).Feb 17 2022, 2:28 AM

ppelberg edited projects, added Editing-team (Kanban Board); removed Editing-team.Mar 5 2022, 2:22 AM

ppelberg moved this task from Incoming to Ready to Be Worked On on the Editing-team (Kanban Board) board.

This is a combination of (1) DT is not enabled on mobile on that wiki and (2) that particular page current breaks DT (see T301578#7755053)

This should work now, but it still does not for some links on that page.

I debugged this and it turns out to be a bug in MobileFrontend, where links to sections with parentheses will not open that section.

I found some similar bug reports about issues with special characters in sections: T230293, T300620

Change 791464 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/MobileFrontend@master] Toggler: Fix revealing sections with special characters like `"` `,` `(`

https://gerrit.wikimedia.org/r/791464

gerritbot added a project: Patch-For-Review.May 12 2022, 10:53 PM

matmarex claimed this task.May 12 2022, 10:57 PM

matmarex mentioned this in T300620: [Toggler] Certain links within the same article in WP don't open parent section.

matmarex mentioned this in T230293: [Chrome] On mobile web, links to sections whose names include double quote " work incorrectly.

matmarex moved this task from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.

Change 791464 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Toggler: Fix revealing sections with special characters like `"` `,` `(`

https://gerrit.wikimedia.org/r/791464

Maintenance_bot removed a project: Patch-For-Review.May 13 2022, 5:30 PM

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.May 13 2022, 10:27 PM

matmarex added a project: Editing QA.

matmarex moved this task from Inbox to Low Priority on the Editing QA board.May 23 2022, 5:34 PM

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Jun 2 2022, 4:24 PM

ppelberg closed this task as Resolved.Jun 3 2022, 11:11 PM

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJun 3 2022, 11:11 PM

	F35200410: IMG_5965.PNG
	Jun 2 2022, 4:23 PM

Topic subscription notifications do not take you to precise location where activity exists when sections are collapsedClosed, ResolvedPublicActions