[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T297237

Remove language switching alert box temporary feature flag - make it part of the core software
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
None
Authored By
cjming
Dec 7 2021, 8:39 PM
Tags
Referenced Files
F36976886: Screenshot 2023-05-05 at 7.43.07 AM.png
May 5 2023, 2:46 PM
F36976884: Screenshot 2023-05-05 at 7.41.48 AM.png
May 5 2023, 2:46 PM
F36976882: Screenshot 2023-05-05 at 7.41.29 AM.png
May 5 2023, 2:46 PM
F36971823: Screenshot 2023-05-01 at 2.05.32 PM.png
May 1 2023, 9:06 PM
F36971821: Screenshot 2023-05-01 at 2.05.10 PM.png
May 1 2023, 9:06 PM
F36971819: Screenshot 2023-05-01 at 2.04.49 PM.png
May 1 2023, 9:06 PM
Subscribers
Aklapper
cjming
Edtadros
Jdlrobson
• KieranMcCann
KSarabia-WMF
• nray
View All 10 Subscribers

Description

NOTE: See also T297368

The language switcher redirection was built as a temporary solution, but has now been present for over a year. We should remove the feature flag, as retaining it adds additional complexity to the skin and adds risk to deployments (e.g. it could be deployed without the language switcher where needed). The logic should be identical to the existing $wgVectorLanguageInHeader configuration, we don't need both.

Given our recent flurry of activity with indicators it would also be a good time to check in with a designert to see whether this should now be replaced with an indicator, given original designs preferred that.

Acceptance criteria

  • Remove VectorLanguageAlertInSidebar feature flag, and retain the existing behaviour when it's true. e.g. it should not be possible to remove the alert via configuration.
  • Talk to designer about whether it should be replaced with indicators. Create a ticket if necessary.

Developer notes

QA Steps

  1. Visit https://en.wikipedia.beta.wmflabs.org/wiki/Dog .
  2. Verify that language alert is in main menu
  3. Visit https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page
  4. Verify that the language alert is in main menu
  5. Visit https://en.wikipedia.beta.wmflabs.org/wiki/Wiojfojafaw
  6. Verify that the language alert is NOT in the main menu

QA Results - Beta

ACStatusDetails
1✅T297237#8817530
2✅T297237#8817530
3✅T297237#8817530

QA Results - Prod

ACStatusDetails
1✅T297237#8829690
2✅T297237#8829690
3✅T297237#8829690

Details

SubjectRepoBranchLines +/-
Remove language switching alert box temporary feature flagmediawiki/skins/Vectormaster+9 -92
Customize query in gerrit

Related Objects
Search...

Event Timeline

cjming created this task.Dec 7 2021, 8:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 7 2021, 8:39 PM
cjming added a project: Web-Team-Backlog.Dec 7 2021, 8:39 PM
cjming mentioned this in T295555: Language switching: put an alert in the sidebar about where the language links are.Dec 7 2021, 8:42 PM
cjming updated the task description. (Show Details)Dec 8 2021, 2:59 AM
cjming updated the task description. (Show Details)
Jdlrobson moved this task from Incoming to Not ready to estimate on the Web-Team-Backlog board.Dec 8 2021, 7:52 PM
ovasileva triaged this task as Medium priority.Dec 9 2021, 11:20 AM
ovasileva moved this task from Not ready to estimate to Current Fiscal Year on the Web-Team-Backlog board.
ovasileva mentioned this in T297367: [EPIC] Iterate on language button to improve discoverability.
ovasileva added a parent task: T297367: [EPIC] Iterate on language button to improve discoverability.
Peter subscribed.Mar 4 2022, 12:51 PM
Una_tantum subscribed.Sep 5 2022, 11:18 AM

Hi, with the deployment of the burger menu for the sidebar, actually the alert box is hidden for the most of users of Vector 2022.

Una_tantum added a comment.Oct 1 2022, 7:57 AM

Please consider to point out the alert box again, outside the collapsed menu by default, before the massive deployment on smallest wikis. Now it is hidden for the most of users of Vector 2022. This would help new users find the language button. It also would be useful to prevent a disorienting experience, similar to that already exerimented by early adopters wikis, which pushed to create this alert box.

Jdlrobson subscribed.Oct 7 2022, 7:19 PM

Given this has stayed in the codebase much longer than expected would it make sense to make this part of the software instead of a feature flag? Right now the feature is disabled by default (hence why new wikis are not getting it). We can always remove the code later if we decide we no longer need it, but the feature flag has lived much longer than expected.

Una_tantum mentioned this in T329531: Reduce the proliferation of language and translation links (Vector).Feb 25 2023, 6:55 PM
Jdlrobson added a subscriber: ovasileva.Apr 10 2023, 10:03 PM

@ovasileva can this be replaced with the pointer that we're adding on page load? Wouldn't that be more consistent?

Jdlrobson raised the priority of this task from Medium to High.Apr 10 2023, 10:03 PM
Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2); removed Web-Team-Backlog.

I'm bumping this to high as this was meant as a temporary solution and we've now had this for over a year.

Una_tantum added a comment.EditedApr 11 2023, 7:12 AM

Time counting should be done separately for each wiki, starting from the time the new default skin is launched. Because users usually are not in all wikis at the same time, but in few or only one wiki. So some of them haven't seen it for more than a few months.

In the future, consider adding the alert again for 2-3 months at the moment of the rollout on other wikis, showing it only for those communities having the change.
In T329531#8645948, I also suggested to put an indicator like others instead of this alert, because actually it is hidden by default in the menu so it is not so effective.

Jdlrobson renamed this task from Remove language switching alert box in sidebar to Remove language switching alert box in sidebar or make it part of the core software rather than a temporary feature flag.Apr 11 2023, 3:26 PM
Jdlrobson updated the task description. (Show Details)Apr 11 2023, 3:28 PM
Jdlrobson updated the task description. (Show Details)Apr 11 2023, 3:30 PM
Jdlrobson renamed this task from Remove language switching alert box in sidebar or make it part of the core software rather than a temporary feature flag to Remove language switching alert box temporary feature flag - make it part of the core software.Apr 12 2023, 9:31 PM
Jdlrobson updated the task description. (Show Details)
ovasileva set the point value for this task to 2.Apr 13 2023, 4:54 PM
ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2) board.Apr 24 2023, 4:14 PM
Jdlrobson moved this task from Ready for Development to Incoming on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2) board.Apr 24 2023, 5:41 PM
Jdlrobson lowered the priority of this task from High to Low.Apr 24 2023, 5:44 PM
Jdlrobson moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2) board.
• nray claimed this task.Apr 24 2023, 8:03 PM
• nray moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2) board.
gerritbot added a comment.Apr 27 2023, 8:53 PM

Change 912982 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/skins/Vector@master] Remove language switching alert box temporary feature flag

https://gerrit.wikimedia.org/r/912982

gerritbot added a project: Patch-For-Review.Apr 27 2023, 8:53 PM
• nray moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2) board.Apr 27 2023, 9:04 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2) board.Apr 28 2023, 12:25 AM
gerritbot added a comment.Apr 28 2023, 12:43 AM

Change 912982 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove language switching alert box temporary feature flag

https://gerrit.wikimedia.org/r/912982

Maintenance_bot removed a project: Patch-For-Review.Apr 28 2023, 1:10 AM
• nray removed • nray as the assignee of this task.Apr 28 2023, 3:33 PM
• nray subscribed.
• nray assigned this task to Edtadros.Apr 28 2023, 4:20 PM
• nray updated the task description. (Show Details)
• nray mentioned this in T335594: Remove language alert box, display indicator after main menu is pinned.Apr 28 2023, 4:44 PM
• nray added a comment.Apr 28 2023, 4:46 PM
  • Talk to designer about whether it should be replaced with indicators. Create a ticket if necessary.

Ticket created at T335594

Edtadros reassigned this task from Edtadros to ovasileva.May 1 2023, 9:06 PM
Edtadros moved this task from QA to Ready for Signoff on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2) board.
Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Visit https://en.wikipedia.beta.wmflabs.org/wiki/Dog .
✅ AC1: Verify that language alert is in main menu

Screenshot 2023-05-01 at 2.04.49 PM.png (739×1 px, 429 KB)

Visit https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page
✅ AC2: Verify that the language alert is in main menu
Screenshot 2023-05-01 at 2.05.10 PM.png (739×1 px, 227 KB)

Visit https://en.wikipedia.beta.wmflabs.org/wiki/Wiojfojafaw
✅ AC3: Verify that the language alert is NOT in the main menu
Screenshot 2023-05-01 at 2.05.32 PM.png (739×1 px, 203 KB)

ovasileva added a comment.May 2 2023, 2:55 PM

looks good, moving to QA in prod

ovasileva moved this task from Ready for Signoff to QA in Production on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2) board.May 2 2023, 2:55 PM
ovasileva reassigned this task from ovasileva to Edtadros.May 4 2023, 4:38 PM
Edtadros closed this task as Resolved.May 5 2023, 2:46 PM
Edtadros removed Edtadros as the assignee of this task.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki, cawiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Visit https://en.wikipedia.org/wiki/Dog .
✅ AC1: Verify that language alert is in main menu

Screenshot 2023-05-05 at 7.41.29 AM.png (2×1 px, 916 KB)

Visit https://en.wikipedia.org/wiki/Main_Page
✅ AC2: Verify that the language alert is in main menu

Screenshot 2023-05-05 at 7.41.48 AM.png (1×1 px, 519 KB)

Visit https://ca.wikipedia.org/wiki/Alfred_I,_Prince_of_Windisch-Gr%C3%A4tz
✅ AC3: Verify that the language alert is NOT in the main menu

Screenshot 2023-05-05 at 7.43.07 AM.png (1×1 px, 356 KB)

Edtadros updated the task description. (Show Details)May 5 2023, 2:49 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.9; 2023-05-15).May 16 2023, 12:01 AM
Jdlrobson merged a task: T335594: Remove language alert box, display indicator after main menu is pinned.May 23 2024, 12:43 AM
Jdlrobson added subscribers: KSarabia-WMF, • KieranMcCann.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits