[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T290761

Add an image: Create class for task-agnostic concerns for inspector
Closed, ResolvedPublic
Actions

Description

Both the mobile link and image inspectors:

  • are bottom positioned and are animated in from below
  • have a blue header w/robot icon
  • have a button in the header that invokes the help panel
  • are collapsible when clicked on the article
  • are re-opened when clicked on robot icon
  • put the article in read mode upon ESC key clicked

Screen Shot 2021-09-10 at 10.52.06 AM.png (492×658 px, 133 KB)

Screen Shot 2021-09-10 at 10.51.01 AM.png (700×754 px, 243 KB)

Details

SubjectRepoBranchLines +/-
Create StructuredTaskToolbarDialogmediawiki/extensions/GrowthExperimentsmaster+180 -134
Customize query in gerrit

Related Objects
Search...

Event Timeline

• mewoph created this task.Sep 10 2021, 5:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 10 2021, 5:52 PM
• mewoph triaged this task as Medium priority.Sep 10 2021, 5:52 PM
gerritbot added a comment.Sep 10 2021, 8:39 PM

Change 720392 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Create StructuredTaskToolbarDialog

https://gerrit.wikimedia.org/r/720392

gerritbot added a project: Patch-For-Review.Sep 10 2021, 8:39 PM
• mewoph moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 10 2021, 8:39 PM
• mewoph updated the task description. (Show Details)Sep 13 2021, 3:54 PM
gerritbot added a comment.Sep 14 2021, 3:41 AM

Change 720392 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Create StructuredTaskToolbarDialog

https://gerrit.wikimedia.org/r/720392

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.1; 2021-09-21).Sep 14 2021, 4:00 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 14 2021, 4:10 AM
Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 14 2021, 5:28 AM
Tgr subscribed.

Moving to QA but not testable without T290907: Add an image: create skeleton for inspector.

Etonkovidova closed this task as Resolved.Oct 27 2021, 12:24 AM
Etonkovidova subscribed.

Marking as Resolved - checked in betalabs.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits