[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T285940

Template parameter search: partial match blocks adding undocumented parameter
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  • insert a new template with visual editor
  • use the add more information element to insert a documented parameter ("Foo") and an undocumented parameter ("Test")
  • delete both
  • try to insert the undocumented one again

What happens?:
The documented parameter "Foo" is being highlighted (beause it contains "Test" in the description) and it is not possible to create an undocumented parameter "tes" (click to view screencast).

Peek 2021-07-01 11-54.gif (754×991 px, 503 KB)

What should have happened instead?:
The matching parameter "Test" should appear at the top and it should allow adding a new undocumented parameter "tes".

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

Details

SubjectRepoBranchLines +/-
Fix parameter search being to relaxed on unknown paramsmediawiki/extensions/VisualEditormaster+44 -5
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedWMDE-FischT306967 Deploy VE template dialog improvements to enwiki
 ResolvedLena_WMDET296759 Deploy VE template dialog improvements to more wikis
 ResolvedLena_WMDET286992 Deploy VE template dialog improvements to small set of wikis
 ResolvedWMDE-FischT272487 New input for undocumented parameters
 ResolvedWMDE-FischT272482 Show/hide advanced toolbar when multi-part content is present
 ResolvedECohen_WMDET272368 Add checkboxes to param list sidebar in VE TemplateDialog
 ResolvedWMDE-FischT274542 Fork / subclass / include variations in BookletLayout for new VisualEditor template dialog
 ResolvedawightT274539 Implement new VisualEditor template dialog enhanced sidebar feature flag
 DeclinedNoneT274541 Adapt VisualEditor template dialog code to reduce duplication after fork
 ResolvedNoneT274548 VisualEditor template "required" parameter handling
 InvalidNoneT274549 Handle "no parameter" templates
 ResolvedthiemowmdeT274551 "deprecated" parameter handling
 Resolvedlilients_WMDET274552 Synchronize scroll and focus between content and outline panes
 InvalidNoneT274546 Maintain order of checkboxes and content
 ResolvedthiemowmdeT288202 Parameter search also filters main content area
 ResolvedAndrew-WMDET274554 Make sidebar responsive
 ResolvedAndrew-WMDET275761 Remove the trash icons which show next to the parameter name when it's "in focus"
 ResolvedNoneT274547 Handle checkbox clicks in VisualEditor template dialog sidebar
 ResolvedNoneT272481 Add parameter search to sidebar of VE TemplateDialog
 ResolvedAndrew-WMDET274550 Handle undocumented template parameters
 ResolvedWMDE-FischT274545 Wire template parameters into the checkbox list view
 ResolvedLena_WMDET274538 Design new VisualEditor template dialog data model and data propagation
 ResolvedNoneT276325 Review proof-of-concept VE template dialog sidebar code
 ResolvedawightT274543 Create a new checkbox list view for the VisualEditor template dialog
 ResolvedAndrew-WMDET285044 Fix parameter sidebar overflowing text ellipsis
 InvalidNoneT285289 Sidebar containers should receive initial parameters through regular add events
 ResolvedthiemowmdeT285382 Preserve parameter serialization order
 ResolvedawightT216808 VE shuffles the order of template parameters in template dialog
 ResolvedBUG REPORTthiemowmdeT285940 Template parameter search: partial match blocks adding undocumented parameter
 ResolvedBUG REPORTthiemowmdeT286715 Sidebars overlap after adding undocumented parameters
 ResolvedWMDE-FischT286765 Prepare sidebar feature for deploy on beta and deploy on beta
 DuplicateBUG REPORTNoneT287384 Pathological duplicate aliases could be displayed in sidebar menu
 ResolvedECohen_WMDET285869 Add error handling for the undocumented parameter input
 InvalidNoneT291059 [DRAFT] Adjust messages for special alias edge cases

Event Timeline

lilients_WMDE created this task.Jul 1 2021, 12:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 1 2021, 12:07 PM
lilients_WMDE updated the task description. (Show Details)Jul 1 2021, 12:19 PM
lilients_WMDE updated the task description. (Show Details)Jul 1 2021, 12:23 PM
gerritbot added a comment.Jul 1 2021, 12:28 PM

Change 702643 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] [POC] Fix parameter search being to relaxed on unknown params

https://gerrit.wikimedia.org/r/702643

gerritbot added a project: Patch-For-Review.Jul 1 2021, 12:28 PM
lilients_WMDE added a parent task: T272481: Add parameter search to sidebar of VE TemplateDialog.Jul 1 2021, 12:34 PM
thiemowmde renamed this task from Search input field patches wrong parameter to Template parameter search: partial match blocks adding undocumented parameter.Jul 1 2021, 12:35 PM
thiemowmde subscribed.
lilients_WMDE assigned this task to thiemowmde.Jul 1 2021, 12:36 PM
lilients_WMDE moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2021-06-23 board.
lilients_WMDE added a subscriber: WMDE-TechWish.
lilients_WMDE mentioned this in T272481: Add parameter search to sidebar of VE TemplateDialog.Jul 1 2021, 12:51 PM
matmarex moved this task from To Triage to Triaged on the VisualEditor board.Jul 1 2021, 2:54 PM
WMDE-Fisch merged a task: T98065: When adding unknown template, impossible to add parameter '2', if parameter '2=' has been added.Jul 1 2021, 6:28 PM
WMDE-Fisch added a subscriber: Josve05a.
WMDE-Fisch set the point value for this task to 2.Jul 2 2021, 7:30 AM
WMDE-Fisch added a project: Unplanned-Sprint-Work.
gerritbot added a comment.Jul 2 2021, 3:47 PM

Change 702643 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix parameter search being to relaxed on unknown params

https://gerrit.wikimedia.org/r/702643

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.14; 2021-07-12).Jul 2 2021, 4:00 PM
WMDE-Fisch moved this task from Doing to Demo on the WMDE-TechWish-Sprint-2021-06-23 board.Jul 2 2021, 4:01 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 2 2021, 4:10 PM
WMDE-Fisch mentioned this in T98065: When adding unknown template, impossible to add parameter '2', if parameter '2=' has been added.Jul 5 2021, 8:04 AM
WMDE-Fisch moved this task from Backlog to In sprint on the WMDE-Templates-FocusArea board.Jul 5 2021, 8:10 AM
WMDE-Fisch subscribed.Jul 6 2021, 11:26 AM

To better surface the now always present result at the top of the suggestion, that let's you add an undocumented parameter, we decided to set change the style of the descriptive text underneath Unknown field by putting it into parenthesis and formatting it italic.

WMDE-Fisch closed this task as Resolved.Jul 6 2021, 11:39 AM
WMDE-Fisch mentioned this in T286236: Change style for adding an `Unknown field` in the parameter search.
WMDE-Fisch moved this task from Demo to Done on the WMDE-TechWish-Sprint-2021-06-23 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits