[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T283275

Make MW master tests pass on PHP 8.0
Closed, ResolvedPublic
Actions

Description

See also: T292847: Make MW 1.37 tests pass on PHP 8.0, T283208: Make MW 1.36 tests pass on PHP 8.0, T274966: Make MW 1.35 tests pass on PHP 8.0; possibly some overlap...

But CI won't run due to older versions of elasticsearch libraries that don't support PHP 8.0 :(

19:42:31   Problem 1
19:42:31     - elasticsearch/elasticsearch v6.5.1 requires php ^7.0 -> your PHP version (8.0.5) does not satisfy that requirement.
19:42:31     - elasticsearch/elasticsearch v6.5.1 requires php ^7.0 -> your PHP version (8.0.5) does not satisfy that requirement.
19:42:31     - elasticsearch/elasticsearch v6.5.1 requires php ^7.0 -> your PHP version (8.0.5) does not satisfy that requirement.
19:42:31     - Installation request for elasticsearch/elasticsearch 6.5.1 -> satisfiable by elasticsearch/elasticsearch[v6.5.1].

Details

SubjectRepoBranchLines +/-
Fix PHP 8.0 failure of WikiExporterFactoryTestmediawiki/coremaster+10 -3
MapCacheLRU: Restore key type checksmediawiki/coremaster+22 -16
MapCacheLRU: Restore key type checksmediawiki/coreREL1_37+22 -16
Fix PHP 8.0 failure of RefreshSecondaryDataUpdateTestmediawiki/coreREL1_37+2 -2
Fix PHP 8.0 failure of RefreshSecondaryDataUpdateTestmediawiki/coremaster+2 -2
Fix PHP 8.0 failure of WikiExporterFactoryTestmediawiki/coreREL1_37+2 -2
Fix PHP 8.0 failure of WikiExporterFactoryTestmediawiki/coreREL1_35+2 -2
Fix PHP 8.0 failure of WikiExporterFactoryTestmediawiki/coreREL1_36+2 -2
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT248925 Make MediaWiki release tarball compatible with PHP 8.0
 ResolvedJdforrester-WMFT300463 Make PHP 8.0 voting on MW master
 ResolvedNoneT283275 Make MW master tests pass on PHP 8.0
 ResolvedEBernhardsonT271777 Bump rufin/elastica (and related libraries) to versions that support PHP 8.0
 ResolvedGehelT263142 [EPIC] Upgrade Elasticsearch to version 7.10
 ResolvedEBernhardsonT218994 Deprecation warning on elasticsearch 6
ResolvedEBernhardsonT218995 re-enable deprecation warning logger on elasticsearch once issues are solved
 ResolveddcausseT219265 Elasticsearch 6: _retry_on_conflict is deprecated
 ResolveddcausseT219266 Elasticsearch 6 nested_path and nested_filter are deprecated
 ResolveddcausseT219267 Elasticsearch 6: auto_generate_phrase_queries is deprecated and ineffective
 ResolveddcausseT219268 Elasticsearch 6: the classic similarity is deprecated
 ResolveddcausseT219533 Reindex space less languages wikis to use BM25
 OpenNoneT219534 Test MLR models for zhwiki, jawiki and kowiki
 ResolvedEBernhardsonT219269 Elasticsearch 6: silence deprecation warnings to avoid logspam
 DuplicateNoneT215615 Stop using negative scores for deboosting statements
 ResolvedEBernhardsonT288764 Set include_type_name in all get requests
 Resolved• EJosephT288765 Always provide minimum_should_match in bool queries
 ResolvedEBernhardsonT306123 Ensure mjolnir models have positive scores
 DuplicateNoneT273814 Create ElasticSearch 7.10 image in releng/dev-images
 ResolvedGehelT295666 Upgrade Cirrus elasticsearch clusters to 6.8.23
 Resolved• EJosephT294499 Upgrade Cirrus elasticsearch plugins to 6.8.23
 ResolvedbkingT301954 Upgrade deployment-prep to elasticsearch 6.8.23
 ResolvedbkingT301955 Upgrade relforge to elasticsearch 6.8.23
 ResolvedRKemperT278378 Pull Elasticsearch config out of Spicerack
 ResolvedRKemperT301956 Upgrade cloudelastic to elasticsearch 6.8.23
 ResolvedRKemperT301958 Upgrade Search elasticsearch cluster / codfw to elasticsearch 6.8.23
 ResolvedRKemperT301959 Upgrade Search elasticsearch cluster / eqiad to elasticsearch 6.8.23
 ResolvedGehelT304570 elasticsearch: make rolling upgrade proceed to second host after shards are stable
 ResolvedbkingT289135 Upgrade Cirrus Elasticsearch clusters to Debian Bullseye
 ResolvedbkingT299797 Deploy new bullseye elastic cluster nodes on deployment-prep
 ResolvedbkingT301408 Enable search team SRE access to deployment-prep VMs
 ResolvedbkingT307510 Update tls proxy config for Bullseye
 ResolvedbkingT308770 Reimage relforge elastic hosts from Stretch to Bullseye
 ResolvedbkingT309343 Upgrade cloudelastic clusters to Debian Bullseye
 ResolvedbkingT312298 Update NIC firmware on all Elastic PowerEdge R440 elastic hosts
 ResolvedEBernhardsonT295736 Evaluate deployed elasticsearch plugins for 7.10 compatability
 ResolvedEBernhardsonT295734 Bring up two copies of the CirrusSearch browser integration env in cloud
 ResolvedTJonesT300302 Test Elastic 6.8 language analyzers
 Resolved• ZbyszkoT300833 Address "Log4shell" vulnerability in Elasticsearch 7.10.2
 DeclinedNoneT301724 Sunset ApiFeatureUsage
 DeclinedNoneT302638 Sunset ApiFeatureUsage (TDMP)
 ResolvedTJonesT301131 Test Elastic 7.10 language analyzers
 ResolvedEBernhardsonT317200 Reindex all wikis to fix nnbsp regression
 DeclinedNoneT303443 Ensure that all applications depending on the Search Elasticsearch cluster are compatible with Elasticsearch 7.10
 Resolvedbd808T303444 Ensure Toolhub is compatible with Elasticsearch 7.10
 DeclinedNoneT303445 Ensure Phabricator is compatible with Elasticsearch 7.10
 ResolvedEBernhardsonT304290 Create docker elasticsearch images with wmf search plugins
 DeclinedNoneT304569 Remove row/rack awareness in Elasticsearch config
 ResolveddcausseT305428 Upgrade the Translate TTM Elasticsearch implementation to elasticsearch 6.8 and onwards
ResolvedEBernhardsonT306644 re-run wbsearchentities optimization process
ResolvedEBernhardsonT307931 Run CirrusSearch test suite against Elasticsearch 7.10
 ResolvedEBernhardsonT308676 Elasticsearch 7.10.2 rollout plan
 ResolvedbkingT315604 Upgrade relforge cluster to 7.10.2
 ResolvedGehelT316159 Upgrade cloudelastic cluster to 7.10.2
 ResolvedGehelT316240 Upgrade deployment-prep to Elasticsearch 7.10.2
 ResolvedRKemperT316719 Upgrade codfw cluster to Elasticsearch 7.10.2
 ResolvedBUG REPORTEBernhardsonT317381 Reduction in helpfulness and quantity of autocomplete search results
 ResolvedEBernhardsonT317374 Search now caps total results count at 10k because of elasticsearch 7 upgrade
 ResolvedRKemperT317686 Upgrade eqiad cluster to Elasticsearch 7.10.2
 ResolvedEBernhardsonT313434 Migrate apifeatureusage to elasticsearch 7
 ResolvedkostajhT317513 Flow is incompatible with Elastica - Remove ElasticSearch integration / Flow search

Event Timeline

Reedy created this task.May 20 2021, 6:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2021, 6:45 PM
Jdforrester-WMF added a subtask: T271777: Bump rufin/elastica (and related libraries) to versions that support PHP 8.0.May 20 2021, 6:54 PM
Jdforrester-WMF moved this task from Backlog to MediaWiki core on the PHP 8.0 support board.Aug 19 2021, 11:24 PM
William_Cheselden mentioned this in T248925: Make MediaWiki release tarball compatible with PHP 8.0.Sep 10 2021, 6:03 PM
Reedy changed the status of subtask T271777: Bump rufin/elastica (and related libraries) to versions that support PHP 8.0 from Stalled to Open.Oct 8 2021, 2:36 PM
Reedy changed the status of subtask T271777: Bump rufin/elastica (and related libraries) to versions that support PHP 8.0 from Open to Stalled.Dec 17 2021, 4:52 PM
gerritbot added a comment.Jan 21 2022, 4:23 AM

Change 755844 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] Fix PHP 8.0 failure of RefreshSecondaryDataUpdateTest

https://gerrit.wikimedia.org/r/755844

gerritbot added a project: Patch-For-Review.Jan 21 2022, 4:23 AM

Change 755845 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] Fix PHP 8.0 failure of WikiExporterFactoryTest

https://gerrit.wikimedia.org/r/755845

gerritbot added a comment.Jan 21 2022, 4:23 AM

Change 755846 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] MapCacheLRU: Restore key type checks

https://gerrit.wikimedia.org/r/755846

tstarling subscribed.Jan 21 2022, 4:29 AM

Composer works now, following gerrit 748168. All core tests pass for me after my changes above and the one linked to T268847.

gerritbot added a comment.Jan 21 2022, 10:01 AM

Change 755934 had a related patch set uploaded (by Reedy; author: Tim Starling):

[mediawiki/core@REL1_37] Fix PHP 8.0 failure of RefreshSecondaryDataUpdateTest

https://gerrit.wikimedia.org/r/755934

gerritbot added a comment.Jan 21 2022, 10:01 AM

Change 755935 had a related patch set uploaded (by Reedy; author: Tim Starling):

[mediawiki/core@REL1_37] Fix PHP 8.0 failure of WikiExporterFactoryTest

https://gerrit.wikimedia.org/r/755935

gerritbot added a comment.Jan 21 2022, 10:03 AM

Change 755937 had a related patch set uploaded (by Reedy; author: Tim Starling):

[mediawiki/core@REL1_36] Fix PHP 8.0 failure of WikiExporterFactoryTest

https://gerrit.wikimedia.org/r/755937

gerritbot added a comment.Jan 21 2022, 10:03 AM

Change 755938 had a related patch set uploaded (by Reedy; author: Tim Starling):

[mediawiki/core@REL1_35] Fix PHP 8.0 failure of WikiExporterFactoryTest

https://gerrit.wikimedia.org/r/755938

gerritbot added a comment.Jan 21 2022, 10:06 AM

Change 755943 had a related patch set uploaded (by Reedy; author: Tim Starling):

[mediawiki/core@REL1_37] MapCacheLRU: Restore key type checks

https://gerrit.wikimedia.org/r/755943

gerritbot added a comment.Jan 21 2022, 10:06 AM

Change 755844 merged by jenkins-bot:

[mediawiki/core@master] Fix PHP 8.0 failure of RefreshSecondaryDataUpdateTest

https://gerrit.wikimedia.org/r/755844

gerritbot added a comment.Jan 21 2022, 10:09 AM

Change 755845 merged by jenkins-bot:

[mediawiki/core@master] Fix PHP 8.0 failure of WikiExporterFactoryTest

https://gerrit.wikimedia.org/r/755845

gerritbot added a comment.Jan 21 2022, 10:14 AM

Change 755846 merged by jenkins-bot:

[mediawiki/core@master] MapCacheLRU: Restore key type checks

https://gerrit.wikimedia.org/r/755846

gerritbot added a comment.Jan 21 2022, 10:23 AM

Change 755938 merged by jenkins-bot:

[mediawiki/core@REL1_35] Fix PHP 8.0 failure of WikiExporterFactoryTest

https://gerrit.wikimedia.org/r/755938

gerritbot added a comment.Jan 21 2022, 10:25 AM

Change 755937 merged by jenkins-bot:

[mediawiki/core@REL1_36] Fix PHP 8.0 failure of WikiExporterFactoryTest

https://gerrit.wikimedia.org/r/755937

gerritbot added a comment.Jan 21 2022, 10:26 AM

Change 755934 merged by jenkins-bot:

[mediawiki/core@REL1_37] Fix PHP 8.0 failure of RefreshSecondaryDataUpdateTest

https://gerrit.wikimedia.org/r/755934

gerritbot added a comment.Jan 21 2022, 10:27 AM

Change 755935 merged by jenkins-bot:

[mediawiki/core@REL1_37] Fix PHP 8.0 failure of WikiExporterFactoryTest

https://gerrit.wikimedia.org/r/755935

gerritbot added a comment.Jan 21 2022, 10:27 AM

Change 755943 merged by jenkins-bot:

[mediawiki/core@REL1_37] MapCacheLRU: Restore key type checks

https://gerrit.wikimedia.org/r/755943

Reedy updated the task description. (Show Details)Jan 21 2022, 10:33 AM
Reedy mentioned this in T292847: Make MW 1.37 tests pass on PHP 8.0.Jan 21 2022, 10:57 AM
Reedy mentioned this in T283208: Make MW 1.36 tests pass on PHP 8.0.
ReleaseTaggerBot added projects: MW-1.38-notes (1.38.0-wmf.19; 2022-01-24), MW-1.36-notes, MW-1.35-notes, MW-1.37-notes.Jan 21 2022, 11:00 AM
Reedy removed a project: Patch-For-Review.Jan 29 2022, 5:03 PM
Reedy added a parent task: T300463: Make PHP 8.0 voting on MW master.Jan 30 2022, 5:20 PM
dcausse changed the status of subtask T271777: Bump rufin/elastica (and related libraries) to versions that support PHP 8.0 from Stalled to Open.May 18 2022, 6:41 PM
Reedy mentioned this in T312971: Enable PHP 8 CI for ProofreadPage.Jul 21 2022, 8:13 PM
Reedy mentioned this in T300463: Make PHP 8.0 voting on MW master.Jul 21 2022, 10:45 PM
Jdforrester-WMF closed subtask T271777: Bump rufin/elastica (and related libraries) to versions that support PHP 8.0 as Resolved.Aug 30 2022, 9:20 PM
Bawolff subscribed.Sep 21 2022, 8:24 AM

So this is passing now on master, at least for the "composer" version of tests.

Not sure if this should remain open for the "vendor" version of these tests or not.

Jdforrester-WMF subscribed.Sep 21 2022, 11:12 AM
In T283275#8249823, @Bawolff wrote:

So this is passing now on master, at least for the "composer" version of tests.

Not sure if this should remain open for the "vendor" version of these tests or not.

I was planning to keep it open until the full suite is running, yes.

Jdforrester-WMF closed this task as Resolved.Sep 30 2022, 2:06 AM

Now resolved for core. Great work, all!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits