[go: up one dir, main page]

Page MenuHomePhabricator

Optimize designs for smaller screens
Closed, ResolvedPublic

Description

User story (by Jazmin Tanner)

As an Android app user with a small screen
I want an image recommendations experience optimize for me.

Related task: T278455.

Proposed solution

Variant A: A draggable bottom sheet. Per @cooltey’s comment in T280151#7010946 , this is now possible and the preferred way.

CollapsedExpanded
add-images-08-pulled-down-and-read-more@2x.png (1×720 px, 216 KB)
add-images-08@2x.png (1×720 px, 426 KB)
ZeplinZeplin

Variant B: Leave out Suggestion reason and truncate both filename and image caption.

Variant C: Leave out Image caption and only show Filename and Suggestion reason.

Variant D: Remove bottom sheet and add image suggestion card right below the article (inline), truncate the article’s text at ~ 3 or 4 lines, but keep Yes, No, Not sure answers sticky. Check out this prototype to see how it behaves.

Optional in Variant B and C: Reduce height of image canvas (dp value to be defined with engineers).

Event Timeline

@JTannerWMF @Dbrant added two variants to save space on smaller screens.

LGoto triaged this task as Medium priority.Apr 15 2021, 3:52 PM
LGoto removed a project: Epic.
scblr updated the task description. (Show Details)
scblr updated the task description. (Show Details)

Added Variant C to the task’s description, check it out @JTannerWMF 👋 (the prototype illustrates it best)

Hi @schoenbaechler

I found a way to implement the draggable bottom sheet, please see the demo here:
https://www.youtube.com/watch?v=-W7C0RVwg7E

We can also adjust the "peek" height, which in the demo is around 24dp. Please let me know how you think, and probably we don't need to change our layout for small screen devices.

For small screen devices, you may notice that the article title sometime is fully covered. We may need to update the tooltip to indicate the bottom sheet is draggable.

Checked out the branch @cooltey It works really well!! We only need to adjust the peek height as some fraction of the screen height and we are all set1 Great work @cooltey !! 👏🏼 👏🏼

Hey @cooltey — this is great! Honestly — I’m really happy and impressed that you investigated this further and independently... it’s a major win for the product 👏

I think we should adjust the peek height so users will see that there’s an image at the bottom — like this:

Cheers!

Since we are going with the draggable bottom sheet, @schoenbaechler can we please move this to doing and assign it to @cooltey ?

scblr renamed this task from Create designs for small screens to Optimize designs for smaller screens.Apr 20 2021, 8:53 AM
scblr reassigned this task from scblr to cooltey.
scblr updated the task description. (Show Details)

@Sharvaniharan, makes sense // done 👍

In T280151#7013574, @schoenbaechler wrote:

Hey @cooltey — this is great! Honestly — I’m really happy and impressed that you investigated this further and independently... it’s a major win for the product 👏

I think we should adjust the peek height so users will see that there’s an image at the bottom — like this:

Cheers!

Hi @schoenbaechler
Is this default that the bottom sheet is collapsed when viewing a new article? The reason why I ask because sometimes the bottom sheet will fully cover the article content on small screen devices.

Hi @schoenbaechler

As we discussed on Slack, I have made the following changes:

  1. Make the buttons as parts of the bottom sheet instead of in a fixed layout on the bottom.
  2. Only collapse the bottom sheet when the article title is overlapped.

@cooltey — this is perfect! I noticed you incorporated zooming too? WOOOOOW! — what can I say! It feels like this interaction model ist absolutely ideal for this. Peek size is perfect too.

Minor feedback: Sometimes the zoom gesture triggers a tap on the card, see the video below:

https://www.dropbox.com/s/rvvlrozod0e5wez/video-triggers-tap-new.mp4?dl=0

Any chance to optimze it?

Other than that! AMAZING!

Yes and done. Please check it on the latest image recommendation branch.

Yes and done. Please check it on the latest image recommendation branch.

It’s just perfect! 🤩