[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T279094

Support for parser functions using "isHTML"?
Open, MediumPublic
Actions

Description

Esoteric flags like "isHTML" don't fly with Parsoid

https://github.com/wikimedia/mediawiki/blob/master/includes/parser/Parser.php#L4895

Currently, Parsoid expects parser functions to return wikitext during preprocessing. However, the presence of this "isHTML" flag means that some parser functions return html that the legacy parser armours for them. That's what is happening in T257344

Maybe they should do something that's more aware of the $parser->getOutputType()? That's what the patch in T257344 tries to do so that only wikitext is return when preprocessing.

Something to be aware of when designing Parsoid's setFunctionHook in T268144

Details

SubjectRepoBranchLines +/-
Parsoid DataAccess: support strip state in parser function resultsmediawiki/coremaster+62 -10
Bump wikimedia/parsoid to 0.21.0-a5mediawiki/vendormaster+2 K -353
Introduce fragment types and APImediawiki/services/parsoidmaster+1 K -226
[DNM]: Use special strip markers for HTML from parser functionsmediawiki/coremaster+4 -3
Return an extension tag when preprocessing a parser functionmediawiki/extensions/CategoryTreemaster+8 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Arlolra created this task.Apr 1 2021, 6:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 1 2021, 6:22 PM
Arlolra triaged this task as Medium priority.Apr 1 2021, 6:23 PM
Arlolra moved this task from Needs Triage to Missing Functionality on the Parsoid board.
gerritbot added a comment.Apr 1 2021, 6:25 PM

Change 676436 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/CategoryTree@master] Help Parsoid out by returning an ext tag when preprocessing

https://gerrit.wikimedia.org/r/676436

gerritbot added a project: Patch-For-Review.Apr 1 2021, 6:25 PM
gerritbot added a comment.Apr 4 2021, 2:32 PM

Change 676436 merged by jenkins-bot:

[mediawiki/extensions/CategoryTree@master] Return an extension tag when preprocessing a parser function

https://gerrit.wikimedia.org/r/676436

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.38; 2021-04-06).Apr 4 2021, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 4 2021, 3:10 PM
Arlolra mentioned this in T289545: Parsoid doesn't respect strip state markers found in preprocessor output.Aug 24 2021, 2:42 PM
matmarex mentioned this in T317112: Phonos does not display correctly in Visual Editor.Sep 6 2022, 10:50 PM
MusikAnimal mentioned this in rEPHN26cb40e430bf: Use tag instead of a parser function.Sep 7 2022, 8:35 AM
• JMcLeod_WMF added a project: Parsoid-Read-Views.Feb 23 2023, 4:36 PM
• JMcLeod_WMF moved this task from Uncategorized to Phase 1 - DiscussionTools support on the Parsoid-Read-Views board.Mar 2 2023, 3:19 PM
• JMcLeod_WMF edited projects, added Parsoid-Read-Views (Phase 1 - DiscussionTools support); removed Parsoid-Read-Views.
ssastry subscribed.Mar 29 2023, 11:09 PM

Looks like for wikimedia deployments, there are only 2 extensions that are impacted. CategoryTree (which Arlo has fixed up above) and WikimediaIncubator which needs fixing.

But, outside WMF, this feature is used heavily! So, the question is if we should try to fix this now OR after WMF switches over and we build Parsoid support for parser functions.

ssastry added a comment.Mar 29 2023, 11:15 PM

I did look into what is involved in fixing this. This will require a patch to Parser.php's insertStripItem to distinguish HTML strip items from others which is easy -- we can recover the isHTML flag from there.. It will also require us to change the DataAccess interface to pass through the 'isHTML' property all the way to TemplateHandler where we would need to wrap the output in a DocumentFragment, etc. just like ExtensionHandler.

Not too hard and doable.

But it may bew worth postponing this to post read views once we fix up WikimediaIncubator Extension as well. That extension is only used on incubatorwiki.

ssastry added a comment.Mar 29 2023, 11:31 PM

The infopage parser function which depends on this doesn't seem to be used as far as I can tell. So, for now, we can competely deprioritize this work till read views work on the wikimedia cluster is complete.

ssastry edited projects, added Parsoid-Read-Views; removed Parsoid-Read-Views (Phase 1 - DiscussionTools support).Mar 29 2023, 11:32 PM
gerritbot added a comment.Mar 30 2023, 9:10 PM

Change 904628 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/core@master] [DNM]: Use special strip markers for HTML from parser functions

https://gerrit.wikimedia.org/r/904628

gerritbot added a project: Patch-For-Review.Mar 30 2023, 9:10 PM

Change 904628 abandoned by Subramanya Sastry:

[mediawiki/core@master] [DNM]: Use special strip markers for HTML from parser functions

Reason:

https://gerrit.wikimedia.org/r/904628

Maintenance_bot removed a project: Patch-For-Review.Mar 30 2023, 9:30 PM
MSantos moved this task from Uncategorized to Phase 5: (Later) on the Parsoid-Read-Views board.Apr 13 2023, 2:22 PM
ssastry merged a task: T289545: Parsoid doesn't respect strip state markers found in preprocessor output.Apr 13 2023, 5:25 PM
ssastry merged a task: T178588: Handle parser functions returning raw html.
ssastry mentioned this in T178588: Handle parser functions returning raw html.
ssastry added a subscriber: cscott.
ssastry added subscribers: Liuxinyu970226, ArloJamesBarnes.
Arlolra mentioned this in T318060: Scary transcluding a Wikipedia page with inline math renders that inline math incorrectly.Jan 11 2024, 1:56 AM
cscott added a comment.Sep 6 2024, 5:19 PM

My current plan for this is outlined at T257606#9216083

cscott mentioned this in T374661: Charts are not compatible with Parsoid - show as raw SVG.Sep 26 2024, 7:36 PM
aude subscribed.Oct 9 2024, 1:08 AM
cscott added a parent task: T374661: Charts are not compatible with Parsoid - show as raw SVG.Mon, Oct 21, 3:04 PM
cscott added a subtask: T373255: Define the wikifunctions API that Parsoid needs.
CCiufo-WMF added subscribers: MSantos, CCiufo-WMF.Tue, Nov 5, 9:27 PM

Hey @cscott, has there been any progress on this? T374661 is a blocker to rolling out Charts to pilot wikis, which we are hoping to do before the end of November. If you don't think this can be done by then, we might need to come up with a workaround.

cscott mentioned this in T200704: TemplateStyles don't work when the template is inside a link.Thu, Nov 7, 8:24 PM
gerritbot added a comment.Thu, Nov 7, 8:57 PM

Change #1088365 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Parsoid DataAccess: support strip state in parser function results

https://gerrit.wikimedia.org/r/1088365

gerritbot added a project: Patch-For-Review.Thu, Nov 7, 8:57 PM
gerritbot added a comment.Thu, Nov 7, 9:00 PM

Change #821282 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/services/parsoid@master] WIP: Fragment types and strip state

https://gerrit.wikimedia.org/r/821282

Seddon added a project: Charts.Tue, Nov 12, 9:43 PM
CCiufo-WMF moved this task from Backlog to Tracking on the Charts board.Tue, Nov 12, 9:43 PM
gerritbot added a comment.Tue, Nov 12, 9:53 PM

Change #821282 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Introduce fragment types and API

https://gerrit.wikimedia.org/r/821282

gerritbot added a comment.Fri, Nov 15, 4:52 PM

Change #1091769 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.21.0-a5

https://gerrit.wikimedia.org/r/1091769

cscott claimed this task.Fri, Nov 15, 5:27 PM
gerritbot added a comment.Fri, Nov 15, 5:40 PM

Change #1091769 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.21.0-a5

https://gerrit.wikimedia.org/r/1091769

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits