| scblr | |
| Mar 26 2021, 10:41 AM |
| F34388637: Screenshot_20210414-124650.png | |
| Apr 14 2021, 10:50 AM |
| F34388635: Screenshot_20210414-124057.png | |
| Apr 14 2021, 10:50 AM |
| F34276291: Screen Shot 2021-04-07 at 9.40.25 AM.png | |
| Apr 7 2021, 4:40 PM |
| F34212282: add-images-04.png | |
| Apr 2 2021, 10:27 AM |
| F34212288: add-images-04-dark.png | |
| Apr 2 2021, 10:27 AM |
| F34212280: add-images-03.png | |
| Apr 2 2021, 10:27 AM |
| F34212286: add-images-02-dark.png | |
| Apr 2 2021, 10:27 AM |
| F34191660: Screenshot_20210326-113803.png | |
| Mar 26 2021, 10:41 AM |
Currently, the onboarding illustrations are not created to be used for various themes.
Apply the following, revised, illustrations:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | JTannerWMF | T272872 [EPIC] Image Recommendations Android MVP | |||
| Resolved | Sharvaniharan | T278526 Improve 'Train image algorithm' onboarding illustrations for different themes |
Hi @schoenbaechler... as we discussed on the call, the images are not rendering properly.. I see the same problem with dark mode image too... this is how it is getting rendered:[ignore the light background]
@Sharvaniharan — I updated the illustrations (Light+Sepia, Dark+Black) on Zeplin. Let me know if it works!
One more thing @Sharvaniharan — realized that we should align text and image vertically at the bottom in all onboarding dialogs in order to be consistent with other places of the app. Updated the designs accordingly.
@schoenbaechler Please review from here: https://github.com/wikimedia/apps-android-wikipedia/pull/2133/checks
Other than the text align oter things should work. I will keep this ticket in design review till I align the text..
@schoenbaechler I did not understand the text alignment fully... we might need to talk tomorrow .. heads-up.
Thanks @Sharvaniharan — this is what I was referring to:
Please vertically align the onboarding dialogs to the bottom not top.