| dom_walden | |
| Nov 30 2020, 10:39 AM |
| F35010826: T268981_reproduce.png | |
| Mar 18 2022, 8:52 AM |
| F34913163: ar_icon_not_hidden.png | |
| Jan 10 2022, 2:44 PM |
| F34913161: ar_icon_hidden.png | |
| Jan 10 2022, 2:44 PM |
| F34910553: screenshot.png | |
| Jan 7 2022, 4:02 PM |
| F34886646: Screenshot 2021-12-16 at 10.16.18 PM.png | |
| Dec 16 2021, 4:48 PM |
| F34886644: Screenshot 2021-12-16 at 10.16.13 PM.png | |
| Dec 16 2021, 4:48 PM |
| F34683649: 20211011_07 30 25_firefox_93.png | |
| Oct 11 2021, 7:34 AM |
| F33928866: dotted_lines_jump.png | |
| Nov 30 2020, 10:39 AM |
When using the IPInfo popup on the history of an article can cause the dotted lines which mark selected revisions to jump (see screenshot).
I have only reproduced this on Firefox (not Chrome, Edge or Safari).
Browser: Firefox 78 and 83.
Wiki(s): MediaWiki 1.36.0-alpha (ed5d593), IP Info 0.0.0 (9fc96a6).
@dom_walden We discussed this and we're also unaware if it's still an issue. Would you have time to confirm this bug for us as well please?
Yes. I have just checked. It looks slightly different from the last time I saw this:
Reproduced on https://en.wikipedia.beta.wmflabs.org IP Info 0.0.0 (109c072) 07:21, 8 October 2021 with Firefox 93, going to page https://en.wikipedia.beta.wmflabs.org/wiki/0.04961315198485505?action=history.
I'm testing this on Firefox 95 and I can't see a difference between this and what's happening on Chrome. @Prtksxna Can you spot what I'm supposed to fix?
Testing on FF92 and then FF95 on MacOS I can see the dashed line on top move a few pixels up is open:
| Normal | With popup |
There seems to be an issue with the overflow CSS property. I'm able to remove that by setting it to hidden, but that also removes the bullet points from the left, which we want to keep. This is only happening in FF and changing overflow in Chrome doesn't seem to affect anything at all.
I also changed the font sizes and other height/width values. Those did not seem to move the outline around at all. Moving this to stuck as I'm not sure where to proceed. I've reached out to #front-end to see if anyone has experience/knowledge of this and will pick up another ticket in the meantime.
Thanks @wikitrent. Looks like this can be fixed by setting overflow: hidden on the button itself (rather than on the list item):
We can do that in ipinfo.less - could you tag a patch against this task?
Change 752159 had a related patch set uploaded (by Wikitrent; author: Wikitrent):
[mediawiki/extensions/IPInfo@master] WIP: Fix FF dotted lines
Change 752159 merged by jenkins-bot:
[mediawiki/extensions/IPInfo@master] Fix Firefox outline styling in history pages
I notice on https://ar.wikipedia.beta.wmflabs.org, I think this change chops off the bottom of the icon (ar and arz use a different icon.)
With overflow: hidden:
Without:
@Prtksxna @Niharika Do we mind? Perhaps we should change it so all languages use the same icon (if this is even possible).
I feel like we've seen this icon changing bug before but I can't find it anywhere.
Yep we should have the same icon (and no clipping) everywhere, I've raised T298942: Fix clipping of icon for IPInfo popups when language is set to ar [S]. Thanks @dom_walden!
I can reproduce this again after T301938. Therefore, I will reopen this bug.
For example, go to https://en.wikipedia.beta.wmflabs.org/wiki/Barack_Obama_T173949?action=history and click the first IPInfo popup.
Test environment: IP Info 0.0.0 (500d7c1) 07:44, 18 March 2022.
Test browser: Firefox 91.
I can reproduce this again after T301938. Therefore, I will reopen this bug.
For example, go to https://en.wikipedia.beta.wmflabs.org/wiki/Barack_Obama_T173949?action=history and click the first IPInfo popup.
Test environment: IP Info 0.0.0 (500d7c1) 07:44, 18 March 2022.
Test browser: Firefox 91.
Thanks I have uploaded a patch for this https://gerrit.wikimedia.org/r/c/mediawiki/extensions/IPInfo/+/771840
This patch brings back the code that was used to fix this patch initially, it then fixes the problem we were hoping to fix by removing the mentioned code.
Thanks. In that case, I am going to move this into the code review column of this sprint.
Change 771840 had a related patch set uploaded (by Tchanders; author: TsepoThoabala):
[mediawiki/extensions/IPInfo@master] Dotted lines on revision history jumps when opening popup
Change 771840 merged by jenkins-bot:
[mediawiki/extensions/IPInfo@master] Dotted lines on revision history jumps when opening popup
I cannot reproduce this bug anymore.
I repeated the testing I did in T301938#7788171, but only for Firefox 91 and Chromium 87 (and I didn't test Arabic).
Test Environment: https://en.wikipedia.beta.wmflabs.org IP Info 0.0.0 (cb5558d) 07:14, 21 March 2022.