[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T267329

Add Link engineering: Output format for link recommendation format
Closed, ResolvedPublic
Actions

Description

As discussed in T261411, we want the link recommendation output to be a list of items (JSON serialized), each item has the following properties:

  • phrase_to_link (text)
  • context_before (text -- 5 characters of text that occur before the phrase to link)
  • context_after (text -- 5 characters of text that occur after the phrase to link)
  • link_target (text)
  • instance_occurrence (integer) -- number showing how many times the phrase to link appears in the wikitext before we arrive at the one to link
  • probability (boolean)
  • insertion_order (integer) -- order in which to insert the link on the page (e.g. recommendation "foo" [0] comes before recommendation "bar baz" [1], which comes before recommendation "bar" [2], etc)

Details

SubjectRepoBranchLines +/-
Follow mwaddlink output changesmediawiki/extensions/GrowthExperimentsmaster+48 -48
Small changes to output formatresearch/mwaddlinkmain+30 -34
Update API output formatresearch/mwaddlinkmain+45 -9
Customize query in gerrit

Related Objects
Search...

Event Timeline

kostajh created this task.Nov 5 2020, 2:43 PM
kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 23 2020, 2:29 PM
Tgr added a comment.Dec 16 2020, 10:51 AM

Do we still want context_before / context_after now that we are not planning to switch the service to Parsoid? Due to filtering in mwaddlink, phrase_to_link won't include wikimarkup, but the before/after segment might so I'm not sure how useful it is for matching against Parsoid DOM.

gerritbot added a comment.Dec 18 2020, 10:07 AM

Change 650467 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[research/mwaddlink@main] Update API output format

https://gerrit.wikimedia.org/r/650467

gerritbot added a project: Patch-For-Review.Dec 18 2020, 10:07 AM
Tgr claimed this task.Dec 18 2020, 10:18 AM
Tgr moved this task from Ready for Development to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
Tgr added a comment.Dec 27 2020, 8:50 PM

What do you think about using link_text instead of phrase_to_link and score instead of probability? Those feel like more standard names to me (although the current ones are also easy to understand).

I find the meaning of instance_occurrence and insertion_order hard to remember (especially wrt whether they are 0-based or 1-based). I don't have any great alternative, but maybe something like match_index and link_index (0-based)?

kostajh added a comment.Jan 4 2021, 10:15 AM
In T267329#6712591, @Tgr wrote:

What do you think about using link_text instead of phrase_to_link and score instead of probability? Those feel like more standard names to me (although the current ones are also easy to understand).

Sounds good to me.

I find the meaning of instance_occurrence and insertion_order hard to remember (especially wrt whether they are 0-based or 1-based). I don't have any great alternative, but maybe something like match_index and link_index (0-based)?

That seems fine to me also.

• Catrope mentioned this in T271124: Add a link engineering: deal with word boundaries (\b) being broken in JS.Jan 4 2021, 5:09 PM
gerritbot added a comment.Jan 4 2021, 7:49 PM

Change 650467 merged by jenkins-bot:
[research/mwaddlink@main] Update API output format

https://gerrit.wikimedia.org/r/650467

Maintenance_bot removed a project: Patch-For-Review.Jan 4 2021, 8:10 PM
kostajh closed this task as Resolved.Jan 18 2021, 4:00 PM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Feb 6 2021, 10:29 PM

Change 662092 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[research/mwaddlink@main] Small changes to output format

https://gerrit.wikimedia.org/r/662092

gerritbot added a project: Patch-For-Review.Feb 6 2021, 10:29 PM
gerritbot added a comment.Feb 6 2021, 11:11 PM

Change 662094 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Follow mwaddlink output changes

https://gerrit.wikimedia.org/r/662094

Tgr reopened this task as Open.Feb 6 2021, 11:12 PM
Tgr moved this task from QA to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Reopening for the last round of format changes.

gerritbot added a comment.Feb 7 2021, 8:00 PM

Change 662092 merged by jenkins-bot:
[research/mwaddlink@main] Small changes to output format

https://gerrit.wikimedia.org/r/662092

gerritbot added a comment.Feb 7 2021, 9:01 PM

Change 662094 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Follow mwaddlink output changes

https://gerrit.wikimedia.org/r/662094

Maintenance_bot removed a project: Patch-For-Review.Feb 7 2021, 9:10 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.30; 2021-02-09).Feb 7 2021, 10:00 PM
Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Feb 8 2021, 9:52 AM

Not sure if this is worth QA testing but I'll leave that for someone else to decide.

kostajh closed this task as Resolved.Feb 16 2021, 12:07 PM
kostajh mentioned this in T278487: Instrumentation: Number of phrases not found in document.Mar 25 2021, 8:40 PM
Isaac mentioned this in T331401: Design event schema for ML scores/recommendations on current page state.Mar 7 2023, 3:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits