[go: up one dir, main page]

Page MenuHomePhabricator

Make Kartographer extension compatible with Parsoid
Closed, ResolvedPublic

Description

Parsoid has its own extension API - see https://www.mediawiki.org/wiki/Parsoid/Extension_API.

The Kartographer extension needs an update to work directly with Parsoid so that we can switch Wikimedia wikis to use Parsoid instead of core parser in late 2021.

The Parsing Team will work with you as required.

Details

SubjectRepoBranchLines +/-
mediawiki/extensions/Kartographermaster+28 -26
mediawiki/extensions/Kartographermaster+54 -23
mediawiki/extensions/Kartographermaster+97 -83
mediawiki/extensions/Kartographermaster+175 -34
mediawiki/extensions/Kartographermaster+5 -2
mediawiki/extensions/Kartographermaster+658 -18
mediawiki/extensions/Kartographermaster+6 -3
mediawiki/extensions/Kartographermaster+18 -7
mediawiki/extensions/Kartographermaster+29 -18
mediawiki/extensions/Kartographermaster+2 -2
mediawiki/extensions/Kartographermaster+24 -2
mediawiki/extensions/Kartographermaster+107 -104
mediawiki/extensions/Kartographermaster+14 -13
mediawiki/extensions/Kartographermaster+13 -28
mediawiki/extensions/Kartographermaster+13 -11
mediawiki/extensions/Kartographermaster+45 -0
mediawiki/extensions/Kartographermaster+27 -42
mediawiki/extensions/Kartographermaster+20 -22
mediawiki/extensions/Kartographermaster+51 -13
mediawiki/extensions/Kartographermaster+229 -18
mediawiki/extensions/Kartographermaster+212 -129
mediawiki/extensions/Kartographermaster+103 -100
mediawiki/extensions/Kartographermaster+34 -8
mediawiki/extensions/Kartographermaster+92 -0
mediawiki/extensions/Kartographermaster+2 -1
mediawiki/extensions/Kartographermaster+45 -10
mediawiki/extensions/Kartographermaster+23 -33
mediawiki/extensions/Kartographermaster+123 -46
mediawiki/vendormaster+1 K -795
mediawiki/services/parsoidmaster+122 -2
mediawiki/extensions/Kartographermaster+51 -64
mediawiki/extensions/Kartographermaster+77 -77
mediawiki/extensions/Kartographermaster+12 -12
mediawiki/extensions/Kartographermaster+450 -342
mediawiki/extensions/Kartographermaster+1 K -726
mediawiki/extensions/Kartographermaster+297 -232
mediawiki/extensions/Kartographermaster+22 -23
mediawiki/extensions/Kartographermaster+16 -16
mediawiki/extensions/Kartographermaster+19 -10
mediawiki/extensions/Kartographermaster+8 -7
mediawiki/extensions/Kartographermaster+24 -10
mediawiki/extensions/Kartographermaster+96 -50
mediawiki/extensions/Kartographermaster+333 -316
mediawiki/extensions/Kartographermaster+64 -29
Show related patches Customize query in gerrit

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 884958 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Make getText/Int/Float return null instead of useless `false`

https://gerrit.wikimedia.org/r/884958

Change 884958 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Make getText/Int/Float return null instead of useless `false`

https://gerrit.wikimedia.org/r/884958

Change 886339 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Skip parsing empty and auto-generated maplink labels

https://gerrit.wikimedia.org/r/886339

Change 886394 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Extract common data from tags to their own class

https://gerrit.wikimedia.org/r/886394

JMcLeod_WMF raised the priority of this task from Low to High.Feb 6 2023, 4:25 PM

Change 880975 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Extract argument parsing into small, neutral service

https://gerrit.wikimedia.org/r/880975

Change 887396 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Rename confusing getText to getString

https://gerrit.wikimedia.org/r/887396

Change 883862 abandoned by Isabelle Hurbain-Palatin:

[mediawiki/extensions/Kartographer@master] [WIP] Refactor tags to extract the parser-specific logic

Reason:

Abandoned in favor of 880975 and other following patches.

https://gerrit.wikimedia.org/r/883862

Change 886394 abandoned by Isabelle Hurbain-Palatin:

[mediawiki/extensions/Kartographer@master] Extract common data from tags to their own class

Reason:

Abandoned in favor of 880975 and other following patches.

https://gerrit.wikimedia.org/r/886394

Change 887396 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Rename confusing getText to getString

https://gerrit.wikimedia.org/r/887396

Change 884917 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Add strict types to properties and parameters where possible

https://gerrit.wikimedia.org/r/884917

Change 888684 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/services/parsoid@master] Add methods to enable "arbitrary language" for i18n

https://gerrit.wikimedia.org/r/888684

Change 889184 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Make CoordFormatter compatible with Parsoid

https://gerrit.wikimedia.org/r/889184

Change 880974 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Remove knowledge about specific tag names from State class

https://gerrit.wikimedia.org/r/880974

Change 888684 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Add methods to enable "arbitrary language" for i18n

https://gerrit.wikimedia.org/r/888684

Change 890498 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a17

https://gerrit.wikimedia.org/r/890498

Change 890498 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a17

https://gerrit.wikimedia.org/r/890498

Change 891334 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Avoid some bits of code duplication in CoordFormatter

https://gerrit.wikimedia.org/r/891334

Change 889184 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Make CoordFormatter compatible with Parsoid

https://gerrit.wikimedia.org/r/889184

Change 891334 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Avoid some bits of code duplication in CoordFormatter

https://gerrit.wikimedia.org/r/891334

Change 881003 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Use tiny PartialWikitextParser service instead of full Parser

https://gerrit.wikimedia.org/r/881003

Change 886339 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Skip parsing empty and auto-generated maplink labels

https://gerrit.wikimedia.org/r/886339

Change 900387 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Make updateMarkerSymbolCounters data update optional

https://gerrit.wikimedia.org/r/900387

Change 900402 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Export internationalized fragment creation to ParsoidUtils class

https://gerrit.wikimedia.org/r/900402

Change 901143 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Replace MapLinkTrait by MapLinkAttributeGenerator

https://gerrit.wikimedia.org/r/901143

Change 901252 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Introduce MapFrameAttributeGenerator

https://gerrit.wikimedia.org/r/901252

Change 900387 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Make updateMarkerSymbolCounters data update optional

https://gerrit.wikimedia.org/r/900387

Change 900402 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Export internationalized fragment creation to ParsoidUtils class

https://gerrit.wikimedia.org/r/900402

Change 901143 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Replace MapLinkTrait by MapLinkAttributeGenerator

https://gerrit.wikimedia.org/r/901143

Change 903312 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Add a Parsoid skeleton

https://gerrit.wikimedia.org/r/903312

Change 904491 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Introduce ParsoidWikitextParser

https://gerrit.wikimedia.org/r/904491

Change 904554 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Move some MapFrameAttributeGenerator code to more local places

https://gerrit.wikimedia.org/r/904554

Change 904566 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Inline all $static… MapFrameAttributeGenerator properties

https://gerrit.wikimedia.org/r/904566

Change 904568 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Introduce small getContainerClasses helper method

https://gerrit.wikimedia.org/r/904568

Change 901252 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Introduce MapFrameAttributeGenerator

https://gerrit.wikimedia.org/r/901252

Change 903312 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Add a Parsoid skeleton

https://gerrit.wikimedia.org/r/903312

Change 904491 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Introduce ParsoidWikitextParser

https://gerrit.wikimedia.org/r/904491

Change 904554 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Move some MapFrameAttributeGenerator code to more local places

https://gerrit.wikimedia.org/r/904554

Change 904566 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Inline all $static… MapFrameAttributeGenerator properties

https://gerrit.wikimedia.org/r/904566

Change 905199 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Move $geometries in the MapTagArgumentValidator

https://gerrit.wikimedia.org/r/905199

Change 905566 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Add Parsoid-specific aliases to Phan configuration

https://gerrit.wikimedia.org/r/905566

Change 905566 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Add Parsoid-specific aliases to Phan configuration

https://gerrit.wikimedia.org/r/905566

Change 904568 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Introduce small getContainerClasses helper method

https://gerrit.wikimedia.org/r/904568

Change 905199 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Inline/rearrange parsing of geometries in LegacyTagHandler

https://gerrit.wikimedia.org/r/905199

Change 905689 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] [WIP] [DNM] parsoid compat

https://gerrit.wikimedia.org/r/905689

Change 923286 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Use page language rather than user language

https://gerrit.wikimedia.org/r/923286

Change 923287 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Minor adjustments pre-Parsoid patch

https://gerrit.wikimedia.org/r/923287

Change 923288 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Fix extTag parser option

https://gerrit.wikimedia.org/r/923288

Change 923340 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Make constants in MapFrameAttributeGenerator private again

https://gerrit.wikimedia.org/r/923340

Change 923347 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Mark more MapLinkAttributeGenerator properties as not nullable

https://gerrit.wikimedia.org/r/923347

Change 923347 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Mark more MapLinkAttributeGenerator properties as not nullable

https://gerrit.wikimedia.org/r/923347

Change 923286 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Use page language rather than user language

https://gerrit.wikimedia.org/r/923286

Change 923287 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Minor adjustments pre-Parsoid patch

https://gerrit.wikimedia.org/r/923287

Change 923288 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Fix extTag parser option

https://gerrit.wikimedia.org/r/923288

Change 923340 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Make constants in MapFrameAttributeGenerator private again

https://gerrit.wikimedia.org/r/923340

Change 932221 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Extract image URL parameters into its own method

https://gerrit.wikimedia.org/r/932221

Change 932235 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Add a feature flag for Parsoid support deployment

https://gerrit.wikimedia.org/r/932235

Change 932249 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Rework MapFrameAttributeGenerator test to not test private stuff

https://gerrit.wikimedia.org/r/932249

Change 932221 merged by Isabelle Hurbain-Palatin:

[mediawiki/extensions/Kartographer@master] Extract image URL parameters into its own method

https://gerrit.wikimedia.org/r/932221

Change 932249 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Rework MapFrameAttributeGenerator test to not test private stuff

https://gerrit.wikimedia.org/r/932249

Change 936292 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Add extension data and categories to Parsoid output

https://gerrit.wikimedia.org/r/936292

Change 938883 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Extract processKartographerNode method

https://gerrit.wikimedia.org/r/938883

Change 905689 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Parsoid support for Kartographer version 1.0.0

https://gerrit.wikimedia.org/r/905689

Change 939351 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] [WIP] maplink in attribute support

https://gerrit.wikimedia.org/r/939351

Change 941389 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Add CSP header to Parsoid output

https://gerrit.wikimedia.org/r/941389

Change 941389 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Add CSP header to Parsoid output

https://gerrit.wikimedia.org/r/941389

Change 936292 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Add extension data, categories and attribute processing to Parsoid output

https://gerrit.wikimedia.org/r/936292

Change 938883 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Extract processKartographerNode method

https://gerrit.wikimedia.org/r/938883

MSantos lowered the priority of this task from High to Medium.Sep 19 2023, 4:05 PM

Kartographer has been deployed on enwiki, enwikibooks, enwikinews, enwikiquote, enwikisource, enwikiversity, enwikivoyage and enwiktionary. This issue can be closed; further deployments will be tracked by T342871 once T342876 is resolved.

Change #1028830 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Move TitleFormatter dependency to ParserContext

https://gerrit.wikimedia.org/r/1028830

Change #883846 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Decouple core parser from the MapLink/MapFrame implementations

https://gerrit.wikimedia.org/r/883846

Change #1028830 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Move TitleFormatter dependency to ParserContext

https://gerrit.wikimedia.org/r/1028830