- Open Mobile VE
- Make a change
- Try to close the editor with the toolbar button
- When you are warned you will lose your changes, choose to not close the editor
- Notice that the URL has changed even though you didn't close the editor
- Try again to close the editor again and nothing happens (or you get a system warning because it's trying to go back to the previous page)
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Don't navigate back immediately when trying to teardown | mediawiki/extensions/VisualEditor | master | +2 -2 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | ppelberg | T263472 [TRACKING] VE navigation issues when cancelling a close | |||
| Resolved | Esanders | T247171 Pressing close ('x') on VE mobile, then pressing "continue editing", results in wrong URL |
Event Timeline
Comment Actions
How common an issue do you think this is @Esanders ? How did you encounter this issue? Based on what you arrive at we will prioritize this task.
Comment Actions
Probably related to this, if the editor fails to load for any reason, the page navigates back to wherever you were before you loaded the article.
Comment Actions
Change 628860 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Don't navigate back immediately when trying to teardown
Comment Actions
The above patch fixes the functionality of the close button in the toolbar, but it does not fix the browser back button. To fix that we will need to make fixes in MF to push the recently-popped state, as history.back can't be cancelled (along the lines of what was done in T263464).
Comment Actions
Change 628860 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Don't navigate back immediately when trying to teardown