[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T243708

Mediawiki core needs uses of global $wgUser removed
Open, MediumPublic
Actions

Description

This task deals with reducing the references to wgUser in core.
See the parent task for deprecating and removing it entirely

Codesearch: https://codesearch.wmcloud.org/core/?q=wgUser(%5B%3B%2C%27%22-%5D%7C%5Cs%7C%24)&i=nope&files=%5C.php%24&repos=

Details

SubjectRepoBranchLines +/-
Reduce direct writes to $wgUsermediawiki/coremaster+17 -7
LanguageConverter: stop reading from $wgUsermediawiki/coremaster+10 -9
MessageCache: stop reading from $wgUsermediawiki/coremaster+4 -5
TableCleanup: stop writing to $wgUsermediawiki/coremaster+0 -6
UploadFromUrl: Remove use of $wgUser in isValidRequestmediawiki/coremaster+2 -2
ApiBase: update outdated comment about canApiHighLimitsmediawiki/coremaster+1 -1
DumpTestCase - stop writing to $wgUsermediawiki/coremaster+1 -4
LanguageConverterTest: reduce direct references to $wgUsermediawiki/coremaster+18 -20
cleanupSpam: pass a user when editing a pagemediawiki/coremaster+8 -5
Reduce some references to $wgUsermediawiki/coremaster+8 -4
Reduce some direct references to $wgUsermediawiki/coremaster+16 -4
EditPageTest: No need to set $wgUsermediawiki/coremaster+0 -3
CheckBlocksSecondaryAuthenticationProviderTest: No need to set $wgUsermediawiki/coremaster+0 -1
UserTest: No need to set $wgUsermediawiki/coremaster+0 -1
Language::translateBlockExpiry update $user docsmediawiki/coremaster+2 -2
cleanupSpam - reduce direct references to $wgUsermediawiki/coremaster+1 -1
Reduce use of $wgUser in EditPageTestmediawiki/coremaster+5 -4
Remove use of $wgUser from LogFormatterTest, unneededmediawiki/coremaster+0 -1
Remove User::addNewUserLogEntrymediawiki/coremaster+1 -24
RequestContextTest: No need to set $wgUsermediawiki/coremaster+0 -1
Remove use of $wgUser in ApiUserrightsTestmediawiki/coremaster+3 -3
Remove uses of $wgUser in api token methodsmediawiki/coremaster+80 -96
ApiLogoutTest: Remove use of global $wgUsermediawiki/coremaster+22 -23
Mark token methods in query apis as internalmediawiki/coremaster+13 -0
Reduce direct uses of $wgUser in ApiQueryInfo's token methodsmediawiki/coremaster+41 -64
Reduce further direct references to $wgUsermediawiki/coremaster+7 -5
maintenance scripts: Reduce direct references to $wgUsermediawiki/coremaster+33 -26
ParserOptionsTest: Rename non-global variable `$wgUser`mediawiki/coremaster+4 -5
LanguageConverterTest: Reduce direct references to $wgUsermediawiki/coremaster+56 -41
WikiPageDbTestBase: Remove use of global $wgUsermediawiki/coremaster+1 -3
Tests: Remove unneeded uses of global $wgUsermediawiki/coremaster+0 -11
Add a user parameter to LanguageConverter::getUserVariantmediawiki/coremaster+11 -12
ImageBuilder: Update to LocalFile::recordUpload2, pass a usermediawiki/coremaster+10 -6
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.21; 2020-02-25); removed MW-1.35-notes (1.35.0-wmf.20; 2020-02-18).Feb 19 2020, 9:00 PM
DannyS712 removed a project: Patch-For-Review.Feb 19 2020, 10:27 PM
DannyS712 closed subtask T244602: Linker::userToolLinks uses $wgUser as Resolved.Feb 20 2020, 7:19 AM
DannyS712 added a comment.EditedFeb 22 2020, 1:18 AM

Status update for all mentions of $wgUser in core (checked means nothing more to do for 1.35)

  • AjaxResponse::checkLastModified uses $wgUser, not as a fallback -> T245800
  • FileDeleteForm::__construct falls back to $wgUser -> not passing a user is hard deprecated, see T245233, T245581
  • FileDeleteForm::doDelete falls back to $wgUser -> not passing a user is hard deprecated, see T245682, T245802, T245801
  • GlobalFunctions - just a comment
  • OutputPage - comments
  • Revision (lots) - entire class is soft deprecated
  • Setup - only use is setting $wgUser
  • Title::userCan falls back to $wgUser -> entire function is harddeprecated, see T244923
  • Title::quickUserCan falls back to $wgUser -> entire function is hard deprecated, see T244927
  • Title::getNotificationTimestamp falls back to $wgUser -> not passing a user is hard deprecated, see T245702
  • Title::moveSubpages - was hard deprecated, removed, see T245483
  • WebRequest::getLimitOffset uses $wgUser -> hard deprecated, see T243805, T245779, T245777
  • ApiMain::__construct - writes to $wgUser
  • ApiQuery(Info|RecentChanges|Revisions|Users) - lots, see T245329
  • GenderCache::getGenderOff
  • MessageCache::getParserOptions (made private to simplify further changes, see T247189)
  • RecentChange::markPatrolled falls back to $wgUser - entire function should be hard deprecated, see T245195
  • RequestContext::importScopedSession - writes to $wgUser
  • LocalFile::recordUpload - entire function should be hard deprecated
  • LocalFile::recordUpload2 falls back to $wgUser
  • LocalFileDeleteBatch::__construct falls back to $wgUser - see T245710
  • Installer::__construct - writes to $wgUser
  • DoubleRedirectJob - writes to $wgUser
  • Linker::userToolLinks - reads from $wgUser, use removed, see T244602
  • LogEventsList::typeAction - uses $wgUser
  • LogEventsList::userCan(Bitfield|ViewLogType)? - falls back to $wgUser, not passing a user is hard deprecated, see T245704
  • LogEventsList::getExcludeClause
  • LogPage::addEntry - falls back to $wgUser, not passing a user is hard deprecated, see T243652, T245701
  • PatrolLog::record - falls back to $wgUser, not passing a user is hard deprecated, see T245707
  • Article - comment
  • PageArchive::undelete - falls back to $wgUser
  • WikiPage::doEditContent - falls back to $wgUser, entire function is soft deprecated
  • WikiPage::prepareContentForEdit - falls back to $wgUser, entire function is soft deprecated
  • WikiPage::insertProtectNullRevision - falls back to $wgUser (in Revision::newNullRevision), not passing a user is hard deprecated, see T245705
  • WikiPage::doDeleteArticleReal - falls back to $wgUser
  • Parser - comment
  • ParserOptions::__construct
  • SessionProvider - comment
  • LoginSignupSpecialPage - writes to $wgUser
  • SpecialPageFactory - writes to $wgUser
  • (deprecated, old) SpecialPageFactory - should all be hard deprecated, see T245686
  • UploadFromUrl::isValidRequest
  • UploadStash::__construct falls back to $wgUser
  • User - comments
  • Language::userAdjust and ::dateFormat
  • LanguageConverter::getPreferredVariant
  • maintenance scripts writing to wgUser: cleanupSpam, deleteBatch, deleteDefaultMessages, deleteEqualMessages, edit, importImages, importSiteScripts, moveBatch, preprocessorFuzzTest, undelete

Tests

  • ParserTestRunner::perTestSetup writes to $wgUser
  • MediaWikiIntegrationTestCase
  • EditPageTest
  • RevisionDbTestBase (will be removed in T246411)
  • RevisionTest
  • ApiLogoutTest
  • ApiMainTest
  • ApiTestCase lots (::doLogin is hard deprecated, see T244039, T245332, T245355)
  • ApiUserrightsTest
  • CheckBlocksSecondaryAuthenticationProviderTest
  • CssContentTest
  • TextContentTest
  • RequestContextTest
  • ConverterRuleTest
  • LogFormatterTest
  • WikiPageDbTestBase
  • ParserOptionsTest
  • UploadStashTest
  • UserTest
  • LanguageConverterTest
  • DumpTestCase
• Pchelolo closed subtask T241557: Replace $wgUser in core Api modules as Resolved.Feb 25 2020, 4:43 PM
• Pchelolo reopened subtask T241557: Replace $wgUser in core Api modules as Open.Feb 25 2020, 4:50 PM
DannyS712 closed subtask T245800: AjaxResponse::checkLastModified uses $wgUser as Resolved.Mar 1 2020, 7:00 AM
gerritbot added a comment.Mar 3 2020, 6:53 AM

Change 576194 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] UploadFromUrl: Remove redundant check of user perms in isValidRequest

https://gerrit.wikimedia.org/r/576194

gerritbot added a project: Patch-For-Review.Mar 3 2020, 6:53 AM
gerritbot added a comment.Mar 12 2020, 12:52 AM

Change 579097 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Tests: Remove unneeded uses of global $wgUser

https://gerrit.wikimedia.org/r/579097

gerritbot added a comment.Mar 13 2020, 4:46 AM

Change 579097 merged by jenkins-bot:
[mediawiki/core@master] Tests: Remove unneeded uses of global $wgUser

https://gerrit.wikimedia.org/r/579097

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.24; 2020-03-17); removed MW-1.35-notes (1.35.0-wmf.21; 2020-02-25).Mar 13 2020, 5:00 AM
DannyS712 closed subtask T247189: MessageCache::getParserOptions should be private as Resolved.Mar 13 2020, 5:33 AM
gerritbot added a comment.Mar 14 2020, 9:02 PM

Change 579799 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Don't declare global $wgUser unless needed

https://gerrit.wikimedia.org/r/579799

gerritbot added a comment.Mar 15 2020, 10:34 PM

Change 579799 merged by jenkins-bot:
[mediawiki/core@master] WikiPageDbTestBase: Remove use of global $wgUser

https://gerrit.wikimedia.org/r/579799

gerritbot added a comment.Mar 17 2020, 2:37 AM

Change 580160 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] ApiLogoutTest: Remove use of global $wgUser

https://gerrit.wikimedia.org/r/580160

DannyS712 closed subtask T241557: Replace $wgUser in core Api modules as Declined.Mar 18 2020, 10:21 PM
DannyS712 closed subtask T245329: Hard deprecate deprecated api token hooks as Resolved.Mar 23 2020, 5:10 AM
DannyS712 added a project: Epic.Mar 27 2020, 12:07 AM
DannyS712 mentioned this in T200631: Document the version in which things were hard-deprecated (as well as soft-deprecated) to make it easier to figure out when stuff can be removed.Apr 11 2020, 1:06 AM
gerritbot added a comment.Apr 12 2020, 6:21 PM

Change 588161 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] LanguageConverterTest: Reduce direct references to $wgUser

https://gerrit.wikimedia.org/r/588161

gerritbot added a comment.Apr 13 2020, 3:47 PM

Change 588161 merged by jenkins-bot:
[mediawiki/core@master] LanguageConverterTest: Reduce direct references to $wgUser

https://gerrit.wikimedia.org/r/588161

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.28; 2020-04-14); removed MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Apr 13 2020, 4:00 PM
gerritbot added a comment.Apr 29 2020, 5:30 PM

Change 593279 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] ParserOptionsTest: Rename non-global variable $wgUser

https://gerrit.wikimedia.org/r/593279

gerritbot added a comment.Apr 29 2020, 5:51 PM

Change 593279 merged by jenkins-bot:
[mediawiki/core@master] ParserOptionsTest: Rename non-global variable $wgUser

https://gerrit.wikimedia.org/r/593279

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.31; 2020-05-05); removed MW-1.35-notes (1.35.0-wmf.28; 2020-04-14).Apr 29 2020, 6:00 PM
DannyS712 moved this task from In progress to Projects on the User-DannyS712 board.May 11 2020, 7:13 PM
gerritbot added a comment.Jun 5 2020, 1:37 AM

Change 602540 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] maintenance scripts: Reduce direct references to $wgUser

https://gerrit.wikimedia.org/r/602540

gerritbot added a comment.Jun 5 2020, 2:50 AM

Change 602540 merged by jenkins-bot:
[mediawiki/core@master] maintenance scripts: Reduce direct references to $wgUser

https://gerrit.wikimedia.org/r/602540

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.36; 2020-06-09); removed MW-1.35-notes (1.35.0-wmf.31; 2020-05-05).Jun 5 2020, 3:00 AM
gerritbot added a comment.Jun 5 2020, 11:04 AM

Change 602654 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Reduce further direct references to $wgUser

https://gerrit.wikimedia.org/r/602654

gerritbot added a comment.Jun 7 2020, 5:32 PM

Change 602654 merged by jenkins-bot:
[mediawiki/core@master] Reduce further direct references to $wgUser

https://gerrit.wikimedia.org/r/602654

gerritbot added a comment.Jun 8 2020, 1:47 AM

Change 603068 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Reduce direct uses of $wgUser in ApiQueryInfo's token methods

https://gerrit.wikimedia.org/r/603068

gerritbot added a comment.Jun 15 2020, 9:43 PM

Change 603068 merged by jenkins-bot:
[mediawiki/core@master] Reduce direct uses of $wgUser in ApiQueryInfo's token methods

https://gerrit.wikimedia.org/r/603068

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.37; 2020-06-16); removed MW-1.35-notes (1.35.0-wmf.36; 2020-06-09).Jun 15 2020, 10:00 PM
DannyS712 closed subtask T246284: Hard deprecate the Revision class as Resolved.Jul 6 2020, 1:58 PM
gerritbot added a comment.Jul 6 2020, 2:07 PM

Change 609632 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Mark token methods in query apis as internal

https://gerrit.wikimedia.org/r/609632

DannyS712 closed subtask T245482: Remove core fallbacks to global $wgUser [1.35] as Resolved.Jul 6 2020, 6:30 PM
gerritbot added a comment.Sep 9 2020, 11:22 PM

Change 609632 abandoned by DannyS712:
[mediawiki/core@master] Mark token methods in query apis as internal

Reason:
since the hooks were removed, users can now be injected

https://gerrit.wikimedia.org/r/609632

gerritbot added a comment.Sep 9 2020, 11:28 PM

Change 626246 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove uses of $wgUser in api token methods

https://gerrit.wikimedia.org/r/626246

gerritbot added a comment.Sep 10 2020, 12:30 AM

Change 580160 merged by jenkins-bot:
[mediawiki/core@master] ApiLogoutTest: Remove use of global $wgUser

https://gerrit.wikimedia.org/r/580160

gerritbot added a comment.Sep 10 2020, 12:56 AM

Change 626246 merged by jenkins-bot:
[mediawiki/core@master] Remove uses of $wgUser in api token methods

https://gerrit.wikimedia.org/r/626246

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.9; 2020-09-15).Sep 10 2020, 1:00 AM
gerritbot added a comment.Sep 13 2020, 11:08 PM

Change 626897 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Reduce use of $wgUser in EditPageTest

https://gerrit.wikimedia.org/r/626897

gerritbot added a comment.Sep 13 2020, 11:11 PM

Change 626898 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove use of $wgUser in ApiUserrightsTest

https://gerrit.wikimedia.org/r/626898

gerritbot added a comment.Sep 13 2020, 11:17 PM

Change 626899 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] RequestContextTest: No need to set $wgUser

https://gerrit.wikimedia.org/r/626899

gerritbot added a comment.Sep 14 2020, 4:46 AM

Change 626898 merged by jenkins-bot:
[mediawiki/core@master] Remove use of $wgUser in ApiUserrightsTest

https://gerrit.wikimedia.org/r/626898

gerritbot added a comment.Sep 14 2020, 5:06 AM

Change 626899 merged by jenkins-bot:
[mediawiki/core@master] RequestContextTest: No need to set $wgUser

https://gerrit.wikimedia.org/r/626899

gerritbot added a comment.Sep 14 2020, 5:39 AM

Change 626905 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove outdated documentation from addNewUserLogEntry

https://gerrit.wikimedia.org/r/626905

gerritbot added a comment.Sep 14 2020, 7:13 PM

Change 626905 merged by jenkins-bot:
[mediawiki/core@master] Remove User::addNewUserLogEntry

https://gerrit.wikimedia.org/r/626905

gerritbot added a comment.Sep 14 2020, 8:25 PM

Change 627219 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove use of $wgUser from LogFormatterTest, unneeded

https://gerrit.wikimedia.org/r/627219

gerritbot added a comment.Sep 14 2020, 9:58 PM

Change 627219 merged by jenkins-bot:
[mediawiki/core@master] Remove use of $wgUser from LogFormatterTest, unneeded

https://gerrit.wikimedia.org/r/627219

gerritbot added a comment.Sep 15 2020, 1:10 AM

Change 626897 merged by jenkins-bot:
[mediawiki/core@master] Reduce use of $wgUser in EditPageTest

https://gerrit.wikimedia.org/r/626897

gerritbot added a comment.Sep 15 2020, 1:49 AM

Change 627225 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] cleanupSpam - reduce direct references to $wgUser

https://gerrit.wikimedia.org/r/627225

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.10; 2020-09-22); removed MW-1.36-notes (1.36.0-wmf.9; 2020-09-15).Sep 15 2020, 2:00 AM
gerritbot added a comment.Sep 15 2020, 2:11 AM

Change 627225 merged by jenkins-bot:
[mediawiki/core@master] cleanupSpam - reduce direct references to $wgUser

https://gerrit.wikimedia.org/r/627225

DannyS712 updated the task description. (Show Details)Sep 15 2020, 3:21 AM
gerritbot added a comment.Sep 15 2020, 9:20 PM

Change 627463 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] CheckBlocksSecondaryAuthenticationProviderTest: No need to set $wgUser

https://gerrit.wikimedia.org/r/627463

gerritbot added a comment.Sep 15 2020, 9:22 PM

Change 627464 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] UserTest: No need to set $wgUser

https://gerrit.wikimedia.org/r/627464

gerritbot added a comment.Sep 15 2020, 9:25 PM

Change 627465 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] EditPageTest: No need to set $wgUser

https://gerrit.wikimedia.org/r/627465

gerritbot added a comment.Sep 15 2020, 9:44 PM

Change 627606 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] LanguageFi::translateBlockExpiry update $user docs

https://gerrit.wikimedia.org/r/627606

gerritbot added a comment.Sep 15 2020, 10:46 PM

Change 627606 merged by jenkins-bot:
[mediawiki/core@master] Language::translateBlockExpiry update $user docs

https://gerrit.wikimedia.org/r/627606

gerritbot added a comment.Sep 15 2020, 10:47 PM

Change 627463 merged by jenkins-bot:
[mediawiki/core@master] CheckBlocksSecondaryAuthenticationProviderTest: No need to set $wgUser

https://gerrit.wikimedia.org/r/627463

gerritbot added a comment.Sep 15 2020, 10:49 PM

Change 627464 merged by jenkins-bot:
[mediawiki/core@master] UserTest: No need to set $wgUser

https://gerrit.wikimedia.org/r/627464

gerritbot added a comment.Sep 15 2020, 10:50 PM

Change 627465 merged by jenkins-bot:
[mediawiki/core@master] EditPageTest: No need to set $wgUser

https://gerrit.wikimedia.org/r/627465

gerritbot added a comment.Sep 25 2020, 5:38 PM

Change 630229 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Reduce some direct references to $wgUser

https://gerrit.wikimedia.org/r/630229

gerritbot added a comment.Sep 25 2020, 6:40 PM

Change 630229 merged by jenkins-bot:
[mediawiki/core@master] Reduce some direct references to $wgUser

https://gerrit.wikimedia.org/r/630229

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.11; 2020-09-29); removed MW-1.36-notes (1.36.0-wmf.10; 2020-09-22).Sep 25 2020, 7:00 PM
gerritbot added a comment.Oct 9 2020, 7:43 PM

Change 633248 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Reduce some references to $wgUser

https://gerrit.wikimedia.org/r/633248

gerritbot added a comment.Nov 9 2020, 2:53 PM

Change 633248 merged by jenkins-bot:
[mediawiki/core@master] Reduce some references to $wgUser

https://gerrit.wikimedia.org/r/633248

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.18; 2020-11-17); removed MW-1.36-notes (1.36.0-wmf.11; 2020-09-29).Nov 9 2020, 3:00 PM
DannyS712 added a parent task: T267861: [GOAL] Emit deprecation warnings reading from $wgUser.Nov 15 2020, 12:24 AM
gerritbot added a comment.Dec 14 2020, 9:13 PM

Change 649392 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] ApiBase: update outdated comment about canApiHighLimits

https://gerrit.wikimedia.org/r/649392

gerritbot added a comment.Dec 14 2020, 9:17 PM

Change 649393 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] cleanupSpam: pass a user when editing a page

https://gerrit.wikimedia.org/r/649393

gerritbot added a comment.Dec 14 2020, 9:22 PM

Change 649395 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] LanguageConverterTest: reduce direct references to $wgUser

https://gerrit.wikimedia.org/r/649395

gerritbot added a comment.Dec 14 2020, 9:28 PM

Change 649396 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] DumpTestCase - stop writing to $wgUser

https://gerrit.wikimedia.org/r/649396

gerritbot added a comment.Dec 15 2020, 4:18 AM

Change 649393 merged by jenkins-bot:
[mediawiki/core@master] cleanupSpam: pass a user when editing a page

https://gerrit.wikimedia.org/r/649393

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.25; 2021-01-05); removed MW-1.36-notes (1.36.0-wmf.18; 2020-11-17).Dec 15 2020, 5:00 AM
gerritbot added a comment.Dec 15 2020, 8:31 PM

Change 649396 merged by jenkins-bot:
[mediawiki/core@master] DumpTestCase - stop writing to $wgUser

https://gerrit.wikimedia.org/r/649396

gerritbot added a comment.Dec 15 2020, 8:31 PM

Change 649395 merged by jenkins-bot:
[mediawiki/core@master] LanguageConverterTest: reduce direct references to $wgUser

https://gerrit.wikimedia.org/r/649395

gerritbot added a comment.Dec 19 2020, 11:24 AM

Change 649392 merged by jenkins-bot:
[mediawiki/core@master] ApiBase: update outdated comment about canApiHighLimits

https://gerrit.wikimedia.org/r/649392

DannyS712 closed subtask T245331: Remove core fallbacks to global $wgUser [1.36] as Resolved.Apr 21 2021, 4:17 AM
gerritbot added a comment.May 21 2021, 3:11 AM

Change 693254 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/core@master] TableCleanup: stop writing to $wgUser

https://gerrit.wikimedia.org/r/693254

gerritbot added a comment.Jun 24 2021, 8:32 AM

Change 701275 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/core@master] MessageCache: stop reading from $wgUser

https://gerrit.wikimedia.org/r/701275

gerritbot added a comment.Jun 24 2021, 8:36 AM

Change 701276 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/core@master] LanguageConverter: stop reading from $wgUser

https://gerrit.wikimedia.org/r/701276

gerritbot added a comment.Jun 24 2021, 8:40 PM

Change 576194 merged by jenkins-bot:

[mediawiki/core@master] UploadFromUrl: Remove use of $wgUser in isValidRequest

https://gerrit.wikimedia.org/r/576194

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.12; 2021-06-28).Jun 24 2021, 9:00 PM
gerritbot added a comment.Jun 28 2021, 4:11 PM

Change 693254 merged by jenkins-bot:

[mediawiki/core@master] TableCleanup: stop writing to $wgUser

https://gerrit.wikimedia.org/r/693254

DannyS712 closed subtask T262707: Remove core fallbacks to global $wgUser [1.37] as Resolved.Jun 29 2021, 1:51 AM
DannyS712 closed subtask T285448: Remove ApiTestCase interaction with $wgUser as Resolved.Jul 13 2021, 10:51 PM
gerritbot added a comment.Jul 14 2021, 5:33 PM

Change 701276 merged by jenkins-bot:

[mediawiki/core@master] LanguageConverter: stop reading from $wgUser

https://gerrit.wikimedia.org/r/701276

gerritbot added a comment.Jul 14 2021, 5:33 PM

Change 701275 merged by jenkins-bot:

[mediawiki/core@master] MessageCache: stop reading from $wgUser

https://gerrit.wikimedia.org/r/701275

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.15; 2021-07-19); removed MW-1.37-notes (1.37.0-wmf.12; 2021-06-28).Jul 14 2021, 6:00 PM
DannyS712 closed subtask T242935: Deprecate core fallbacks to $wgUser as Resolved.May 26 2022, 1:50 AM
gerritbot added a comment.Jun 4 2022, 12:19 AM

Change 802832 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/core@master] Reduce direct writes to $wgUser

https://gerrit.wikimedia.org/r/802832

DannyS712 closed subtask T285731: Remove core fallbacks to global $wgUser [1.39] as Resolved.Jun 4 2022, 12:41 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits