Maniphest T199909

Deploy TemplateStyles everywhere on 2018-08-09
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Deskana
	Jul 18 2018, 1:14 PM

Description

Now that the switch to RemexHtml is complete, there do not seem to be any remaining technical blockers to deploying TemplateStyles everywhere. @CKoerner_WMF, @Tgr and I talked, and we think that TemplateStyles can be turned on everywhere on 9th August 2018, so let's do it!

Details

	Subject	Repo	Branch	Lines +/-
	Enable TemplateStyles everywhere	operations/mediawiki-config	master	+1 -16

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Declined		None	T208761 [Epic] Improve PHPUnit coverage in MobileFrontend to 50%
Resolved		Jdlrobson	T186627 Remove the MobileView API
Declined		None	T173379 Remove mobileview API call for main page
Duplicate		None	T172525 [EPIC] Deprecate MobileView API in MobileFrontend
Resolved		Jdlrobson	T32405 [EPIC] MobileFrontend extension should stop special-casing main page
Duplicate		None	T138449 Throw warning when edits made to a main page which uses special casing
Duplicate		None	T138622 Help community migrate away from legacy Main page special casing
Declined		None	T125920 [EPIC] Future exciting reading web performance endeavours
Resolved		Jdlrobson	T131423 FOUC in section "Recently featured" on mobile Main Page
Duplicate		None	T126137 FOUC for styles applied via MediaWiki:Mobile.css due to bottom-loading
Duplicate		None	T130846 Hat-note FOUC on mobile skin
Open		bwang	T361737 [EPIC] With the current layout, some elements extend beyond the content area and overlap sticky page tools
Duplicate		ovasileva	T66577 Large tables created by editors are not responsive
Resolved		None	T51440 MobileFrontend images shown double-sized in Retina desktop, iOS 7 beta
Open		None	T40848 Security: CSS positioning can be used to break out of the content area
Open		None	T37704 Drop support in wikitext for inline styles
Resolved		TheDJ	T151170 Varying layouts for commons mobile main page
Declined		None	T125257 Infoboxes should take the max. available width of the screen
Invalid		None	T135857 Map points aligned to viewport on mobile
Open	Feature	None	T17075 Per book, category and/or template CSS and JavaScript
Invalid		None	T109152 [EPIC] All templates on wiki should work in mobile
Resolved		TheDJ	T94107 {{hat}} and similar templates on Wikipedia are invisible to mobile web view.
Resolved		TheDJ	T118062 In the mobile frontend, in the list produced by Template:Notelist-ua, efn-ua footnotes appear with numeric labels instead of uppercase-alpha. They appear normal in the text, and in the desktop frontend.
Invalid		None	T120238 Wrong display of certain English Wikipedia portal pages in mobile
Resolved		Izno	T127727 navigational sidebar on mobile, should float on wide screens.
Resolved		TheDJ	T128095 Signpost is not readable on mobile devices
Open		None	T117950 Remove the need for `.noprint`
Resolved		Jdlrobson	T117951 Remove templaters' need for .nomobile and support authoring media queries for templates
Declined		None	T66578 Migrate css rules in hacks.less into templates
Resolved		Tgr	T133410 Deploy TemplateStyles to WMF production
Resolved		Tgr	T199909 Deploy TemplateStyles everywhere on 2018-08-09
Resolved		CKoerner_WMF	T199982 Announce that TemplateStyles is being deployed everywhere with mass messages

Event Timeline

• Deskana created this task.Jul 18 2018, 1:14 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 18 2018, 1:14 PM

Tgr claimed this task.Jul 18 2018, 1:16 PM

Harej awarded a token.Jul 18 2018, 1:18 PM

Kizule awarded a token.Jul 18 2018, 1:39 PM

Kizule mentioned this in T199904: Phabricator log me out when I comment task.Jul 18 2018, 1:42 PM

@Pcoombe
Do you see any issues from fundraising/CentralNotice perspective with deploying TemplateStyles everywhere on 2018-08-09? Thanks!

IKhitron subscribed.Jul 18 2018, 3:26 PM

Aklapper added a project: Wikimedia-Extension-setup.Jul 18 2018, 6:10 PM

gerritbot mentioned this in T189022: Deploy TemplateStyles to zhwiki on 2018-07-19.Jul 18 2018, 7:04 PM

gerritbot mentioned this in T191452: Deploy TemplateStyles on French Wikipedia on 2018-07-19.

RazeSoldier subscribed.Jul 18 2018, 7:39 PM

@ggellerman I don't see any issues. Looking forward to this!

Pcoombe awarded a token.Jul 19 2018, 9:02 AM

BethNaught subscribed.Jul 19 2018, 12:59 PM

@Pcoombe Excellent! Thank you for confirming :)

Tacsipacsi subscribed.Jul 19 2018, 2:53 PM

• ggellerman added a subscriber: Anomie.Jul 19 2018, 4:03 PM

Sakretsu subscribed.Jul 19 2018, 9:03 PM

Izno subscribed.Jul 21 2018, 3:28 PM

AfroThundr3007730 subscribed.Jul 21 2018, 9:21 PM

He7d3r subscribed.Jul 27 2018, 8:40 PM

• Deskana triaged this task as Medium priority.Aug 7 2018, 5:39 PM

• Deskana moved this task from Backlog to Doing on the TemplateStyles board.

@Tgr Are we still prepared to do this? I didn't notice anything on the deployment calendar.

With the largest wikis already opted in, it's not too big a deal, it can be done in a regular SWAT window IMO. I'll add it now.
(BTW I'm taking "everywhere" as all wikis including private etc. - there doesn't seem to be any reason not to do it.)

In T199909#4486100, @Tgr wrote:

With the largest wikis already opted in, it's not too big a deal, it can be done in a regular SWAT window IMO. I'll add it now.

Sounds good. Thanks!

(BTW I'm taking "everywhere" as all wikis including private etc. - there doesn't seem to be any reason not to do it.)

Agreed.

Change 451076 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[operations/mediawiki-config@master] Enable TemplateStyles everywhere

https://gerrit.wikimedia.org/r/451076

gerritbot added a project: Patch-For-Review.Aug 7 2018, 7:02 PM

Change 451076 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable TemplateStyles everywhere

https://gerrit.wikimedia.org/r/451076

Mentioned in SAL (#wikimedia-operations) [2018-08-09T11:07:30Z] <tgr@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:451076|Enable TemplateStyles everywhere (T199909)]] (duration: 00m 58s)

Tgr closed this task as Resolved.Aug 9 2018, 11:19 AM

Tgr added a parent task: T133410: Deploy TemplateStyles to WMF production.

Tgr added a subtask: T199982: Announce that TemplateStyles is being deployed everywhere with mass messages.

• Deskana closed subtask T199982: Announce that TemplateStyles is being deployed everywhere with mass messages as Resolved.Aug 9 2018, 11:39 AM

• Deskana moved this task from Doing to Done on the TemplateStyles board.

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:41 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 16 2020, 6:40 PM