Maniphest T198561

Make "write both, read new" the default MCR migration stage for fresh MediaWiki installs / for CI
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	daniel
	Jul 1 2018, 12:39 PM

Description

MediaWiki 1.32 should support MCR, but still remain backwards compatible. This allows wiki instances to back out of MCR without losing data, and preserves compatibility with any extensions or tools that make direct use of the old schema - specifically, of rev_text_id, rev_content_model, and rev_content_format.

The new default should be:
$wgMultiContentRevisionSchemaMigrationStage = SCHEMA_COMPAT_WRITE_BOTH | SCHEMA_COMPAT_READ_NEW;

With this setting enabled, update.php should convert to the new schema, if that did not previously happen. If update.php detects $wgMultiContentRevisionSchemaMigrationStage = SCHEMA_COMPAT_WRITE_BOTH | SCHEMA_COMPAT_READ_OLD; it should also perform the conversion, if still needed, and issue a warning that $wgMultiContentRevisionSchemaMigrationStage should be changed to ensure forward-compatibility with the next release. If update.php encounters $wgMultiContentRevisionSchemaMigrationStage = SCHEMA_COMPAT_OLD, it should warn that the setting should be changed and update.php should be re-run after that change.

NOTE: we'll want to have this enabled on the live systems for a while before releasing it as the default, see T198308. But we'll want to have this as the default on master / for CI before enabling it on the live systems.

NOTE: $wgMultiContentRevisionSchemaMigrationStage will only have a pre-existing value on wikis that were installed off a snapshot or master, since $wgMultiContentRevisionSchemaMigrationStage did not exist in 1.31.

NOTE: This enables the usage of extra slots. If this new ability is used, and the wiki is then set to only reading the legacy schema, access to any content in the extra slots will be lost.

Details

Subject	Repo	Branch	Lines +/-
Set MCR migration stage to write-both/read-new AGAIN.	mediawiki/core	master	+1 -1
[MCR] Set MCR migration stage to write-both/read-new.	mediawiki/core	master	+70 -20
Consolidate tests for getQueryInfo() and related methods.	mediawiki/core	master	+1 K -1 K
Allow dumps to function with MCR in read-new mode.	mediawiki/core	master	+13 -1
Don't reset name tables between test runs.	mediawiki/core	master	+129 -50
Avoid joins when reading MCR revisions.	mediawiki/core	master	+144 -58

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Assigned	Task
		· · ·
Resolved	daniel	T174044 Deploy MCR storage layer
Resolved	Anomie	T198308 Enable MCR migration stage "write both, read new" on live systems
Resolved	Anomie	T198309 Enable MCR migration stage "write both, read new" on testwiki
Resolved	daniel	T198561 Make "write both, read new" the default MCR migration stage for fresh MediaWiki installs / for CI
Resolved	Anomie	T198563 Make "write both, read old" the default MCR migration stage on master / for CI
Resolved	Anomie	T198311 Enable MCR migration stage "write both, read new" on commons beta.
Resolved	daniel	T201164 Temporarily disable deprecation warnings for code that accesses rev_text_id or the text table directly
		· · ·

Event Timeline

daniel triaged this task as Medium priority.Jul 1 2018, 12:39 PM

daniel created this task.

daniel added a subtask: T198308: Enable MCR migration stage "write both, read new" on live systems.

daniel mentioned this in T198563: Make "write both, read old" the default MCR migration stage on master / for CI.Jul 1 2018, 12:53 PM

daniel removed a subtask: T198308: Enable MCR migration stage "write both, read new" on live systems.

daniel added a parent task: T198308: Enable MCR migration stage "write both, read new" on live systems.

daniel added a subtask: T198311: Enable MCR migration stage "write both, read new" on commons beta..

daniel edited projects, added Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2); removed Multi-Content-Revisions.Jul 1 2018, 12:55 PM

daniel edited projects, added Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1); removed Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2).

daniel edited projects, added Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2); removed Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1).

daniel updated the task description. (Show Details)Jul 2 2018, 3:54 PM

daniel updated the task description. (Show Details)

Dropping off SDC board. Also not MCR directly a deployment task, though it's a soft blocker for enabling "write both, read new" on the live systems: We want this mode enabled in CI before we enabled it on the live systems. To have it enabled in CI, it needs to be the default for new installs. We'd want to have "write both, read new" running on the live system for a while before we make it the default for the MW-1.32 release.

daniel renamed this task from Make "write both, read new" the default MCR migration stage for fresh MediaWiki installs to Make "write both, read new" the default MCR migration stage for fresh MediaWiki installs / for CI.Jul 4 2018, 12:18 PM

daniel updated the task description. (Show Details)

daniel mentioned this in T198308: Enable MCR migration stage "write both, read new" on live systems.

Change 443831 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] [MCR] [DNM] Set MCR migration stage to write-both/read-new.

https://gerrit.wikimedia.org/r/443831

gerritbot added a project: Patch-For-Review.Jul 4 2018, 1:40 PM

Aklapper changed the edit policy from "Custom Policy" to "All Users".Jul 9 2018, 7:40 AM

daniel added a subtask: T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo()..Jul 11 2018, 6:07 PM

CCicalese_WMF moved this task from Inbox to Deployment on the Multi-Content-Revisions board.Jul 13 2018, 3:15 AM

CCicalese_WMF edited projects, added Multi-Content-Revisions (Deployment); removed Multi-Content-Revisions.

CCicalese_WMF moved this task from Deployment to Inbox on the Multi-Content-Revisions board.

CCicalese_WMF edited projects, added Multi-Content-Revisions; removed Multi-Content-Revisions (Deployment).

CCicalese_WMF moved this task from Inbox to Deployment on the Multi-Content-Revisions board.Jul 13 2018, 4:35 PM

CCicalese_WMF edited projects, added Multi-Content-Revisions (Deployment); removed Multi-Content-Revisions.

Anomie closed subtask T198563: Make "write both, read old" the default MCR migration stage on master / for CI as Resolved.Jul 19 2018, 5:45 PM

Anomie closed subtask T198311: Enable MCR migration stage "write both, read new" on commons beta. as Resolved.Jul 25 2018, 5:54 PM

CCicalese_WMF moved this task from Backlog to Ready on the Multi-Content-Revisions (Deployment) board.Jul 27 2018, 11:06 PM

daniel mentioned this in T201164: Temporarily disable deprecation warnings for code that accesses rev_text_id or the text table directly.Aug 3 2018, 11:17 AM

daniel removed a subtask: T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo()..Aug 3 2018, 11:25 AM

daniel mentioned this in T197816: Enable MCR migration stage "write both, read old" on live systems.Aug 22 2018, 12:09 PM

daniel added a parent task: T198309: Enable MCR migration stage "write both, read new" on testwiki.Aug 22 2018, 12:22 PM

Change 454582 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Reset cached name tables between test runs.

https://gerrit.wikimedia.org/r/454582

Change 454584 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Avoid joins when reading MCR revisions.

https://gerrit.wikimedia.org/r/454584

Change 454582 merged by jenkins-bot:
[mediawiki/core@master] Don't reset name tables between test runs.

https://gerrit.wikimedia.org/r/454582

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)).Aug 23 2018, 8:00 PM

Change 454584 merged by jenkins-bot:
[mediawiki/core@master] Avoid joins when reading MCR revisions.

https://gerrit.wikimedia.org/r/454584

daniel closed subtask T201164: Temporarily disable deprecation warnings for code that accesses rev_text_id or the text table directly as Resolved.Aug 29 2018, 4:41 PM

CCicalese_WMF added a parent task: T174044: Deploy MCR storage layer.Aug 29 2018, 5:11 PM

CCicalese_WMF moved this task from Ready to In Progress on the Multi-Content-Revisions (Deployment) board.Aug 29 2018, 8:24 PM

Change 457513 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Consolidate tests for getQueryInfo() and related methods.

https://gerrit.wikimedia.org/r/457513

Change 458785 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Allow dumps to function with MCR in read-new mode.

https://gerrit.wikimedia.org/r/458785

Change 458785 merged by jenkins-bot:
[mediawiki/core@master] Allow dumps to function with MCR in read-new mode.

https://gerrit.wikimedia.org/r/458785

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)); removed MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)).Sep 7 2018, 6:00 PM

daniel moved this task from In Progress to Needs Review on the Multi-Content-Revisions (Deployment) board.Sep 10 2018, 1:31 PM

Change 457513 merged by jenkins-bot:
[mediawiki/core@master] Consolidate tests for getQueryInfo() and related methods.

https://gerrit.wikimedia.org/r/457513

Jdforrester-WMF assigned this task to daniel.Sep 10 2018, 6:46 PM

Change 443831 merged by jenkins-bot:
[mediawiki/core@master] [MCR] Set MCR migration stage to write-both/read-new.

https://gerrit.wikimedia.org/r/443831

daniel closed this task as Resolved.Sep 11 2018, 2:26 PM

daniel moved this task from Needs Review to Done on the Multi-Content-Revisions (Deployment) board.

Reverted by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/459812 to fix T204065: WikibaseLexeme CI broken (database errors).

Change 459830 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] [DNM] Set MCR migration stage to write-both/read-new AGAIN.

https://gerrit.wikimedia.org/r/459830

Jdforrester-WMF mentioned this in T204065: WikibaseLexeme CI broken (database errors).Sep 11 2018, 6:51 PM

Change 459830 merged by jenkins-bot:
[mediawiki/core@master] Set MCR migration stage to write-both/read-new AGAIN.

https://gerrit.wikimedia.org/r/459830