[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T179402

in ULS Event Logging, log the context in which the ULS instance is used
Closed, ResolvedPublic
Actions

Description

Back in 2013 when Event Logging was first added to ULS, ULS was used in very few contexts—interlanguage area (for settings, not for Compact Language Links), personal bar, target language selection in Translate, and hardly anything else. Now in 2017, it is used all over the place: Wikidata, Upload Wizard, Compact Language Links, and other places.

Different contexts have different needs for logging. Last week when I was analyzing the data about failed language name searches (see T178996), I realized that many valid languages are not found because in some contexts they are not supposed to be found. For example in Compact Language Links, when an article is not available in that language. It may still be useful to log this failed search, but it will have to be analyzed differently. In Translate, differentiating Traditional and Simplified Chinese is useful, but not in Compact Language Links. And so on.

So this must be fixed by updating the schemas and the logging code. This will open up curious new possibilities, for example being able to learn for versions of which articles are people searching in their language and failing to find.

Details

SubjectRepoBranchLines +/-
Parse the parameters to no-results-found event as an objectmediawiki/extensions/UniversalLanguageSelectormaster+4 -5
Update jquery.uls from upstreammediawiki/extensions/UniversalLanguageSelectormaster+12 -9
Log the context of the ULS in which no search results were foundmediawiki/extensions/UniversalLanguageSelectormaster+21 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

Amire80 created this task.Oct 31 2017, 3:10 PM
Restricted Application added a project: UniversalLanguageSelector. · View Herald TranscriptOct 31 2017, 3:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Amire80 moved this task from Backlog to Analytics on the UniversalLanguageSelector board.Oct 31 2017, 3:10 PM
Amire80 moved this task from Backlog to Analytics on the ULS-CompactLinks board.Oct 31 2017, 3:35 PM
Amire80 added a project: Language-2018-Jan-Mar.Jan 2 2018, 1:58 PM
Amire80 triaged this task as Medium priority.Jan 2 2018, 2:04 PM
• Petar.petkovic subscribed.Feb 5 2018, 10:15 AM
Arrbee moved this task from Backlog to Priority backlog on the Language-2018-Jan-Mar board.Feb 6 2018, 10:21 AM
Arrbee assigned this task to Amire80.Feb 8 2018, 8:22 AM
Amire80 moved this task from Priority backlog to In Progress on the Language-2018-Jan-Mar board.Feb 14 2018, 9:27 AM
gerritbot subscribed.Mar 4 2018, 9:04 PM

Change 416365 had a related patch set uploaded (by Amire80; owner: Amire80):
[mediawiki/extensions/UniversalLanguageSelector@master] WIP: Log the context of the ULS in which no search results were found

https://gerrit.wikimedia.org/r/416365

gerritbot added a project: Patch-For-Review.Mar 4 2018, 9:04 PM

Change 413270 had a related patch set uploaded (by Amire80; owner: Amire80):
[analytics/limn-language-data@master] WIP Analyzing failed ULS searches

https://gerrit.wikimedia.org/r/413270

• Petar.petkovic moved this task from In Progress to In Review on the Language-2018-Jan-Mar board.Mar 5 2018, 7:08 AM
gerritbot added a comment.Mar 13 2018, 11:49 AM

Change 416365 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] Log the context of the ULS in which no search results were found

https://gerrit.wikimedia.org/r/416365

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-13 (1.31.0-wmf.25)).Mar 13 2018, 12:00 PM
Amire80 moved this task from In Review to QA on the Language-2018-Jan-Mar board.Mar 13 2018, 12:05 PM
Amire80 removed a project: Patch-For-Review.

Thanks for merging. I'll test tonight when it's deployed.

gerritbot added a comment.Mar 15 2018, 9:58 AM

Change 419699 had a related patch set uploaded (by Amire80; owner: Amire80):
[mediawiki/extensions/UniversalLanguageSelector@master] Parse the parameters to no-results-found event as an object

https://gerrit.wikimedia.org/r/419699

gerritbot added a project: Patch-For-Review.Mar 15 2018, 9:58 AM
• Petar.petkovic moved this task from QA to In Review on the Language-2018-Jan-Mar board.Mar 15 2018, 9:59 AM
gerritbot added a comment.Mar 15 2018, 4:26 PM

Change 419773 had a related patch set uploaded (by Amire80; owner: Amire80):
[mediawiki/extensions/UniversalLanguageSelector@master] Update jquery.uls from upstream

https://gerrit.wikimedia.org/r/419773

gerritbot added a comment.Mar 15 2018, 4:40 PM

Change 419773 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] Update jquery.uls from upstream

https://gerrit.wikimedia.org/r/419773

Amire80 closed subtask T189800: Gerrit 419699 fails with errors from jquery.wikibase.entitytermsforlanguageview as Resolved.Mar 18 2018, 9:48 AM
gerritbot added a comment.Mar 20 2018, 9:17 AM

Change 419699 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] Parse the parameters to no-results-found event as an object

https://gerrit.wikimedia.org/r/419699

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)); removed MW-1.31-release-notes (WMF-deploy-2018-03-13 (1.31.0-wmf.25)).Mar 20 2018, 10:00 AM
Amire80 moved this task from In Review to QA on the Language-2018-Jan-Mar board.Mar 21 2018, 8:46 AM
Amire80 added a comment.Mar 21 2018, 9:30 AM

Thanks for merging.

This was deployed in the train yesterday. I just checked it in production using this query:

select webHost, event_ulsPurpose, event_contentLanguage, event_context, event_title, event_token from UniversalLanguageSelector_17799034 where event_action = "no-search-results" and event_ulsPurpose is not null;

It looks like event_title and event_ulsPurpose are now logged in mediawiki.org and test.wikipedia.org, as I would expect.

Does anybody else want to test? If not, we can mark it as resolved.

Follow-ups:

Amire80 mentioned this in T190630: Prepare regular auto-updating reports about failed searches for languages in ULS.Mar 24 2018, 7:03 PM
Amire80 closed this task as Resolved.Mar 24 2018, 7:47 PM
Amire80 removed a project: Patch-For-Review.

The Event logging part is fully done and deployed. The follow up task is T190630. I'll continue https://gerrit.wikimedia.org/r/#/c/413270/ as part of that task.

• Petar.petkovic moved this task from QA to Done on the Language-2018-Jan-Mar board.Mar 25 2018, 10:08 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits