[go: up one dir, main page]

Page MenuHomePhabricator

Infobox styling disappears in firefox
Closed, DeclinedPublic

Description

Background:

when printing an article with an infobox spanning multiple pages, the styling disappears on page n+1 (see screenshot)

Screen Shot 2017-09-05 at 10.19.33 AM.png (575×468 px, 137 KB)

Steps to recreate:

  1. Go to http://reading-web-staging.wmflabs.org/wiki/Mexico_City
  2. print article as PDF

expected behavior: infobox retains styling from first page
observed behavior: infobox does not retain styling from first page

Event Timeline

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.

At first glance this looks like a bug with Mozilla. We should investigate a bit more and see if we can determine which circumstances this happens and why.

My guess is there is very little we can do here.

maybe I'm not following the steps correct but I can't reproduce this on production. that indicates not a mozilla bug?

I was actually able to reproduce in production (Firefox 55.0.3(

Example PDF from staging (http://reading-web-staging.wmflabs.org/wiki/Mexico_City)

Screen Shot 2017-09-06 at 11.36.45 AM.png (742×1 px, 244 KB)

Example PDF from production (https://en.wikipedia.org/wiki/Mexico_City)

Screen Shot 2017-09-06 at 11.37.43 AM.png (699×1 px, 241 KB)

NOTE: the smaller version of the font sizes is also appearing in staging here.
ovasileva lowered the priority of this task from High to Medium.Sep 6 2017, 6:15 PM
ovasileva moved this task from Needs Prioritization to Upcoming on the Web-Team-Backlog board.

I created a MTC (attached) and the issue appears to be because of

table {border-collapse: collapse; }

What are the implications of removing this?

implication is it creates gaps in TD TH cells and borders :( i think you were the one who found that fix to the gap issue :)

are you sure this is happening on production as well. if so, we should keep it in the backlog but move it out of current print work.

It's an issue with existing print styles - Try printing https://en.wikipedia.org/wiki/Colony_of_Virginia in Firefox. Notice how "Today part of" is not enclosed in a border.

alright, confirmed!

Let's move to backlog Needs analysis as we don't know if this is us or firefox?

Could we not add the upstream issue to the print styles' project page under a "Known Issues" heading? Finding tasks (and comments) in Phab isn't a great experience.

removed previous comment - wrong browser.

@ovasileva I am still seeing this on Firefox on both staging and productions.