[go: up one dir, main page]

Page MenuHomePhabricator

Add 'Make this the default' option to bookmarks action menu
Closed, ResolvedPublic

Description

In user testing, I've seen users discover bookmarks/Saved filters. But no one seems to have discovered the 'Set as default' function of Saved filters. And at least one user expressed confusion about defaults. Users get frustrated when the system does not present as they'd like it to. Some expressed interest in just having all settings persist when they leave the page. That solution is not compatible with our current one (Set default). To make Set defaults succeed, we need to make it more discoverable. Here is my fairly simple proposal for doing that:

Add 'make this my default' to the bookmark action menu

  • Clicking the bookmark produces the 'Save current filter settings' menu. The user is invited to enter the new filter's name in a text box.
  • Under the text box, we put a checkbox for 'Make this the default'.
  • If the user clicks the box, that filter becomes the "Create filter" button becomes the "Create default filter" button, with a pushpin icon.
  • When the user clicks the Create default filter button, the filter is saved as the Default in the menu, with the pushpin.
  • Maybe more importantly, the user learns about this function. And because she knows it exists, she will almost certainly be able to find it again when she needs it next.

RC-QL-dialog-states-def.png (345×1 px, 25 KB)

{F8883542. size=full}

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

@Pginer-WMF, I'm concerned about this issue because we're moving pretty rapidly to remove all the preferences from the Preferences page. The idea being that people can use 'Set as default' instead. But it's a totally new function. So I feel like we really need to help people find it.

I had some other ideas but this seemed by far the simplest and most effective. It puts the info right where people who might be interested in it will be. And it doesn't seem that hard.

So if you like the idea, please add to the Description an little illustration showing the layout you want and any other refinements. I'll look to review it right away; I'd like to move on this. Ideally, it could be in place before we rearrange all the Preferences. Thanks.

So if you like the idea, please add to the Description an little illustration showing the layout you want and any other refinements. I'll look to review it right away; I'd like to move on this. Ideally, it could be in place before we rearrange all the Preferences. Thanks.

I added some mockups to the description. I think it is a good idea to make the "set as default" action more prominent in the way you suggested. I made a couple of tweaks:

  • Associating the pushpin to the main call to action (only when the checkbox is marked) helps to connect the concepts without introducing too much visual noise.
  • Regarding the label, we prefer to avoid "my" in the classical my-vs-your discussion. I think that by the context it is clear that the filters created are personal for the user, but if we would like to emphasise that more we could use "Make this your default" instead.

@Pginer-WMF, I'm concerned about this issue because we're moving pretty rapidly to remove all the preferences from the Preferences page.

I don't see this issue as strongly connected with the removal of Preferences as you describe it. The users in the research sessions you mention in the description they had the preferences settings available (since we have not removed them) but those did not seem of much help to get their defaults set (in fact, they choose to use a saved filter instead).

I see this ticket as an improvement over the general situation, not as a problem caused or intensified by the removal of the preferences, although I had no time to go over the tests and may have missed the role that preferences played into this.

Change 368478 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/core@master] RCFilters: Allow setting a new query as default

https://gerrit.wikimedia.org/r/368478

jmatazzoni renamed this task from Add 'Make this my default' option to bookmarks action menu to Add 'Make this the default' option to bookmarks action menu.Jul 28 2017, 8:30 PM
jmatazzoni updated the task description. (Show Details)
jmatazzoni updated the task description. (Show Details)

Under the text box, we put a checkbox for 'Make this the default'.

The text for making any query as the default from the query context menu is "Set as default", would it make sense to have the same message in both places for the same action?

Change 368478 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Allow setting a new query as default

https://gerrit.wikimedia.org/r/368478

Under the text box, we put a checkbox for 'Make this the default'.

The text for making any query as the default from the query context menu is "Set as default", would it make sense to have the same message in both places for the same action?

Makes sense. The main difference in context is that here the element does not exist. "Set as default" works well as a direct action for the menu, but I think it could work well here too. So I'm ok in unifying the messaging.

Checked in betalabs and wmf.12 - all functionality is in place.
'Set as default' check box works as

Screen Shot 2017-08-03 at 12.04.51 PM.png (345×383 px, 24 KB)

QA Recommendation: Resolve