When querying for multiple tags, and more than one is in the edit, duplicate results
Closed, ResolvedPublic
Actions

Description

E.g. if the edit is tagged with both foo and bar, and you query for tags foo or bar, the edit will show twice.

Details

	Subject	Repo	Branch	Lines +/-
	RCFilters: Filter duplicates when filtering for multiple tags	mediawiki/core	wmf/1.30.0-wmf.11	+51 -15
	RCFilters: Filter duplicates when filtering for multiple tags	mediawiki/core	master	+51 -15

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	• DannyH	T171977 Annual Plan 2017-2018, Audiences 5: Increase current editor retention and engagement
Resolved	• DannyH	T171981 Annual Plan 2017-2018, Audiences 5, Goal 2: Give better ways to monitor contributions
Open	None	T164232 Provide "RC Filters" functionality on all pages that show sets of changes (or consolidate them as filtered views of RecentChanges?)
Resolved	• Catrope	T181193 [EPIC] Graduate the New Filters UX on Watchlist out of beta on all wikis
Resolved	• Catrope	T164234 Provide "RC Filters" functionality on the watchlist
Resolved	SBisson	T162675 'Integrated filters'—add all RC Page filters into the new UI along with selected new functions
Resolved	Mooeypoo	T166912 Implement Namespace filters and filter menu in the new UI
Resolved	Pginer-WMF	T159942 Explore designs for including filtering for users, edit tags, and namespaces
Resolved	matmarex	T27909 Add a drop-down list for the tags in Special:Newpages, Special:Log and Special:Contributions
Resolved	Mooeypoo	T166914 Implement 'Tagged edits' filters and filter menu in the new UI
Resolved	Mooeypoo	T161650 Replace "Tag filter" input with a dropdown+lookup widget in RCFilters
Resolved	SBisson	T164133 Support multiple values for the tagfilter parameter in the ChangesList backend
Resolved	• Catrope	T168501 When querying for multiple tags, and more than one is in the edit, duplicate results
Invalid	None	T166618 Handle more than 500 tags per wiki

Event Timeline

• Mattflaschen-WMF created this task.Jun 21 2017, 7:18 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 21 2017, 7:18 AM

• Mattflaschen-WMF added a parent task: T164133: Support multiple values for the tagfilter parameter in the ChangesList backend.Jul 5 2017, 7:53 PM

• Mattflaschen-WMF added a parent task: T166914: Implement 'Tagged edits' filters and filter menu in the new UI.

• Mattflaschen-WMF mentioned this in T166914: Implement 'Tagged edits' filters and filter menu in the new UI.

For testing after the fix:

One tag is selected - 'Mobile web edits'

Screen Shot 2017-07-05 at 2.04.50 PM.png (393×1 px, 116 KB)

two tags are selected - 'Mobile web edits' and'Mobile edit'. Notice how entires become displayed twice.

Screen Shot 2017-07-05 at 2.07.59 PM.png (517×1 px, 193 KB)

• Mattflaschen-WMF mentioned this in T158572: Explore how to make a category search that includes sub-categories. .Jul 8 2017, 1:05 AM

• Catrope claimed this task.Jul 10 2017, 5:14 PM

• Catrope moved this task from Untriaged to In Development on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.

Change 364251 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] [WIP] RCFilters: Filter duplicates when filtering for multiple tags

https://gerrit.wikimedia.org/r/364251

gerritbot added a project: Patch-For-Review.Jul 10 2017, 5:17 PM

• jmatazzoni mentioned this in T170501: Graduate 'New filters for edit review' out of beta, making it standard on all wikis.Jul 12 2017, 10:53 PM

• jmatazzoni edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017).Jul 14 2017, 12:15 AM

• jmatazzoni moved this task from Untriaged to In Development on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

• Catrope moved this task from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jul 15 2017, 2:59 AM

• Mattflaschen-WMF moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jul 26 2017, 12:03 AM

Change 364251 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Filter duplicates when filtering for multiple tags

https://gerrit.wikimedia.org/r/364251

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-08-01_(1.30.0-wmf.12)).Jul 26 2017, 1:01 AM

Checked the fix in betalabs.

Etonkovidova closed this task as Resolved.Jul 27 2017, 12:30 AM

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

Change 368214 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@wmf/1.30.0-wmf.11] RCFilters: Filter duplicates when filtering for multiple tags

https://gerrit.wikimedia.org/r/368214

Change 368214 merged by jenkins-bot:
[mediawiki/core@wmf/1.30.0-wmf.11] RCFilters: Filter duplicates when filtering for multiple tags

https://gerrit.wikimedia.org/r/368214

Mentioned in SAL (#wikimedia-operations) [2017-07-27T18:29:27Z] <catrope@tin> Synchronized php-1.30.0-wmf.11/includes/: T168501 and T163380 (duration: 01m 31s)

Stashbot mentioned this in T163380: Support posting Jobs to EventBus simultaneously with normal job processing.Jul 27 2017, 6:29 PM

Mentioned in SAL (#wikimedia-operations) [2017-07-27T18:44:15Z] <catrope@tin> Synchronized php-1.30.0-wmf.11/includes/: Temporarily revert patch for T168501 while I fix it (duration: 01m 27s)

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)); removed MW-1.30-release-notes (WMF-deploy-2017-08-01_(1.30.0-wmf.12)).Jul 27 2017, 7:00 PM

Mentioned in SAL (#wikimedia-operations) [2017-07-27T19:05:54Z] <catrope@tin> Synchronized php-1.30.0-wmf.11/includes/: T168501, take two (duration: 01m 27s)

	F8626179: Screen Shot 2017-07-05 at 2.07.59 PM.png
	Jul 5 2017, 9:08 PM

	F8626173: Screen Shot 2017-07-05 at 2.04.50 PM.png
	Jul 5 2017, 9:08 PM

When querying for multiple tags, and more than one is in the edit, duplicate resultsClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

When querying for multiple tags, and more than one is in the edit, duplicate results
Closed, ResolvedPublic
Actions

Related Objects
Search...