[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T157145

Twitter cards don't work for any projects besides Wikidata
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
• alexhollender_WMF
Authored By
Jdlrobson
Feb 3 2017, 4:44 PM
Tags
Referenced Files
F34443877: wechat.png
May 6 2021, 4:57 PM
F34442423: slack.png
May 5 2021, 8:13 PM
F34442425: discord.png
May 5 2021, 8:13 PM
F34442414: facebook.png
May 5 2021, 8:13 PM
F34442412: twitter.png
May 5 2021, 8:13 PM
F34442421: signal.jpeg
May 5 2021, 8:13 PM
F34442427: google fi.png
May 5 2021, 8:13 PM
F34442418: whatsapp.jpeg
May 5 2021, 8:13 PM
View All 31 Files
Subscribers
adrelanos
Ainali
Aklapper
• alexhollender_WMF
Amorymeltzer
Antanana
awight
View All 57 Subscribers
Tokens
"Yellow Medal" token, awarded by Volker_E."Party Time" token, awarded by Pcoombe."Party Time" token, awarded by Ladsgroup."Cookie" token, awarded by Tagishsimon."Heartbreak" token, awarded by awight."Like" token, awarded by Calexit.

Description

Currently sharing on Facebook, Whatsapp and other social networks displays a nice image, however on Twitter nothing happens as we haven't opted in to support their service.

Twitter uses og tags but requires the following tag to show we've opted in. Shall we add it?

<meta name="twitter:card" content="summary_large_image">

Update: A mini- reverse-engineering experiment shows that Twitter can parse cards on a page from pure og meta tags, we don't need to add a twitter:card. Also, og:description summaries are optional and will be implemented in separate task T213505, so we can deploy an interim set of tags even before the description is ready.

Details

SubjectRepoBranchLines +/-
Use getHTMLTitle instead of getDisplayTitlemediawiki/coremaster+1 -1
[WIP] Minimal metadata to enable OpenGraph cardsmediawiki/coremaster+4 -0
Enable og tags on non-wikidata wikisoperations/mediawiki-configmaster+7 -6
Enable og tags on labs wikis for testingoperations/mediawiki-configmaster+6 -0
Add to configuration to allow addition of certain tags to pagemediawiki/coremaster+24 -0
Revert "Revert "Add twitter meta tag for image""mediawiki/extensions/PageImagesmaster+2 -0
Revert "Add twitter meta tag for image"mediawiki/extensions/PageImagesmaster+0 -2
[WIP] Minimal metadata to enable OpenGraph cardsmediawiki/extensions/TextExtractsmaster+21 -0
Use quasi-open metadata key rather than branded onemediawiki/extensions/Wikibasemaster+2 -2
Add twitter meta tag for imagemediawiki/extensions/PageImagesmaster+2 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.Feb 21 2020, 4:11 PM

Change 574024 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/TextExtracts@master] [WIP] Minimal metadata to enable OpenGraph cards

https://gerrit.wikimedia.org/r/574024

gerritbot added a project: Patch-For-Review.Feb 21 2020, 4:11 PM
awight added a comment.Feb 21 2020, 4:25 PM

OpenGraph turns out to be pretty trashy, even as far as its controlling corporate company goes. Here's a short criticism. After digging into this, now I'd prefer if Twitter could just read our <title> and <meta description= rather than spamming the Internet with duplicate data, eh? But let's go ahead with the minor code workaround, and undeploy again once Corporation upgrades their scrapers. The benefit is that we get cards immediately, and probably take 3rd-party MediaWiki installs into the future along with us.

gerritbot added a comment.Feb 21 2020, 4:26 PM

Change 574029 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/Wikibase@master] Use quasi-open metadata key rather than branded one

https://gerrit.wikimedia.org/r/574029

gerritbot added a comment.Feb 21 2020, 6:03 PM

Change 574029 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use quasi-open metadata key rather than branded one

https://gerrit.wikimedia.org/r/574029

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.21; 2020-02-25).Feb 21 2020, 7:00 PM
gerritbot added a comment.Feb 26 2020, 8:31 AM

Change 574024 abandoned by Awight:
[WIP] Minimal metadata to enable OpenGraph cards

Reason:
Doesn't belong in TextExtracts, per reviews.

https://gerrit.wikimedia.org/r/574024

gerritbot added a comment.Feb 26 2020, 9:16 AM

Change 574980 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/core@master] [WIP] Minimal metadata to enable OpenGraph cards

https://gerrit.wikimedia.org/r/574980

Pigsonthewing mentioned this in T198716: Enable PageImages on Commons categories namespace.Mar 2 2020, 11:10 PM
Jdlrobson merged a task: T63487: Sharing a Wikimedia Commons file description on Twitter should use a Twitter card.Mar 2 2020, 11:24 PM
Jdlrobson merged a task: T238914: Add social meta tags.
Jdlrobson merged a task: T170865: [Bug] Article share card not appearing on Twitter.
Jdlrobson added subscribers: Crissov, harshcrop, xSavitar and 12 others.
Jdlrobson added a subscriber: Mbch331.
Jdlrobson added subscribers: cmadeo, Krenair, Multichill and 4 others.
awight renamed this task from Sharing on Twitter doesn't use the Cards format. to Twitter cards don't work for any projects besides Wikidata.Apr 6 2020, 1:43 PM
awight updated the task description. (Show Details)
• JMinor unsubscribed.Apr 6 2020, 5:50 PM
Aklapper removed a subscriber: • wikibugs-l-list.Apr 12 2020, 9:55 AM
Mike_Peel subscribed.Jul 1 2020, 6:57 AM
• kchapman added a project: Platform Engineering.Aug 6 2020, 8:50 PM
• kchapman subscribed.

tagging Platform Engineering, I believe this also is an issue in Whats App

• Clarakosi moved this task from Inbox to Tracking/Watching on the Platform Engineering board.Aug 6 2020, 8:58 PM
• Clarakosi subscribed.

Looks like there is a WIP patch. @awight are you still working on this?

Jdlrobson added a comment.Aug 6 2020, 9:30 PM

BTW I'm still happy to volunteer myself as a reviewer for any changes that address this.

TheDJ added a comment.Aug 7 2020, 8:33 AM

@kchapman as someone who works with WhatsApp messaging professionally, I can state that WhatsApp requires Open Graph Protocol for link preview generation.

Izno subscribed.Aug 13 2020, 2:22 AM
Prod subscribed.Sep 22 2020, 4:30 PM
CDanis subscribed.Nov 10 2020, 2:31 PM
• jcrespo subscribed.Nov 10 2020, 2:34 PM
Nikerabbit moved this task from Backlog to Watching on the User-Nikerabbit board.Jan 14 2021, 7:18 AM
gerritbot added a comment.Feb 18 2021, 1:51 AM

Change 664963 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Add og:title to page

https://gerrit.wikimedia.org/r/664963

gerritbot added a comment.Feb 18 2021, 1:52 AM

Change 664967 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/PageImages@master] Revert "Revert "Add twitter meta tag for image""

https://gerrit.wikimedia.org/r/664967

gerritbot added a comment.Feb 18 2021, 8:33 PM

Change 664967 abandoned by Jdlrobson:
[mediawiki/extensions/PageImages@master] Revert "Revert "Add twitter meta tag for image""

Reason:
Folded into https://gerrit.wikimedia.org/r/c/mediawiki/core/ /664963 - better to centralize all this.

https://gerrit.wikimedia.org/r/664967

gerritbot added a comment.Feb 22 2021, 8:19 AM

Change 664963 merged by jenkins-bot:
[mediawiki/core@master] Add to configuration to allow addition of certain tags to page

https://gerrit.wikimedia.org/r/664963

Ladsgroup added a comment.Feb 22 2021, 8:25 AM

Next step. Enabling it on beta. Later on Wikipedia.

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.32; 2021-02-23).Feb 22 2021, 9:00 AM
ovasileva subscribed.Feb 23 2021, 10:40 AM
gerritbot added a comment.Feb 24 2021, 6:39 PM

Change 666720 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[operations/mediawiki-config@master] Enable og tags on labs wikis for testing

https://gerrit.wikimedia.org/r/666720

gerritbot added a comment.Feb 24 2021, 7:06 PM

Change 666720 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable og tags on labs wikis for testing

https://gerrit.wikimedia.org/r/666720

Ladsgroup added a comment.Feb 24 2021, 7:29 PM

With og:type and og:title, it works:

image.png (317×1 px, 73 KB)

Should we deploy this on wikipedia next week?

Jdlrobson added a comment.EditedFeb 24 2021, 7:41 PM

I need to run these by Olga and Alex first. There are some subtle differences between the configs I just enabled. I can deploy to production once that's done.

yes, og:title and og:type are required (my change on de.wikipedia had no effect)

image.png (626×1 px, 171 KB)

twitter:card is optional but has the following effect which may be desirable from a product perspective:

image.png (1×1 px, 858 KB)

Jdlrobson added a comment.EditedFeb 24 2021, 8:53 PM

Okay so if we enable either of the two above the following happens:

  1. Twitter renders /something/
  2. Some smaller platforms (only Slack currently known one) will no longer show a description when shared
platformbeforeoption 1option 2notes
twitter
image.png (216×1 px, 39 KB)
image.png (626×1 px, 171 KB)
image.png (1×1 px, 858 KB)
landscape card with option 2. Clear improvement either way.
fb
Screen Shot 2021-02-24 at 12.43.14 PM.png (520×1 px, 309 KB)
no changeno changeno change
whatsapp
Screen Shot 2021-02-24 at 12.46.57 PM.png (206×794 px, 49 KB)
no changeno changeWhatsapp doesn't support picture with a size greater than 300KB. [1]
slack
Screen Shot 2021-02-24 at 12.41.01 PM.png (1×980 px, 665 KB)
Screen Shot 2021-02-24 at 12.38.56 PM.png (680×882 px, 344 KB)
see option 1no description
wechatno thumbnailno changeno change

[1]

Screen Shot 2021-02-24 at 12.51.29 PM.png (324×1 px, 77 KB)

• alexhollender_WMF subscribed.Feb 24 2021, 9:12 PM
Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2020-21), MediaWiki-Core-Skin-Architecture; removed Platform Engineering, Discovery-ARCHIVED, MediaWiki-General.Feb 24 2021, 9:22 PM

Adding for visiblity.

Ladsgroup added a comment.Feb 25 2021, 6:20 AM
In T157145#6858130, @Jdlrobson wrote:

twitter:card is optional but has the following effect which may be desirable from a product perspective:

image.png (1×1 px, 858 KB)

I understand the usefulness but please no vendor specific tags in Wikipedia.

Tgr added a comment.Feb 25 2021, 9:09 AM
In T157145#6859573, @Ladsgroup wrote:

I understand the usefulness but please no vendor specific tags in Wikipedia.

Why would we want to avoid vendor-specific tags (or rather new vendor-specific tags since we already use <link rel="apple-touch-icon">) if the vendor is popular enough?

thiemowmde added a comment.Feb 25 2021, 9:23 AM

Exactly because it is popular, I would argue. Not only does it give a dominating platform an additional advantage – a platform that's already more powerful than pretty much all competitors. It also acts as a signal: look, Wikipedia specifically supports Twitter (and Apple), but nothing else.

Ladsgroup added a comment.Feb 25 2021, 9:27 AM

For me it's a matter of principle. I don't want to send a message that Wikipedia bows to corporations/governments/etc. specially for something that has an alternative (OpenGraph)

awight added a comment.Feb 25 2021, 9:28 AM

Can we experiment more with og:type? Has anyone else done the reverse-engineering to find how these map to twitter:card?

Mike_Peel added a comment.Feb 25 2021, 6:55 PM

It would be nice to test this for Commons, if possible, please - is there a beta Commons that this could be set up on? (Also, maybe deploy on Commons to test, before deploying to Wikipedia?)

Jdlrobson claimed this task.Feb 25 2021, 7:47 PM
In T157145#6859983, @awight wrote:

Can we experiment more with og:type? Has anyone else done the reverse-engineering to find how these map to twitter:card?

I've been talking to the "expert" and my understanding is the Twitter card is only used for the image thumbnail type https://twitter.com/vjo/status/1362339509619339265 @awight feel free to join the conversation if you are on Twitter, otherwise I can relay any questions on your behalf.

In T157145#6862387, @Mike_Peel wrote:

It would be nice to test this for Commons, if possible, please - is there a beta Commons that this could be set up on? (Also, maybe deploy on Commons to test, before deploying to Wikipedia?)

I plan to enable that on all wikis next week.

We can iterate from there, perhaps having project-specific configurations if necessary.

In T157145#6859979, @Ladsgroup wrote:

For me it's a matter of principle. I don't want to send a message that Wikipedia bows to corporations/governments/etc. specially for something that has an alternative (OpenGraph)

It seems like we are leaning towards the design without twitter:card anyway...

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Feb 25 2021, 8:06 PM
gerritbot added a comment.Feb 25 2021, 8:16 PM

Change 667007 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[operations/mediawiki-config@master] Enable og tags on non-wikidata wikis

https://gerrit.wikimedia.org/r/667007

Jdlrobson moved this task from Upcoming to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Feb 25 2021, 11:16 PM
Quiddity added a comment.Feb 25 2021, 11:34 PM

I plan to enable that on all wikis next week.

@Jdlrobson Hallo! Please could you/someone suggest how to describe this for a Tech News entry? I imagine something like:

"Links to Wikimedia pages from some external social media sites such as Twitter, will display more content such as larger images and clearer links. This is due to a small change to our meta-data. Further improvements to show page-content excerpts, will come later. [link to this task]"

Tweaks for clarity/accuracy appreciated. I'll add it to the draft on Friday.

I'd also suggest adding a slightly more detailed summary into this Task's description, so that it's easy for everyone to see at a glance what has purposefully changed (without having to read/skim this whole thread). Perhaps copying the "before/after" matrix (just with whichever Option is being used) from T157145#6858470 above.
Thanks!

Jdlrobson added a comment.Feb 26 2021, 12:13 AM

@Quiddity my plan was to create a new User-notice after I've done it so can you please hold off on adding that to the draft?

Quiddity added a comment.Feb 26 2021, 1:55 AM

Sounds good. Just let us know. Ideally by moving current task into the "Announce in next Tech/News" column on that workboard. Thanks!

Jdlrobson moved this task from Backlog to It's complicated on the MediaWiki-Core-Skin-Architecture board.Feb 26 2021, 3:19 AM
Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Mar 1 2021, 4:37 PM
ovasileva set the point value for this task to 2.Mar 1 2021, 6:29 PM
• alexhollender_WMF added a comment.Mar 1 2021, 7:39 PM

some smaller messaging platforms

platformbeforeafternotes
Signal
image.png (676×479 px, 482 KB)
image.png (676×479 px, 485 KB)
no change
iMessage (iOS)
image.png (511×340 px, 264 KB)
image.png (528×324 px, 267 KB)
no change
Discord
Screen Shot 2021-03-01 at 3.32.28 PM.png (490×505 px, 146 KB)
Screen Shot 2021-03-01 at 3.32.39 PM.png (502×513 px, 147 KB)
no change
gerritbot added a comment.Mar 2 2021, 12:05 AM

Change 667007 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable og tags on non-wikidata wikis

https://gerrit.wikimedia.org/r/667007

Stashbot added a comment.Mar 2 2021, 12:43 AM

Mentioned in SAL (#wikimedia-operations) [2021-03-02T00:43:25Z] <urbanecm@deploy1002> Synchronized wmf-config/InitialiseSettings.php: 6cc8521310d6e952fc7d0b23579021b650828764: Enable og tags on non-wikidata wikis (T157145) (duration: 00m 56s)

Jdlrobson moved this task from Code Review to Design Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Mar 2 2021, 1:11 AM
Jdlrobson mentioned this in T276185: Wikimedia links shared on Twitter will now show a preview..Mar 2 2021, 1:17 AM
Ladsgroup awarded a token.Mar 2 2021, 4:56 AM
gerritbot added a comment.Mar 2 2021, 7:50 AM

Change 574980 abandoned by Awight:
[mediawiki/core@master] [WIP] Minimal metadata to enable OpenGraph cards

Reason:
An alternative has been merged :-D

https://gerrit.wikimedia.org/r/574980

Pcoombe awarded a token.Mar 2 2021, 11:16 AM
Jdlrobson reassigned this task from Jdlrobson to • alexhollender_WMF.Mar 3 2021, 6:06 PM
stjn subscribed.Mar 7 2021, 6:56 PM

og:title seems to receive HTML in current version:
https://en.wikipedia.org/wiki/User:Chlod
<meta property="og:title" content="&lt;span style=&quot;position:fixed;top:-1000vh;&quot;&gt;User:&lt;/span&gt;&lt;span style=&quot;font-family:&amp;#39;Roboto&amp;#39;,&amp;#39;Arial&amp;#39;,sans-serif;font-weight:300; color:black;&quot;&gt;Chlod&lt;/span&gt;"/>

It’s not a big concern for articles, but considering that <title> itself has no HTML in it (while still displaying results of applying DISPLAYTITLE), this should be possible to fix.

gerritbot added a comment.Mar 8 2021, 8:27 PM

Change 669971 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Use getHTMLTitle instead of getDisplayTitle

https://gerrit.wikimedia.org/r/669971

gerritbot added a comment.Mar 10 2021, 11:26 AM

Change 669971 merged by jenkins-bot:
[mediawiki/core@master] Use getHTMLTitle instead of getDisplayTitle

https://gerrit.wikimedia.org/r/669971

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.35; 2021-03-16); removed MW-1.36-notes (1.36.0-wmf.32; 2021-02-23).Mar 10 2021, 12:00 PM
Volker_E awarded a token.Mar 15 2021, 2:38 PM
Jdlrobson changed the status of subtask T142090: Add hover-card like summary (og:description) to open graph meta data printing plain summary and headline property in the SameAs schema from Open to Stalled.Mar 25 2021, 6:57 PM
Jdlrobson removed a subtask: T142090: Add hover-card like summary (og:description) to open graph meta data printing plain summary and headline property in the SameAs schema.Mar 25 2021, 9:24 PM
Nintendofan885 subscribed.Apr 1 2021, 11:16 AM
• alexhollender_WMF closed this task as Resolved.EditedMay 5 2021, 8:13 PM

the current state of things for posterity:

twitter
twitter.png (536×1 px, 148 KB)
facebook
facebook.png (1×1 px, 1 MB)
telegram
telegram.jpeg (2×1 px, 1 MB)
whatsapp
whatsapp.jpeg (879×1 px, 358 KB)
signal
signal.jpeg (2×1 px, 691 KB)
slack
slack.png (1×1 px, 580 KB)
discord
discord.png (1×1 px, 456 KB)
google fi
google fi.png (1×1 px, 299 KB)
google chat
google chat.png (650×944 px, 287 KB)
wechat
wechat.png (401×1 px, 138 KB)

(@Jdlrobson any thoughts on WhatsApp as a follow-up task?)

awight added a comment.May 5 2021, 9:44 PM

I just want to say, great work all! This is a big deal...

Jdlrobson mentioned this in T282065: PageImages should be < 300kb for Whatsapp share support.May 5 2021, 10:45 PM

Per T157145#6858470 Whatsapp works provided the thumbnail is below 300kb. Try https://en.wikipedia.org/wiki/Journey_to_the_West:_Conquering_the_Demons for example. We'd need to coordinate with Platform Engineering to see if we can address that. Have opened T282065.

Tagishsimon unsubscribed.May 6 2021, 8:44 AM
• alexhollender_WMF added a comment.May 6 2021, 4:58 PM

@Jdlrobson one final addition to the audit: WeChat (which according to this chart is quite popular: https://www.statista.com/statistics/258749/most-popular-global-mobile-messenger-apps/). Any ideas on that one?

Jdlrobson added a comment.May 6 2021, 11:14 PM

Wechat doesn't do previews for any link as far as I'm aware (I use it quite actively with my partner's family).

Trizek-WMF removed a project: User-notice.Aug 26 2021, 2:54 PM
hashar mentioned this in T288117: Add Open Graph support to Phabricator Maniphest Tasks to have link preview on Telegram, Slack, and other messaging apps.Nov 24 2023, 7:20 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 24 2023, 7:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits