[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T156423

Merge new site branding to master branch and prepare for deployments
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
Jdlrobson
Authored By
Jdlrobson
Jan 26 2017, 9:03 PM
Tags
Referenced Files
F5423856: wikipedia-wordmark-en.svg
Jan 31 2017, 12:02 AM
F5367036: commons-wordmark.svg
Jan 27 2017, 1:48 AM
F5367033: wikitionary-wordmark-en.svg
Jan 27 2017, 1:48 AM
F5366885: wikitionary-wordmark-en.svg
Jan 27 2017, 1:18 AM
F5366861: wikivoyage-wordmark.svg
Jan 27 2017, 1:14 AM
F5366860: commons-wordmark.svg
Jan 27 2017, 1:14 AM
F5366829: wikipedia-wordmark-en.svg
Jan 27 2017, 1:09 AM
F5366828: wikipedia-wordmark-ru.svg
Jan 27 2017, 1:09 AM
View All 11 Files
Subscribers
Aklapper
• bmansurov
debt
Florian
gerritbot
Jdlrobson
Jdrewniak
View All 12 Subscribers

Description

Background

We want to merge all the branding work into the MobileFrontend master branch but we want to feature flag switching from a search input to a search icon.

Acceptance Criteria

  • Ensure T157987 has been merged (search bar is feature flagged)
  • Merge contents of branding branch onto master and confirm search button on mobile is disabled by default in stable but shown on beta.
  • Ensure browser tests pass on the beta cluster
  • Create a new task when the switchover has been merged as a reminder to remove css for cached HTML (this is captured as https://phabricator.wikimedia.org/T158144)

Merging

  • No need to SWAT - just let it ride the train.

Details

SubjectRepoBranchLines +/-
Run search related browser tests against betamediawiki/extensions/MobileFrontendmaster+4 -4
Merge remote-tracking branch 'gerrit/branding'mediawiki/extensions/MobileFrontendmaster+3 -757
Allow feature flagging of new headermediawiki/extensions/MobileFrontendmaster+49 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Jan 26 2017, 9:03 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)Jan 27 2017, 12:35 AM
Jdlrobson added a subscriber: • JGirault.

@JGirault hey do you know where the static files live (e.g. Wikipedia logo etc)? I ask as I think you recently changed them on the discovery portal.

Jdlrobson added a comment.EditedJan 27 2017, 12:45 AM

@Nirzar is going to add assets for the top 10 wikipedias so we can launch this with logo for all those projects (others we can gradually update during roll out). Nirzar please make sure they are all the same resolution!

Jdlrobson updated the task description. (Show Details)Jan 27 2017, 12:45 AM
• Nirzar added a comment.EditedJan 27 2017, 1:06 AM

Wikipedia Languages

englishwikipedia-wordmark-en.svg
Germanwikipedia-wordmark-en.svg
Frenchwikipedia-wordmark-fr.svg
Polishwikipedia-wordmark-en.svg
Japanesewikipedia-wordmark-jp.svg
Dutchwikipedia-wordmark-en.svg
Italianwikipedia-wordmark-en.svg
Portugesewikipedia-wordmark-pt.svg
Spanishwikipedia-wordmark-en.svg
Russianwikipedia-wordmark-ru.svg

wikipedia-wordmark-jp.svg19 KBDownload

wikipedia-wordmark-ru.svg15 KBDownload

wikipedia-wordmark-en.svg17 KBDownload

wikipedia-wordmark-fr.svg18 KBDownload

• Nirzar added a comment.EditedJan 27 2017, 1:14 AM

Other projects - optional

commons

commons-wordmark.svg3 KBDownload

wikivoyage

wikivoyage-wordmark.svg2 KBDownload

Wikitionary

wikitionary-wordmark-en.svg18 KBDownload

• JGirault added a comment.Jan 27 2017, 1:19 AM
In T156423#2974919, @Jdlrobson wrote:

@JGirault hey do you know where the static files live (e.g. Wikipedia logo etc)? I ask as I think you recently changed them on the discovery portal.

Not sure if this is going to answer the question...

  • Static assets on portal live here:

https://github.com/wikimedia/portals/tree/master/dev/wikipedia.org/assets/img
/cc @Jdrewniak

  • But I know some of them live on Commons:

https://commons.wikimedia.org/wiki/Category:High-resolution_or_SVG_official_Wikimedia_logos
/
https://commons.wikimedia.org/w/index.php?title=Special:Search&profile=advanced&profile=advanced&fulltext=1&search=Wikipedia+wordmark&ns6=1

Good luck!

Nemo_bis unsubscribed.Jan 27 2017, 7:35 AM
Qgil unsubscribed.Jan 27 2017, 8:16 AM
ovasileva moved this task from Incoming to Upcoming on the Web-Team-Backlog board.Jan 27 2017, 2:06 PM
ovasileva added a comment.Jan 30 2017, 8:06 PM

@Jdlrobson - would it make sense to separate the test deploy (to a single wiki) as a subtask?

Jdlrobson added a comment.Jan 30 2017, 10:51 PM

@ovasileva yes please. Be sure to document where we want to put it and how long it needs to run for and if any schemas will need updating...

• Moushira removed a project: Readers-Community-Engagement.Jan 30 2017, 11:26 PM
Jdlrobson updated the task description. (Show Details)Jan 31 2017, 12:02 AM
ovasileva created subtask T156793: Inform community about upcoming beta deploy of new site branding on mobile.Jan 31 2017, 1:27 PM
Jdlrobson updated the task description. (Show Details)Jan 31 2017, 7:46 PM
ovasileva removed a project: Reading-Web-Sprint-91-🐔🍔.Feb 1 2017, 1:41 PM
gerritbot subscribed.Feb 7 2017, 1:39 AM

Change 336352 had a related patch set uploaded (by Jdlrobson):
Adjust new header styles to be compatible with cached HTML

https://gerrit.wikimedia.org/r/336352

gerritbot added a project: Patch-For-Review.Feb 7 2017, 1:39 AM
Jdlrobson renamed this task from Deploy new site branding to master branch to Deploy new site branding to master branch and prepare for deployments.Feb 7 2017, 6:48 PM
Jdlrobson edited projects, added Reading-Web-Sprint-92-🍜; removed Patch-For-Review.
Jdlrobson updated the task description. (Show Details)
Jdlrobson mentioned this in T156794: Deploy new header to Catalan and Italian wikipedia mobile website.Feb 7 2017, 7:12 PM
gerritbot added a comment.Feb 7 2017, 7:12 PM

Change 336459 had a related patch set uploaded (by Jdlrobson):
WIP: Allow feature flagging of new header

https://gerrit.wikimedia.org/r/336459

gerritbot added a project: Patch-For-Review.Feb 7 2017, 7:12 PM
Jdlrobson updated the task description. (Show Details)Feb 7 2017, 7:13 PM
gerritbot added a comment.Feb 7 2017, 10:50 PM

Change 336459 had a related patch set uploaded (by Jdlrobson):
Allow feature flagging of new header

https://gerrit.wikimedia.org/r/336459

gerritbot added a comment.Feb 7 2017, 10:51 PM

Change 336459 abandoned by Jdlrobson:
Allow feature flagging of new header

Reason:
Should be on branding branch

https://gerrit.wikimedia.org/r/336459

gerritbot added a comment.Feb 7 2017, 10:52 PM

Change 336353 had a related patch set uploaded (by Jdlrobson):
Allow feature flagging of new header

https://gerrit.wikimedia.org/r/336353

ovasileva closed subtask T156793: Inform community about upcoming beta deploy of new site branding on mobile as Invalid.Feb 8 2017, 3:35 PM
phuedx renamed this task from Deploy new site branding to master branch and prepare for deployments to Merge new site branding to master branch and prepare for deployments.Feb 9 2017, 5:47 PM
Jdlrobson set the point value for this task to 5.Feb 9 2017, 5:51 PM
Jdlrobson merged a task: T147395: Clicking the search bar on mobile-web doesn't always open the keyboard.EditedFeb 10 2017, 7:37 PM
Jdlrobson added a subscriber: Florian.

Merged the above task as we specifically fixed this issue in the new header rewrite which you can test on the branding mobilefrontend branch.

Jdlrobson updated the task description. (Show Details)Feb 13 2017, 5:24 PM
Jdlrobson updated the task description. (Show Details)Feb 13 2017, 6:25 PM
Jdlrobson removed the point value for this task.
Jdlrobson removed a project: Patch-For-Review.
Jdlrobson added a parent task: T157987: Prepare branding branch for merging to master.Feb 13 2017, 8:09 PM
Jdlrobson updated the task description. (Show Details)
ovasileva updated the task description. (Show Details)Feb 14 2017, 4:28 PM
ovasileva raised the priority of this task from Medium to High.Feb 14 2017, 4:34 PM
Jdlrobson updated the task description. (Show Details)Feb 14 2017, 6:51 PM
gerritbot added a comment.Feb 15 2017, 12:05 AM

Change 337764 had a related patch set uploaded (by Jdlrobson):
Merge remote-tracking branch 'gerrit/branding'

https://gerrit.wikimedia.org/r/337764

gerritbot added a project: Patch-For-Review.Feb 15 2017, 12:05 AM
gerritbot added a comment.Feb 15 2017, 12:36 AM

Change 337765 had a related patch set uploaded (by Jdlrobson):
Run search related browser tests against beta

https://gerrit.wikimedia.org/r/337765

gerritbot added a comment.Feb 15 2017, 1:00 AM

Change 337764 merged by jenkins-bot:
Merge remote-tracking branch 'gerrit/branding'

https://gerrit.wikimedia.org/r/337764

Jdlrobson edited projects, added Reading-Web-Sprint-91-🐔🍔, Unplanned-Sprint-Work; removed Patch-For-Review, Reading-Web-Sprint-92-🍜.Feb 15 2017, 1:12 AM
Jdlrobson updated the task description. (Show Details)
Jdlrobson set the point value for this task to 2.
Jdlrobson moved this task from Needs Analysis to Ready for Signoff on the Reading-Web-Sprint-91-🐔🍔 board.
gerritbot added a comment.Feb 15 2017, 1:20 AM

Change 337765 merged by jenkins-bot:
Run search related browser tests against beta

https://gerrit.wikimedia.org/r/337765

Jdlrobson updated the task description. (Show Details)EditedFeb 15 2017, 1:22 AM
Jdlrobson added a subscriber: • Jhernandez.

So I just went ahead and pulled this in because I'm a loose cannon and going on vacation soon and wanted to ensure we get this in a good place before I leave etc sorry @Jhernandez ;-)

This can be signed off provided:

The interim header will go live from 21st February.

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-02-21_(1.29.0-wmf.13)).Feb 15 2017, 2:00 AM
ovasileva moved this task from Upcoming to 2016-17 Q3 on the Web-Team-Backlog board.Feb 15 2017, 3:46 PM
Jdlrobson closed this task as Resolved.Feb 15 2017, 6:03 PM
Jdlrobson claimed this task.

Build is green and checked with @Nirzar and he signed off.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits