[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T125822

[Epic] Basic first prototype for structured data support for Commons
Closed, ResolvedPublic
Actions

Description

This ticket is tracking everything we need for the first ugly prototype for structured data support for Commons.

It will not be deployed on Commons but only on a test system. It will have the file meta data stored on a separate page still. It will not be able to use items and properties from Wikidata yet.

This includes only a very basic implementation.

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
 OpenNoneT115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
 DuplicateNoneT115864 Figure out if the description of the image can be used as the caption on-wiki
 OpenFeatureNoneT53032 When inserting an image, set its caption by default to be the Commons image description
 DuplicateNoneT39535 Wikimedia Commons should support filtering by color
 OpenFeatureNoneT39534 Wikimedia Commons should support searching by color
 ResolvedNoneT19503 Provide metadata support on Wikimedia Commons
 ResolvedNoneT51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
 ResolvedNoneT68108 [Epic] Store media information for files on Wikimedia Commons as structured data
 ResolveddanielT134473 Create MediaInfo / Linking multimedia files to their mediainfo entity (second prototype)
 ResolvedTobi_WMDE_SWT125822 [Epic] Basic first prototype for structured data support for Commons
 ResolvedNoneT128467 [Task] Request project on gerrit for WikibaseMediaInfo
 ResolvedLuke081515T128469 [Task] Request phabricator project for WikibaseMediaInfo extension
 ResolvedBeneT128470 [Task] Create serializers for MediaInfo entity type
 ResolvedBeneT125824 [Task] Create a new media info entity type
 ResolvedBeneT128471 [Task] Create an alpha setup on labs for the MediaInfo extension
 Resolved• adrianheineT129275 [Task] Create js widget for media info entity type
 Resolved• adrianheineT128472 [Task] Create entity view for media info entity type
 ResolvedBeneT127191 [Task] Allow extensions to register additonal EntityViews
 ResolvedBeneT129380 [Task] Create MediaWiki content handler for mediainfo entity/content type
 ResolvedthiemowmdeT132442 [Task] Introduce differ for MediaInfo
 ResolvedthiemowmdeT78298 [Task] Split Diff/Patching code to allow constructing other Differs/Patchers
 ResolvedJeroenDeDauwT45326 Cleanup EntityDiff
 ResolvedthiemowmdeT128468 [Task] Release DataModel 6.0
 ResolvedBeneT128362 [Task] Deprecate and remove Holder interfaces
 ResolvedNoneT126152 [RFC] Design of provider/holder interfaces in Wikibase's data model
 ResolvedBeneT78287 [Task] Remove deprecated Entity
 DeclinedBeneT78291 [Task] Remove deprecated term methods from Entity
 DuplicateNoneT133043 [Task] EntityFactory::newEmpty does not work for MediaInfo
 Declined• adrianheineT133044 [Task] Handle cases where assiging a fresh ID to a new entity expects numeric entity IDs
 Resolved• adrianheineT133767 Add EntityFactory callback to MediaInfo entity type definition
 ResolveddanielT132964 Allow EntityFactory to work in Wikibase for more entity types
 Declined• adrianheineT133861 Stop using numeric ids in wb_entity_per_page
 Resolved• adrianheineT134264 [Task] Add EntityId builder pair to MediaInfo entity type definition
 Resolved• adrianheineT134265 [Task] Add EntityDifferStrategy builder to MediaInfo entity type definition
 Resolved• adrianheineT134873 Make EntityRevisionLookup not rely on entity_per_page
 DeclinedNoneT134874 Don't insert media info into entity_per_page
 Resolved• adrianheineT135593 [Task] Add default permissions for MediaInfo

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Lydia_Pintscher added projects: Commons, Epic, Wikidata, SDC General.Feb 4 2016, 2:44 PM
Restricted Application added subscribers: Steinsplitter, Aklapper. · View Herald TranscriptFeb 4 2016, 2:44 PM
Lydia_Pintscher added a subtask: T75496: [Epic] Support new types of Entities in Wikibase Repository.Feb 4 2016, 2:45 PM
Bene renamed this task from [Epic] Ugly first prototype for structured data support for Commons to [Epic] Basic first prototype for structured data support for Commons.Feb 4 2016, 3:39 PM
Bene updated the task description. (Show Details)
Bene set Security to None.
Bene subscribed.
JeanFred subscribed.Feb 4 2016, 4:48 PM
Ricordisamoa subscribed.Feb 5 2016, 7:53 AM
Tobi_WMDE_SW subscribed.Feb 5 2016, 10:36 AM
Steinsplitter moved this task from Incoming to Backlog on the Commons board.Feb 13 2016, 5:33 PM
Tobi_WMDE_SW updated the task description. (Show Details)Feb 15 2016, 2:13 PM
El_Grafo subscribed.Feb 16 2016, 1:33 PM
Jheald subscribed.Feb 16 2016, 4:19 PM
Lydia_Pintscher moved this task from incoming to hold on the Wikidata board.Feb 19 2016, 10:30 AM
• iecetcwcpggwqpgciazwvzpfjpwomjxn subscribed.Feb 28 2016, 12:33 AM
Bene raised the priority of this task from Medium to High.Mar 1 2016, 3:10 PM
Bene removed a subtask: T125826: [Task] Decide on structure of entity ID for media info entity type.
Bene created subtask T128467: [Task] Request project on gerrit for WikibaseMediaInfo.
Bene created subtask T128469: [Task] Request phabricator project for WikibaseMediaInfo extension.Mar 1 2016, 3:18 PM
Bene created subtask T128470: [Task] Create serializers for MediaInfo entity type.
Bene created subtask T128471: [Task] Create an alpha setup on labs for the MediaInfo extension.Mar 1 2016, 3:22 PM
Bene created subtask T128472: [Task] Create entity view for media info entity type.Mar 1 2016, 3:26 PM
Luke081515 closed subtask T128469: [Task] Request phabricator project for WikibaseMediaInfo extension as Resolved.Mar 1 2016, 5:54 PM
Bene added a project: Wikidata-Sprint-2016-03-01.Mar 2 2016, 11:10 AM
• DannyH subscribed.Mar 2 2016, 4:36 PM
Bene closed subtask T128467: [Task] Request project on gerrit for WikibaseMediaInfo as Resolved.Mar 2 2016, 5:15 PM
Raymond subscribed.Mar 7 2016, 9:35 PM
Ayack subscribed.Mar 7 2016, 10:50 PM
Bene closed subtask T128470: [Task] Create serializers for MediaInfo entity type as Resolved.Mar 7 2016, 11:06 PM
Bene closed subtask T125824: [Task] Create a new media info entity type as Resolved.
Smalyshev subscribed.Mar 7 2016, 11:13 PM
LikeLifer subscribed.Mar 8 2016, 12:11 AM
Bene created subtask T129275: [Task] Create js widget for media info entity type.Mar 8 2016, 8:47 PM
Bene created subtask T129380: [Task] Create MediaWiki content handler for mediainfo entity/content type.Mar 9 2016, 6:02 PM
Bene closed subtask T128472: [Task] Create entity view for media info entity type as Resolved.Mar 10 2016, 5:33 PM
Bene closed subtask T128471: [Task] Create an alpha setup on labs for the MediaInfo extension as Resolved.Mar 10 2016, 11:39 PM
daniel closed subtask T129380: [Task] Create MediaWiki content handler for mediainfo entity/content type as Resolved.Mar 15 2016, 4:42 PM
thiemowmde moved this task from Proposed to Doing on the Wikidata-Sprint-2016-03-01 board.Mar 18 2016, 8:51 AM
• adrianheine subscribed.Apr 5 2016, 8:22 AM

I just tried to create a MediaInfo entity through wbeditentity using I78ce2ac14a6750807f09722c7b0a48a3e199228e. What still fails and thus prevents successful creation of entities:

  • WikiPageEntityMetaDataLookup uses getNumericId
  • EntityFactory is initialized with a static list in WikibaseRepo and calls the factory methods newEmpty on EntityId classes.
  • WikiPageEntityStore calls setId with a number
  • Diffing support
Tobi_WMDE_SW added a project: Wikidata-Sprint-2016-04-12.Apr 12 2016, 11:35 AM
Tobi_WMDE_SW moved this task from Proposed to Backlog on the Wikidata-Sprint-2016-04-12 board.
Tobi_WMDE_SW added a subtask: T132442: [Task] Introduce differ for MediaInfo.Apr 12 2016, 12:56 PM
Tobi_WMDE_SW moved this task from Backlog to Proposed on the Wikidata-Sprint-2016-04-12 board.Apr 12 2016, 3:14 PM
aude subscribed.Apr 18 2016, 6:47 PM

ran into the same issues as Adrian:

  • EntityFactory::newEmpty does not work for MediaInfo, because it uses a hardcoded mapping of entity types and classes (w/o any hook or such for new types)
  • Places in the code when assigning a fresh id to a new entity that expect numeric entity ids and expect methods like ItemId::newFromNumber exist for MediaInfoId
  • Problem with serialization (calling Wikibase\DataModel\SerializerFactory::newEntitySerializer, which is aware of only Item and Property entity types) in ParserOutputJsConfigBuilder - fixed by Bene's not-yet-merged chain of patches Gerrit change 278566
  • Problem with diffing: "Diffing the provided types of entities is not supported", "*": "#0 /var/www/wiki/w/extensions/Wikidata/vendor/wikibase/data-model-services/src/Diff/EntityDiffer.php - presumably what phab:T78298 is working to address.
Restricted Application added a subscriber: Poyekhali. · View Herald TranscriptApr 18 2016, 6:47 PM
aude created subtask T132964: Allow EntityFactory to work in Wikibase for more entity types.Apr 18 2016, 8:27 PM
Tobi_WMDE_SW created subtask T133043: [Task] EntityFactory::newEmpty does not work for MediaInfo.Apr 19 2016, 2:27 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 19 2016, 2:27 PM
Tobi_WMDE_SW created subtask T133044: [Task] Handle cases where assiging a fresh ID to a new entity expects numeric entity IDs.Apr 19 2016, 2:32 PM
JeanFred unsubscribed.Apr 19 2016, 3:43 PM
Tobi_WMDE_SW added a project: Wikidata-Sprint-2016-04-26.Apr 25 2016, 1:49 PM
• adrianheine created subtask T133767: Add EntityFactory callback to MediaInfo entity type definition.Apr 27 2016, 8:58 AM
• adrianheine closed subtask T132964: Allow EntityFactory to work in Wikibase for more entity types as Resolved.Apr 27 2016, 11:29 AM
• adrianheine closed subtask T132442: [Task] Introduce differ for MediaInfo as Resolved.May 2 2016, 8:59 AM
• adrianheine closed subtask T133044: [Task] Handle cases where assiging a fresh ID to a new entity expects numeric entity IDs as Declined.May 3 2016, 2:30 PM
• adrianheine added a subtask: T133861: Stop using numeric ids in wb_entity_per_page.May 3 2016, 2:33 PM
• adrianheine created subtask T134264: [Task] Add EntityId builder pair to MediaInfo entity type definition.
• adrianheine created subtask T134265: [Task] Add EntityDifferStrategy builder to MediaInfo entity type definition.
• adrianheine removed a subtask: T75496: [Epic] Support new types of Entities in Wikibase Repository.May 3 2016, 9:06 PM
• adrianheine moved this task from Proposed to Doing on the Wikidata-Sprint-2016-04-26 board.
Lydia_Pintscher added a parent task: T134473: Create MediaInfo / Linking multimedia files to their mediainfo entity (second prototype).May 5 2016, 7:23 AM
• adrianheine closed subtask T133767: Add EntityFactory callback to MediaInfo entity type definition as Resolved.May 9 2016, 8:49 AM
• Jonas closed subtask T134265: [Task] Add EntityDifferStrategy builder to MediaInfo entity type definition as Resolved.May 9 2016, 10:11 AM
• Jonas closed subtask T134264: [Task] Add EntityId builder pair to MediaInfo entity type definition as Resolved.
• Jonas changed the status of subtask T133861: Stop using numeric ids in wb_entity_per_page from Open to Stalled.May 9 2016, 12:44 PM
Tobi_WMDE_SW added a project: Wikidata-Sprint-2016-05-10.May 10 2016, 11:52 AM
Tobi_WMDE_SW moved this task from Proposed to Doing on the Wikidata-Sprint-2016-05-10 board.May 10 2016, 11:52 AM
Tobi_WMDE_SW added subtasks: T134873: Make EntityRevisionLookup not rely on entity_per_page, T134874: Don't insert media info into entity_per_page.May 10 2016, 12:45 PM
Tobi_WMDE_SW added a subtask: T134756: [Task] Update demo-system to show mediainfo entity.May 17 2016, 12:13 PM
• adrianheine closed subtask T133861: Stop using numeric ids in wb_entity_per_page as Declined.May 17 2016, 6:19 PM
• adrianheine created subtask T135593: [Task] Add default permissions for MediaInfo.May 18 2016, 8:22 AM
• adrianheine closed subtask T129275: [Task] Create js widget for media info entity type as Resolved.May 18 2016, 11:38 AM
• adrianheine closed subtask T134873: Make EntityRevisionLookup not rely on entity_per_page as Resolved.
Lydia_Pintscher added a project: Wikidata-Sprint-2016-05-24.May 24 2016, 12:43 PM
Addshore closed subtask T134874: Don't insert media info into entity_per_page as Declined.May 24 2016, 12:52 PM
thiemowmde closed subtask T135593: [Task] Add default permissions for MediaInfo as Resolved.May 25 2016, 5:42 PM
• DannyH mentioned this in T121731: Investigation: Assistance with structured data on Commons.Jun 13 2016, 10:49 PM
Tobi_WMDE_SW added a project: Wikidata-Sprint-2016-07-05.Jul 5 2016, 12:59 PM
Tobi_WMDE_SW moved this task from Proposed to Backlog on the Wikidata-Sprint-2016-07-05 board.
Niharika subscribed.Jul 18 2016, 11:10 AM
aude added a comment.Jul 19 2016, 3:25 AM
This comment was removed by aude.
Tobi_WMDE_SW added a project: Wikidata-Sprint-2016-07-19.Jul 19 2016, 12:52 PM
Tobi_WMDE_SW moved this task from Proposed to Backlog on the Wikidata-Sprint-2016-07-19 board.Jul 19 2016, 12:52 PM
Tobi_WMDE_SW closed this task as Resolved.Jul 19 2016, 1:13 PM
Tobi_WMDE_SW claimed this task.
Tobi_WMDE_SW moved this task from Backlog to Proposed on the Wikidata-Sprint-2016-07-19 board.
Tobi_WMDE_SW removed a project: Wikidata-Sprint-2016-07-19.Jul 19 2016, 2:07 PM

The demo system has been updated with the functionality that was needed for this very first prototype, so we are closing this. A more advanced prototype with more functionality is currently being worked on and this is tracked in T134473

Tobi_WMDE_SW removed a subtask: T134756: [Task] Update demo-system to show mediainfo entity.Jul 19 2016, 2:27 PM
Niharika added a comment.Jul 19 2016, 4:34 PM
In T125822#2475161, @Tobi_WMDE_SW wrote:

The demo system has been updated with the functionality that was needed for this very first prototype, so we are closing this. A more advanced prototype with more functionality is currently being worked on and this is tracked in T134473

Is the demo system you mention available for public access?

Lydia_Pintscher subscribed.Jul 19 2016, 7:57 PM
In T125822#2475976, @Niharika wrote:

Is the demo system you mention available for public access?

Yes. I will send an email with some more explanation and context in the next days. (Without it it doesn't make a lot of sense so far.)

Tobi_WMDE_SW moved this task from Backlog to Done on the Wikidata-Sprint-2016-07-05 board.Jul 20 2016, 7:44 AM
Lectrician1 added a project: DataTypes.Jul 10 2022, 10:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits