[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T111041

Duplicate icons: 'puzzle' icon and 'template' (in VE)
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To
Jdforrester-WMF
Authored By
Esanders
Sep 1 2015, 1:37 PM
Tags
Referenced Files
F8573892: image.png
Jun 29 2017, 5:17 PM
F8573889: image.png
Jun 29 2017, 5:17 PM
F2526821: pasted_file
Sep 1 2015, 1:37 PM
F2526819: pasted_file
Sep 1 2015, 1:37 PM
F2526816: pasted_file
Sep 1 2015, 1:37 PM
Subscribers
Aklapper
Esanders
gerritbot
Jdforrester-WMF
RHo
StudiesWorld
Volker_E

Description

pasted_file (35×104 px, 1 KB)

pasted_file (32×89 px, 1 KB)

Also this icon should probably be converted to a puzzle piece:

pasted_file (41×146 px, 1 KB)

Details

SubjectRepoBranchLines +/-
Drop local 'template' icon, use 'puzzle' from upstreammediawiki/extensions/VisualEditormaster+11 -23
icons: Replace the puzzle icon, using the one from VisualEditoroojs/uimaster+10 -24
Customize query in gerrit

Related Objects
Search...

Event Timeline

Esanders created this task.Sep 1 2015, 1:37 PM
Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders added a project: OOUI.
Esanders subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 1 2015, 1:37 PM
Esanders closed this task as a duplicate of T55733: Use the same icons to represent the same things (tracking).Sep 1 2015, 1:37 PM
Esanders renamed this task from Merge 'puzzle' icon with 'template' (in VE) to Duplicate icons: Merge 'puzzle' icon with 'template' (in VE).Sep 1 2015, 1:43 PM
Esanders renamed this task from Duplicate icons: Merge 'puzzle' icon with 'template' (in VE) to Duplicate icons: 'puzzle' icon and 'template' (in VE).
Esanders reopened this task as Open.
Esanders added a parent task: T55733: Use the same icons to represent the same things (tracking).
Esanders set Security to None.
Esanders added a project: VisualEditor.Dec 19 2015, 12:56 PM
Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptDec 19 2015, 12:56 PM
Jdforrester-WMF triaged this task as Low priority.Jan 12 2016, 8:18 PM
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF added a parent task: T141801: WikimediaUI (Codex/OOUI) icon inventory (tracking).Aug 1 2016, 6:11 PM
Jdforrester-WMF moved this task from TR0: Interrupt to External and Administrivia on the VisualEditor board.Mar 16 2017, 5:24 PM
Volker_E mentioned this in T141801: WikimediaUI (Codex/OOUI) icon inventory (tracking).Jun 18 2017, 3:34 PM
Volker_E added subscribers: Jdforrester-WMF, Volker_E.

@Esanders @Jdforrester-WMF Is 'puzzle' in use anywhere? I couldn't find icon: 'puzzle' either in core or VE.

RHo subscribed.Jun 19 2017, 1:00 PM
Jdforrester-WMF added a comment.Jun 29 2017, 4:59 PM
In T111041#3358432, @Volker_E wrote:

@Esanders @Jdforrester-WMF Is 'puzzle' in use anywhere? I couldn't find icon: 'puzzle' either in core or VE.

Nope. VE has kept using it's "original" icon, and AFAIAA nothing else tries to pictographically reflect the concept of a template. We could just upstream VE's item, over-writing the current icon, and switch to that?

Jdforrester-WMF claimed this task.Jun 29 2017, 5:17 PM
Volker_E added a comment.Jun 29 2017, 5:17 PM

Design team, foremost @RHo is in the process of aligning all icons to our style guide. What were the specific advantages of the VE icon over the current OOjs UI one?

image.png (84×182 px, 3 KB)
vs
image.png (166×878 px, 11 KB)

gerritbot subscribed.Jun 29 2017, 5:23 PM

Change 362242 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[oojs/ui@master] icons: Replace the puzzle icon, using the one from VisualEditor

https://gerrit.wikimedia.org/r/362242

gerritbot added a project: Patch-For-Review.Jun 29 2017, 5:23 PM
RHo added a comment.Jun 30 2017, 12:09 PM

@Volker_E - happy to go with the VE one in use, under the assumption the VE one will be updated slightly as part of the coming icon set (e.g., the curved left and right hand sides of the puzzle shape will be straightened)

Jdforrester-WMF moved this task from Backlog to Reviewing on the OOUI board.Jul 6 2017, 3:36 PM
Jdforrester-WMF closed this task as Resolved.Jul 6 2017, 4:47 PM
Jdforrester-WMF moved this task from Reviewing to OOjs-UI-0.22.3 on the OOUI board.
Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.22.3); removed OOUI.
Jdforrester-WMF removed a project: Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJul 6 2017, 4:47 PM
gerritbot added a comment.Jul 6 2017, 4:53 PM

Change 363631 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Drop local 'template' icon, use 'puzzle' from upstream

https://gerrit.wikimedia.org/r/363631

gerritbot added a project: Patch-For-Review.Jul 6 2017, 4:53 PM

Change 362242 merged by jenkins-bot:
[oojs/ui@master] icons: Replace the puzzle icon, using the one from VisualEditor

https://gerrit.wikimedia.org/r/362242

Jdforrester-WMF changed the point value for this task from 1 to 0.Jul 14 2017, 11:20 PM
Jdforrester-WMF changed the point value for this task from 0 to 1.
Jdforrester-WMF removed a project: Patch-For-Review.
gerritbot added a comment.Jul 17 2017, 3:09 PM

Change 363631 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Drop local 'template' icon, use 'puzzle' from upstream

https://gerrit.wikimedia.org/r/363631

Jdforrester-WMF added a project: MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)).Jul 17 2017, 3:35 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits