It would be great to have the visual editor to edit books in Wikisource.
Description
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Open | None | T52000 Enable VisualEditor by default for all users of all Wikimedia wikis | |||
Open | None | T138391 Enable VisualEditor by default for all users of all Wikisources | |||
Open | None | T138966 Make the VisualEditor/ProofreadPage integration good enough to enable by default | |||
Resolved | Tpt | T93525 Add the visual editor to Wikisource | |||
Resolved | coren | T48580 Create a VisualEditor plugin to integrate with ProofreadPage | |||
Resolved | None | T48616 ProofreadPage extension needs to be refactored | |||
Resolved | None | T48578 Refactor the edition of Page: pages JavaScript module | |||
Resolved | Esanders | T97166 Move code specific to page editing out of ve.init.mw.Target | |||
Resolved | Tpt | T133294 Get rid of <div class="pagetext"> which spans multiple sections, so that each section is balanced HTML |
Event Timeline
I'm at least aware about this:
https://lists.wikimedia.org/pipermail/wikisource-l/2015-March/002197.html
This is also a topic for offline because it's impossible to provide a good ZIM file of Wikisource as long as Parsoid is not able to deal correctly with it.
Two years ago we did a survey within the international Wikisource community: http://meta.wikimedia.org/wiki/Wikisource_Community_User_Group/Wikisource_survey_report#Visual_Editor
In the wikisource-l ml, we discussed about this a few times. It is definitely not me alone :-)
It would be great if you reached a consensus in the village pump and provided the link to it
I believe that the consensus about it is fairly clear. No need for discussions on different languages Scriptoriums.
Is this task asking for VisualEditor to be enabled for opt-in to edit the main and user namespaces right now, or to wait until T48580: Create a VisualEditor plugin to integrate with ProofreadPage is complete? If the second, that is a lot of work and won't happen soon.
Sure, but it was also written as a Site Request, so I assumed that the person doing that understood. I've removed that project as this request isn't actionable until then.
Hi James,
for many Wikisource, implementation of the VE in the ns0 is not-so important. As you are maybe aware, we have a Page: namespace that is the place where the transcription really happens, with the scan of the page of the book. I was aware of the owrk of Tpt and Rohit (if'm not mistaken), who tried to refactor the Proofread Page extension.
Some notes from Wikimedia-Hackathon-2016 concerning WS Mainspace and proofreading system using VE: https://etherpad.wikimedia.org/p/ve-wikisource
So, with T48580: Create a VisualEditor plugin to integrate with ProofreadPage closed, as of next Wednesday there will be a (basic) VisualEditor integration on Page: pages too. You can see it in action now on Beta Cluster, though it doesn't look very impressive as DjVu file rendering is currently broken there.
There are several improvements we will make, but for now I'm declaring this done. Great work, everyone! Next up will be real-world final testing, and then we can set about making it available by default for users on each of the Wikisources, in T138391.
This version does not seem to be functional yet:
- I see no way to change proofread status of a page: and attempt to edit it manually ends with "unknown error" (I am surprised that the proofread status raw data is even available for the editor - it is a very bad idea). Changing the proofread status is a key functionality for Wikisource, however.
- Any attempt to edit header/footer seems to break them both (moving them or their parts into main edit area); see this diff:
http://en.wikisource.beta.wmflabs.org/w/index.php?title=Page%3ADictionary_of_National_Biography_volume_51.djvu%2F377&type=revision&diff=716&oldid=649
Is there a working version elsewhere? I do not think it is ready for integration.
I think it's T116816: beta cluster missing vips command needed to render tiffs and pngs, pnmtojpeg for DjVus. Apparently it's been broken for a while. We've just worked around it in ProofreadPage code, though, so it doesn't matter much for this use case.
I couldn't reproduce – http://en.wikisource.beta.wmflabs.org/w/index.php?diff=721&oldid=720 – perhaps an intermittent bug?
I installed the package needed for pnmtojpeg on the deployment-mediawiki* servers yesterday.
@Jdforrester-WMF: I agree with @Ankry - This version does not seem to be functional yet (...) Any attempt to edit header/footer seems to break them both...
It is easy to reproduce:
- step: Editing header and footer (added <div style="color:blue;"> in header and </div> in footer- see image
- step: Save Page -> Review your changes see image
editions of a header disappeared and been replaced with "</ div>"; editions of the footer have been transferred and mixed with the contents of the page...
Z.