- When a user loads an item page for the very first time the in other languages box should be expanded.
- After that whatever state the user sets it to should be stored and restored as it is currently done
- Special:Preference 'Show labels, aliases and descriptions in all my languages on page load' should be checked by default
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| [Task] Expand in other languages box by default | mediawiki/extensions/Wikibase | master | +14 -10 |
| Status | Subtype | Assigned | Task | |
|---|---|---|---|---|
| · · · | ||||
| Invalid | None | T75654 Redesign Wikidata header | ||
| Resolved | • Jonas | T92387 [Story] Expand in other languages box by default | ||
| Resolved | • Jonas | T124754 [Task] Remove Babel check from showTermsList settings | ||
| · · · |
Event Timeline
Comment Actions
The reason for opening this ticket is not specified in the sense of that the ticket would not have been opened unless there was not already an opinion about the current state not being the one desired. Specifying that opinion would probably help getting the discussion started and ensure focus on the issue that lead to opening the ticket.
Comment Actions
In general, nothing should be hidden by default. There will always be a major percentage of users that miss collapsed stuff, no matter how obvious the expand button is. So please: Expand by default, the user sees it, can collapse it if he wants and it stays collapsed.
Please note that the collapsing feature in MediaWiki core's side bar was completely removed partly because of this reason (and because of performance).
Comment Actions
Yes I do have an opinion but I want to get input before we make a final decision. That's why this ticket.
Comment Actions
I do not have a strict opinion on that matter yet. But, hm, sorry guys, those two comments above are not really helpful to get one. :-/
Comment Actions
A slightly related thing: Currently you cannot expand without JS enabled, which means if you don't have working JS, the box might just not be there. If it's collapsed by default, you might not even now that there should be something. If it's shown by default, you would maybe at least remember that there should be something. We could of course also fix this by supporting toggling via static link, or by collapsing with JS (which would look jumpy, though).
Comment Actions
Change 265474 had a related patch set uploaded (by Jonas Kress (WMDE)):
[Task] Expand in other languages box by default
Comment Actions
@Lydia_Pintscher @Snaterlicious Can you explain why the user preference is only present when Babel is installed?
Comment Actions
What are you aiming for with this question? What does "exist" mean? Exist in which context?
First fact is that anonymous users don't have user preferences. Our code falls back to use a cookie in this case.
Next fact is that only users with a Babel box can control which languages are shown in the terms list view. All other users (this includes all anonymous users as well as all logged in users that don't have a Babel box) get some additional languages picked by ULS. This (but only this) is a client-only feature.
When the Babel extension is installed users can control the set of languages. When Babel is missing they can't. This does not have anything to do with the question if the box is and can be expanded and collapsed.
As far as I can see the code introduced in https://gerrit.wikimedia.org/r/#/c/183498/20/repo/Wikibase.hooks.php is a mistake.
Comment Actions
@adrianheine: You mean why we only store if the box is collapsed or not if the babel extension is installed? (I don't know if that is the case.)
Comment Actions
Yes for logged in users options and settings only work when babel is installed. I have no clue why this is the case ...
Comment Actions
Hmmmm ok. Not sure why we store collapsed state only when Babel is installed. I don't see a reason. I think we can change this.