[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T85372

Add support for per-category editnotices
Closed, ResolvedPublic
Actions

Description

To avoid use of a js hack and for increased compatibility, such as with visual editor (cf T56029), this is a request to support per-category editnotices. This had already been discussed in T20596, but the prospect of extension PageInCat being implemented, even for mediawiki pages, seems remote.

Details

SubjectRepoBranchLines +/-
Add per-category editnoticesmediawiki/coremaster+64 -2
Add per-category editnoticesmediawiki/coremaster+0 -0
Add per-category editnoticesmediawiki/coremaster+139 -9
Add per-category editnotices, rebased 189178mediawiki/coremaster+138 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

Cenarium created this task.Dec 27 2014, 2:38 PM
Cenarium raised the priority of this task from to Needs Triage.
Cenarium updated the task description. (Show Details)
Cenarium added a project: MediaWiki-General.
Cenarium subscribed.
Cenarium mentioned this in T56029: VisualEditor: Provide support for BLP edit notices on enwiki.Dec 27 2014, 2:44 PM
Aklapper triaged this task as Lowest priority.Dec 28 2014, 11:17 PM
Aklapper edited projects, added MediaWiki-Page-editing, MediaWiki-Categories; removed MediaWiki-General.
Aklapper set Security to None.
gerritbot added a project: Patch-For-Review.Feb 13 2015, 2:41 PM
gerritbot subscribed.

Change 189178 had a related patch set uploaded (by Cenarium):
Adding support for per category editnotices

https://gerrit.wikimedia.org/r/189178

Patch-For-Review

Quiddity mentioned this in T51622: Add support for (the equivalent of?) editintro and preload.Jun 20 2015, 6:20 PM
Quiddity subscribed.Jun 20 2015, 6:34 PM
• Elitre subscribed.Jun 22 2015, 3:32 PM
Jdforrester-WMF added a parent task: T56029: VisualEditor: Provide support for BLP edit notices on enwiki.Aug 7 2015, 4:06 PM
Jdforrester-WMF assigned this task to Cenarium.Sep 2 2015, 7:15 PM
Jdforrester-WMF raised the priority of this task from Lowest to High.
Jdforrester-WMF added a project: Contributors-Team.
Legoktm added a parent task: T71550: Move code in enwiki MediaWiki:Common.js and Gadgets to MediaWiki software.Sep 4 2015, 7:06 PM
tstarling mentioned this in T124379: Move edit notices for pages out of the MediaWiki namespace and into a parser function on the page itself.Jan 22 2016, 12:49 AM
Kharkiv07 subscribed.Feb 4 2016, 7:25 PM
whym awarded a token.Mar 9 2016, 8:19 AM
Boshomi subscribed.May 29 2016, 1:10 AM
JJMC89 subscribed.Sep 22 2016, 3:58 PM
Arthur2e5 awarded a token.Sep 24 2016, 5:45 PM
Arthur2e5 subscribed.
Arthur2e5 added a comment.Sep 24 2016, 6:14 PM

When will this patch get merged?

In addition to allowing BLP editnotices to be added with less hacks, WikiProjects can make use of this feature too.

Liuxinyu970226 subscribed.Sep 25 2016, 9:45 AM
Jack_who_built_the_house awarded a token.Mar 26 2017, 2:41 PM
Jack_who_built_the_house subscribed.
Iniquity subscribed.Nov 8 2017, 4:44 AM

Any progress here? :)

Aklapper added a comment.Nov 8 2017, 2:47 PM

https://gerrit.wikimedia.org/r/#/c/189178/ needs a manual rebase if you'd like to progress.

Iniquity added a comment.Nov 14 2017, 9:19 AM

@Aklapper Hello, can you help me? Should I create a new patch for this?

Iniquity added a comment.Nov 16 2017, 12:05 PM

Rebased
https://gerrit.wikimedia.org/r/#/c/391796/

gerritbot added a comment.Jun 14 2018, 3:56 PM

Change 391796 abandoned by Iniquity:
Add per-category editnotices, rebased 189178

https://gerrit.wikimedia.org/r/391796

TheDJ mentioned this in T201613: Unify 'edit notices' technology stack.Aug 9 2018, 2:11 PM
TheDJ added a parent task: T201613: Unify 'edit notices' technology stack.
ToBeFree awarded a token.Dec 3 2018, 4:39 PM
ToBeFree subscribed.
Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Feb 19 2020, 3:19 PM
Aklapper removed Cenarium as the assignee of this task.May 17 2020, 12:39 PM

@Cenarium: I am resetting the assignee of this task because there has not been progress lately (please correct me if I am wrong!). Resetting the assignee avoids the impression that somebody is already working on this task. It also allows others to potentially work towards fixing this task. Please claim this task again when you plan to work on it (via Add Action... → Assign / Claim in the dropdown menu) - it would be welcome. Thanks for your understanding!

Proc subscribed.Aug 29 2020, 10:29 AM
gerritbot added a comment.Feb 22 2022, 9:40 PM

Change 764831 had a related patch set uploaded (by EpicPupper; author: EpicPupper):

[mediawiki/core@master] Add per-category editnotices

https://gerrit.wikimedia.org/r/764831

gerritbot added a project: Patch-For-Review.Feb 22 2022, 9:40 PM
Restricted Application removed a project: Patch-Needs-Improvement. · View Herald TranscriptFeb 22 2022, 9:40 PM
gerritbot added a comment.Feb 22 2022, 9:47 PM

Change 764832 had a related patch set uploaded (by EpicPupper; author: EpicPupper):

[mediawiki/core@master] Add per-category editnotices

https://gerrit.wikimedia.org/r/764832

gerritbot added a comment.Feb 22 2022, 9:48 PM

Change 764831 abandoned by EpicPupper:

[mediawiki/core@master] Add per-category editnotices

Reason:

https://gerrit.wikimedia.org/r/764831

Frostly subscribed.Feb 22 2022, 9:50 PM
• Elitre unsubscribed.Mar 1 2022, 1:05 PM
• MZMcBride subscribed.Mar 3 2022, 11:11 PM
gerritbot added a comment.May 16 2022, 9:27 AM

Change 764832 abandoned by EpicPupper:

[mediawiki/core@master] Add per-category editnotices

Reason:

Yeah, no.

https://gerrit.wikimedia.org/r/764832

Aklapper lowered the priority of this task from High to Low.Dec 14 2022, 2:21 PM
Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review, Contributors-Team.
matmarex removed a parent task: T56029: VisualEditor: Provide support for BLP edit notices on enwiki.Apr 20 2023, 1:08 AM
matmarex removed a parent task: T201613: Unify 'edit notices' technology stack.
Izno subscribed.Apr 20 2023, 1:11 AM
Galobtter subscribed.May 1 2023, 9:08 AM

If T50175 is doable, it's probably the best way to do this. That would enable other functionality and enable wikis to properly customize when they load editnotices.

Pcoombe added a project: MediaWiki-Editnotice.Jul 3 2023, 9:14 PM
mirror-kt subscribed.Nov 5 2023, 1:07 AM
Quiddity mentioned this in T50175: Scribunto/Lua should have a built-in method for retrieving categories used on a page.Aug 7 2024, 7:28 PM
SD0001 closed this task as Resolved.Aug 15 2024, 6:31 PM
SD0001 claimed this task.
SD0001 subscribed.
In T85372#8815895, @Galobtter wrote:

If T50175 is doable, it's probably the best way to do this. That would enable other functionality and enable wikis to properly customize when they load editnotices.

T50175 was done, so this is resolved for wikis with Scribunto installed. It doesn't seem worthwhile to address this for wikis without Scribunto.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits