[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T64039

MediaViewer confuses different instances of the same image on the same page
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  1. go to https://www.mediawiki.org/wiki/Multimedia/About_Media_Viewer
  2. Click on the first image of the How does Media Viewer work? section.

Observe that the caption is missing.

MediaViewer actually opened the first instance of the same image (somewhat higher on the page, has no caption), but this is not obvious and can be quite confusing when the caption has important information (e.g. legend for a chart is often placed there) and the user is expecting it.

Version: unspecified
Severity: normal

Details

Reference
bz62039
SubjectRepoBranchLines +/-
LightboxImage.originalWidth needs to be a propertymediawiki/extensions/MultimediaViewermaster+6 -12
Revert "Revert "Add position handling to URLs""mediawiki/extensions/MultimediaViewermaster+111 -115
Add position handling to URLsmediawiki/extensions/MultimediaViewermaster+110 -114
[WIP] Add position handling to URLsmediawiki/extensions/MultimediaViewermaster+26 -9
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:03 AM
• bzimport added a project: MediaViewer.
• bzimport set Reference to bz62039.
• bzimport added a subscriber: Unknown Object (MLST).
Tgr created this task.Feb 28 2014, 8:22 AM
MarkTraceur added a comment.Feb 28 2014, 6:39 PM

This was why we had MediaViewer/File:Foobar.jpg/6 instead of just MediaViewer/File:Foobar.jpg in the past - I made sure the index matched, so you got the same view no matter what.

Though we could at least be cognisant of the order when opening the lightbox. Seems not difficult.

Tgr added a comment.Feb 28 2014, 8:19 PM

That scheme had other problems (not stable enough, not to mention ugly :)
I would still go with MediaViewer/<filename>/<index relative to other thumbnails of the same file>, with MediaViewer/<filename>/1 being aliased to MediaViewer/<filename>.

MarkTraceur added a comment.Mar 3 2014, 8:01 PM

+1

• Gilles triaged this task as Low priority.Nov 24 2014, 2:50 PM
• Gilles subscribed.
• Gilles added a project: Multimedia.Nov 24 2014, 3:13 PM
Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 4 2015, 6:11 PM
Restricted Application added subscribers: Matanya, Aklapper. · View Herald TranscriptSep 4 2015, 6:11 PM
Jdforrester-WMF subscribed.Sep 21 2015, 3:44 PM

Mass-removing the Multimedia tag from MediaViewer tasks, as this is now being worked on by the Reading department, not Editing's Multimedia team.

Jdforrester-WMF removed a project: Multimedia.Sep 21 2015, 3:53 PM
gerritbot subscribed.Sep 24 2015, 9:22 PM

Change 126153 had a related patch set uploaded (by Gergő Tisza):
[WIP] Add position handling to URLs

https://gerrit.wikimedia.org/r/126153

gerritbot added a project: Patch-For-Review.Sep 24 2015, 9:22 PM
Jdlrobson changed the task status from Open to Stalled.Oct 9 2015, 12:59 AM
Jdlrobson subscribed.

Patch has been a WIP for some time now.

MBinder_WMF added a project: Web-Team-Backlog.May 17 2016, 6:35 PM
MBinder_WMF moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Jul 4 2016, 7:31 PM
Jdforrester-WMF unsubscribed.Jul 5 2016, 9:27 AM
Tgr mentioned this in T125817: MediaViewer is showing a tick image from references.Aug 5 2016, 11:26 PM
MarkTraceur unsubscribed.Jan 27 2017, 10:19 PM
MBinder_WMF removed a project: Web-Team-Backlog.Apr 13 2017, 6:40 PM
MBinder_WMF added a project: Multimedia.Aug 7 2017, 5:54 PM
Tgr mentioned this in T60663: media viewer doesn't preserve thumbnail options like svg language.Nov 2 2018, 8:35 PM
simon04 merged a task: T209574: Wrong image shown in MMV after clicking link to previous image, when image used more than once on that page.Jun 10 2019, 7:34 AM
simon04 added a subscriber: Schnark.
Tgr unsubscribed.Jul 9 2019, 6:05 PM
Schnark merged a task: T236228: If an image file is used multiple times within a page; MediaViewer always opens the first reference to it.Oct 23 2019, 7:01 AM
Schnark added a subscriber: HebronNor.
Aklapper changed the task status from Stalled to Open.Nov 1 2020, 10:00 PM
Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.

Anyone can rebase / improve a patch, hence removing stalled status.

Arthur2e5 subscribed.Dec 31 2020, 12:26 AM

Appears to be affecting the example presentation of multilingual images on a Commons template. See https://commons.wikimedia.org/wiki/Template_talk:Translate#New_Template%3A_Multilingual_Gallery.

matmarex merged tasks: T325423: MediaViewer always opens first instance of picture on a page; destroys navigation in gallery, T334810: MediaViewer shows caption of wrong image when used multiple times in the article.May 2 2023, 1:46 PM
matmarex added subscribers: MBH, 1234qwer1234qwer4, Tgr, Base.
gerritbot added a comment.May 10 2024, 7:58 AM

Change #1029980 had a related patch set uploaded (by Simon04; author: Simon04):

[mediawiki/extensions/MultimediaViewer@master] Add position handling to URLs

https://gerrit.wikimedia.org/r/1029980

gerritbot added a project: Patch-For-Review.May 10 2024, 7:58 AM
Restricted Application removed a project: Patch-Needs-Improvement. · View Herald TranscriptMay 10 2024, 7:58 AM
TheDJ added a project: User-TheDJ.May 14 2024, 11:07 PM
TheDJ merged a task: T77371: Add image position handling to MediaViewer URLs.May 15 2024, 12:20 AM
TheDJ added subscribers: MingleTerminator, Jay8g.
gerritbot added a comment.May 17 2024, 2:47 PM

Change #126153 abandoned by Jdlrobson:

[mediawiki/extensions/MultimediaViewer@master] [WIP] Add position handling to URLs

Reason:

A more recent patch has been posted so we will continue the conversation there: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MultimediaViewer/+/1029980

https://gerrit.wikimedia.org/r/126153

gerritbot added a comment.May 20 2024, 6:57 PM

Change #1029980 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] Add position handling to URLs

https://gerrit.wikimedia.org/r/1029980

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.6; 2024-05-21).May 20 2024, 7:00 PM
Jdlrobson closed this task as Resolved.May 20 2024, 8:05 PM
Jdlrobson claimed this task.
Jdlrobson added a project: Web-Team-Backlog (FY2023-24 Q4 Sprint 4).
TheDJ reopened this task as Open.May 20 2024, 8:49 PM
TheDJ subscribed.

This patch broke the resize event handler

[Error] TypeError: undefined is not an object (evaluating 'this.thumbs[this.currentIndex].title.getExtension')
	resize (load.php:2:801)
	(anonymous function) (load.php:12:560)
	dispatch (load.php:65:938)
	trigger (load.php:114:758)
	(anonymous function) (load.php:115:737)
	each (load.php:5:237)
	(anonymous function) (load.php:63:571)
	later (load.php:2:544)
Jdlrobson moved this task from Needs analysis to QA on the Web-Team-Backlog (FY2023-24 Q4 Sprint 4) board.May 20 2024, 8:52 PM
Jdlrobson edited projects, added Web-Team-Backlog (Needs Prioritization (Tech)); removed Web-Team-Backlog (FY2023-24 Q4 Sprint 4).
Jdlrobson moved this task from Backlog to Using Codex in web team products / Skin unification on the Web-Team-Backlog (Needs Prioritization (Tech)) board.May 20 2024, 8:55 PM
gerritbot added a comment.May 21 2024, 6:30 PM

Change #1034180 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/MultimediaViewer@master] Revert "Revert "Add position handling to URLs""

https://gerrit.wikimedia.org/r/1034180

gerritbot added a comment.May 21 2024, 7:27 PM

Change #1034180 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] Revert "Revert "Add position handling to URLs""

https://gerrit.wikimedia.org/r/1034180

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.7; 2024-05-28); removed MW-1.43-notes (1.43.0-wmf.6; 2024-05-21).May 21 2024, 8:00 PM
Jdlrobson closed this task as Resolved.May 21 2024, 8:22 PM
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q4 Sprint 4); removed Web-Team-Backlog (Needs Prioritization (Tech)).
GMikesell-WMF mentioned this in T365384: Verify 1.43.0-wmf.7 deployment.May 30 2024, 8:14 PM
Jdlrobson moved this task from QA to Ready for Signoff on the Web-Team-Backlog (FY2023-24 Q4 Sprint 4) board.May 31 2024, 4:05 AM
gerritbot added a comment.Jun 13 2024, 7:49 PM

Change #1043211 had a related patch set uploaded (by Simon04; author: Simon04):

[mediawiki/extensions/MultimediaViewer@master] LightboxImage.originalWidth needs to be a property

https://gerrit.wikimedia.org/r/1043211

gerritbot added a comment.Jun 21 2024, 12:39 AM

Change #1043211 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] LightboxImage.originalWidth needs to be a property

https://gerrit.wikimedia.org/r/1043211

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.11; 2024-06-25); removed MW-1.43-notes (1.43.0-wmf.7; 2024-05-28).Jun 21 2024, 1:00 AM
TheDJ mentioned this in T368301: STL 3D models broken: "Sorry, the file Undefined cannot be displayed since it is not present on the current page.".Jun 29 2024, 11:22 AM
GMikesell-WMF mentioned this in T367779: Verify 1.43.0-wmf.11 deployment.Jul 3 2024, 9:37 PM
Jdlrobson added a project: Verified.Jul 3 2024, 10:53 PM
Jdlrobson added a subscriber: simon04.

@simon04 @TheDJ the issue here seems to be fixed, but clicking the first and third images in the page do not load mediaviewer - is that expected or am I doing something wrong?

https://www.mediawiki.org/wiki/Extension:Media_Viewer/About?safemode=1

TheDJ added a comment.Jul 4 2024, 8:23 AM
In T64039#9952308, @Jdlrobson wrote:

@simon04 @TheDJ the issue here seems to be fixed, but clicking the first and third images in the page do not load mediaviewer - is that expected or am I doing something wrong?

https://www.mediawiki.org/wiki/Extension:Media_Viewer/About?safemode=1

They have the. noviewer class, because at some time people got confused when opening a screenshot of the interface in the same interface.

Jdlrobson added a comment.Jul 5 2024, 6:05 PM

Thanks for explaining! that wasn't obvious :)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits